Password screen in MD settings says passwords may be saved to keychain |
||||||||||||
Issue descriptionM59 beta macos 10.12.4 - go to chrome://settings/passwords Notice the text about saving the password to keychain, which we no longer do. The passwords also won't be shared with other users. The text needs to be fixed.
,
May 3 2017
,
May 4 2017
The migration away from Keychain is Issue 466638 . The final cl for that landed in September of 2016.
,
May 4 2017
Removing label, will send CL soon
,
May 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56aabec6e1277dde13b944d01e2fc2337c1cebf3 commit 56aabec6e1277dde13b944d01e2fc2337c1cebf3 Author: hcarmona <hcarmona@chromium.org> Date: Thu May 04 23:07:31 2017 MD-Settings: Remove Mac specific warning that's no longer relevant. Screenshot in bug. R=dschuyler@chromium.org BUG= 718210 Review-Url: https://codereview.chromium.org/2862773003 Cr-Commit-Position: refs/heads/master@{#469505} [modify] https://crrev.com/56aabec6e1277dde13b944d01e2fc2337c1cebf3/chrome/app/settings_strings.grdp
,
May 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56aabec6e1277dde13b944d01e2fc2337c1cebf3 commit 56aabec6e1277dde13b944d01e2fc2337c1cebf3 Author: hcarmona <hcarmona@chromium.org> Date: Thu May 04 23:07:31 2017 MD-Settings: Remove Mac specific warning that's no longer relevant. Screenshot in bug. R=dschuyler@chromium.org BUG= 718210 Review-Url: https://codereview.chromium.org/2862773003 Cr-Commit-Position: refs/heads/master@{#469505} [modify] https://crrev.com/56aabec6e1277dde13b944d01e2fc2337c1cebf3/chrome/app/settings_strings.grdp
,
May 5 2017
This is working fine on Mac OSX 10.12.4 - 60.0.3090.0 Please find the attached screen shots. hcarmona@, can you please request the merge to M59 branch as this is working fine on ToT latest build.
,
May 5 2017
Change is very low risk: removes mac specific string. Change is already in canary. Requesting merge to M59.
,
May 5 2017
,
May 5 2017
Thanks Jason for correct label!
,
May 5 2017
This bug requires manual review: There is .grd file changes and we are only 31 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 6 2017
Approving for M59 merge.
,
May 8 2017
Verified this issue on Mac OS 10.12.4 using chrome latest Beta M59-59.0.3071.41 by following steps mentioned in the original comment. Observed the Mac specific warning no more displayed under chrome://settings/passwords as expected. Hence adding TE-Verified label.
,
May 8 2017
Merged revision: http://crrev.com/2869503002 (Since this issue didn't get auto updated) Status -> Fixed
,
May 9 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 9 2017
Updating tags because this issue was already merged.
,
Nov 29
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by shrike@chromium.org
, May 3 2017Owner: dbeam@chromium.org
Status: Assigned (was: Untriaged)