New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718205 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 717089



Sign in to add a comment

[Findit] Add option to turn off auto revert feature

Project Member Reported by chanli@chromium.org, May 3 2017

Issue description

If CL owner adds a flag 'AUTO_REVERT_OFF=True' in CL description, Findit will not revert this CL automatically.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/58371db7221f0c23dc7ac7fc40708e388b3369c2

commit 58371db7221f0c23dc7ac7fc40708e388b3369c2
Author: Chan <chanli@chromium.org>
Date: Thu May 04 18:30:33 2017

[Findit] Add support for flag in CL description to turn off auto revert feature.

If CL owner adds a flag 'NOAUTOREVERT=True'  in CL description, Findit will not revert the CL automatically.

Bug:  718205 
Change-Id: Ic7aecd3b10384283c4fc070899e69da4bcb21832
Reviewed-on: https://chromium-review.googlesource.com/495227
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[add] https://crrev.com/58371db7221f0c23dc7ac7fc40708e388b3369c2/appengine/findit/infra_api_clients/codereview/test/codereview_test.py
[modify] https://crrev.com/58371db7221f0c23dc7ac7fc40708e388b3369c2/appengine/findit/infra_api_clients/codereview/test/gerrit_test.py
[modify] https://crrev.com/58371db7221f0c23dc7ac7fc40708e388b3369c2/appengine/findit/infra_api_clients/codereview/rietveld.py
[modify] https://crrev.com/58371db7221f0c23dc7ac7fc40708e388b3369c2/appengine/findit/infra_api_clients/codereview/gerrit.py
[modify] https://crrev.com/58371db7221f0c23dc7ac7fc40708e388b3369c2/appengine/findit/infra_api_clients/codereview/codereview.py
[modify] https://crrev.com/58371db7221f0c23dc7ac7fc40708e388b3369c2/appengine/findit/infra_api_clients/codereview/cl_info.py
[modify] https://crrev.com/58371db7221f0c23dc7ac7fc40708e388b3369c2/appengine/findit/infra_api_clients/codereview/test/rietveld_test.py
[modify] https://crrev.com/58371db7221f0c23dc7ac7fc40708e388b3369c2/appengine/findit/infra_api_clients/codereview/test/testissuedetails.json
[modify] https://crrev.com/58371db7221f0c23dc7ac7fc40708e388b3369c2/appengine/findit/infra_api_clients/codereview/codereview_util.py

Status: Fixed (was: Started)
Add logic to not create revert automatically if the flag is set: https://chromium-review.googlesource.com/c/496706/

Sign in to add a comment