Add tests for the interaction of screen rotation animation and overview button hide animation |
||
Issue descriptionScreen rotation animation implementation has been changed to optimize the performance. There is a test in OverviewButtonTrayTest, to test the screen rotation animation will not interrupt the hide animation of OverviewButtonTray. Since the new implementation will be co-exist with the old implementation, we need to add more tests to cover both situations. Because the new implementation is asynchronous and the screen_rotation_animator_unittest already adds the hooks to waiting for the callbacks, therefore it would be easier to test the interactions in screen_rotation_animator_unittest.cc. 1) Add two tests in screen_rotation_animator_unittest 2) Also change one of OverviewButtonTrayTest, to test hide animation will not interact with explicitly deleting layers, not through ScreenRotationAnimation.
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/310d861a8399fae1b082cd0d83db69b98d1df7da commit 310d861a8399fae1b082cd0d83db69b98d1df7da Author: wutao <wutao@chromium.org> Date: Thu Jun 01 00:37:05 2017 Add more tests to test OverviewButtonTray and ScreenRotationAnimator. Add more tests to test the hide animation of OverviewButtonTray and interaction with ScreenRotationAnimator. BUG= 718198 TEST=OverviewButtonTrayTest.HideAnimationAlwaysCompletes* and ScreenRotationAnimator[Smooth|Slow]AnimationTest.OverviewButtonTrayHideAnimation* Review-Url: https://codereview.chromium.org/2845123003 Cr-Commit-Position: refs/heads/master@{#476111} [modify] https://crrev.com/310d861a8399fae1b082cd0d83db69b98d1df7da/ash/rotator/screen_rotation_animator_unittest.cc [modify] https://crrev.com/310d861a8399fae1b082cd0d83db69b98d1df7da/ash/system/overview/overview_button_tray_unittest.cc [modify] https://crrev.com/310d861a8399fae1b082cd0d83db69b98d1df7da/testing/buildbot/filters/ash_unittests_mash.filter [modify] https://crrev.com/310d861a8399fae1b082cd0d83db69b98d1df7da/testing/buildbot/filters/ash_unittests_mus.filter
,
Jun 9 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by wutao@chromium.org
, May 3 2017