New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718191 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Return log location as a constant.

Project Member Reported by robert...@chromium.org, May 3 2017

Issue description

This is just to track when buildbucket returns the log_location tag without the $(swarming_run_id) part.
 

Comment 1 by no...@chromium.org, May 3 2017

Status: Started (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/9d1d5c0a39840171b09265554f3726303f3c60ad

commit 9d1d5c0a39840171b09265554f3726303f3c60ad
Author: Nodir Turakulov <nodir@google.com>
Date: Thu May 04 23:07:59 2017

Project Member

Comment 3 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/a47159cb773e3cc4d87122653bc01f38b1636c79

commit a47159cb773e3cc4d87122653bc01f38b1636c79
Author: Nodir Turakulov <nodir@google.com>
Date: Fri May 05 22:14:36 2017

Comment 4 by no...@chromium.org, May 5 2017

Status: Fixed (was: Started)
deployed, hopefully won't be reverted
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/78f4f98cd55742c20cb2200b2de767ab03251f14

commit 78f4f98cd55742c20cb2200b2de767ab03251f14
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 20 00:47:41 2017

remove swarming_run_id

swarming_run_id is not used for any current builds, and all builds which
use logdog specify the log_location swarming tag.

R=hinoka@chromium.org, nodir@chromium.org, robertocn@chromium.org

Bug:  758007 ,  718191 
Change-Id: I87772113efd46cfc256449ba3aa7a78da4fcf00e
Reviewed-on: https://chromium-review.googlesource.com/727546
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/78f4f98cd55742c20cb2200b2de767ab03251f14/appengine/findit/infra_api_clients/logdog_util.py
[modify] https://crrev.com/78f4f98cd55742c20cb2200b2de767ab03251f14/go/src/infra/tools/kitchen/cook_mode.go
[modify] https://crrev.com/78f4f98cd55742c20cb2200b2de767ab03251f14/go/src/infra/tools/kitchen/cook_test.go

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/74366d3656b1a44c3a2daad3fe6bb8356fadc2d2

commit 74366d3656b1a44c3a2daad3fe6bb8356fadc2d2
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 20 21:32:30 2017

[milo] remove swarming_run_id, implicit log_location.

swarming_run_id is not used for any current builds, and all builds which
use logdog specify the log_location swarming tag.

R=hinoka@chromium.org, nodir@chromium.org

Bug:  758007 ,  718191 
Change-Id: Id43924603ebe3465bf0baccfd39ef91adfea0fce
Reviewed-on: https://chromium-review.googlesource.com/727545
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/74366d3656b1a44c3a2daad3fe6bb8356fadc2d2/milo/buildsource/swarming/build.go
[modify] https://crrev.com/74366d3656b1a44c3a2daad3fe6bb8356fadc2d2/milo/buildsource/swarming/buildLog.go
[modify] https://crrev.com/74366d3656b1a44c3a2daad3fe6bb8356fadc2d2/milo/buildsource/swarming/buildinfo.go
[modify] https://crrev.com/74366d3656b1a44c3a2daad3fe6bb8356fadc2d2/milo/buildsource/swarming/buildinfo_test.go
[modify] https://crrev.com/74366d3656b1a44c3a2daad3fe6bb8356fadc2d2/milo/buildsource/swarming/testdata/build-finished-logdog-expired-stream.swarm
[modify] https://crrev.com/74366d3656b1a44c3a2daad3fe6bb8356fadc2d2/milo/buildsource/swarming/testdata/build-running-logdog-no-annotation-stream.swarm
[modify] https://crrev.com/74366d3656b1a44c3a2daad3fe6bb8356fadc2d2/milo/buildsource/swarming/testdata/build-running-logdog.swarm
[delete] https://crrev.com/693482d5251b2ef49a3f52177448ac336b15bbb0/swarming/tasktemplate/template.go
[delete] https://crrev.com/693482d5251b2ef49a3f52177448ac336b15bbb0/swarming/tasktemplate/template_test.go

Sign in to add a comment