Omnibox - Clipboard - Log Number of Times Shown / Use |
||||||
Issue descriptionEver time a clipboard suggestion is shown, log to a histogram the number of times this particular URL suggestion has been shown. When a clipboard suggestion is used, log to a histogram the number of times it was previously shown before being used. It might be smart to only show a suggestion the first X times and, if the user ignores it repeatedly, stop offering it even if the clipboard hasn't changed.
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea5016a9460ba717ca21893de068f4d2a3f43746 commit ea5016a9460ba717ca21893de068f4d2a3f43746 Author: mpearson <mpearson@chromium.org> Date: Thu Jun 01 22:20:32 2017 Omnibox - Clipboard Provider - Record Number of Times Suggestion Offered BUG= 718187 Review-Url: https://codereview.chromium.org/2904293002 Cr-Commit-Position: refs/heads/master@{#476453} [modify] https://crrev.com/ea5016a9460ba717ca21893de068f4d2a3f43746/components/omnibox/browser/clipboard_url_provider.cc [modify] https://crrev.com/ea5016a9460ba717ca21893de068f4d2a3f43746/components/omnibox/browser/clipboard_url_provider.h [modify] https://crrev.com/ea5016a9460ba717ca21893de068f4d2a3f43746/tools/metrics/histograms/histograms.xml
,
Jun 1 2017
I will let this sit on canary for a few days, verify the data looks right, then likely request a merge into M-60.
,
Jun 7 2017
Initial data looks plausible, requesting a merge into 60. It would be useful to get the metrics for this earlier rather than later, and the required patch is small.
,
Jun 7 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ef8916519a8a56bafbf6e0641a95b62e2deddea commit 7ef8916519a8a56bafbf6e0641a95b62e2deddea Author: Mark Pearson <mpearson@chromium.org> Date: Wed Jun 07 18:17:22 2017 Omnibox - Clipboard Provider - Record Number of Times Suggestion Offered BUG= 718187 Review-Url: https://codereview.chromium.org/2904293002 Cr-Original-Commit-Position: refs/heads/master@{#476453} Review-Url: https://codereview.chromium.org/2926913002 . Cr-Commit-Position: refs/branch-heads/3112@{#226} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/7ef8916519a8a56bafbf6e0641a95b62e2deddea/components/omnibox/browser/clipboard_url_provider.cc [modify] https://crrev.com/7ef8916519a8a56bafbf6e0641a95b62e2deddea/components/omnibox/browser/clipboard_url_provider.h [modify] https://crrev.com/7ef8916519a8a56bafbf6e0641a95b62e2deddea/tools/metrics/histograms/histograms.xml
,
Jun 7 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mpear...@chromium.org
, May 22 2017