New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718183 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
OOO until 2019-01-24
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocked on:
issue 733089

Blocking:
issue 716670



Sign in to add a comment

Pixel test failures on Haswell GPUs on macOS with 10.12.4

Project Member Reported by kbr@chromium.org, May 3 2017

Issue description

After the upgrade from 10.12.2 to 10.12.4, the following pixel tests are observed to fail on the Mac Minis in the Swarming fleet:

Pixel_OffscreenCanvas2DResizeOnWorker
Pixel_OffscreenCanvasAccelerated2D
Pixel_OffscreenCanvasAccelerated2DWorker
Pixel_WebGLGreenTriangle_NonChromiumImage_NoAA_NoAlpha

This is currently the affected machine:

https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Experimental%20Release%20(Intel)

Example build:

https://luci-milo.appspot.com/buildbot/chromium.gpu.fyi/Mac%20Experimental%20Release%20%28Intel%29/8

Failure images:

http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?692751dc80943ee7094ee1027d9cdc8c8f3d5170_Mac_Experimental_Release_Intel__telemetry

I was able to reproduce the Pixel_WebGLGreenTriangle_NonChromiumImage_NoAA_NoAlpha failure on a MacBook Air with Intel HD 5000 GPU with Chrome Canary by launching the browser with the flag --disable-webgl-image-chromium and navigating to content/test/data/gpu/pixel_webgl_noaa_noalpha.html .

Since this seems to only affect the Haswell family of GPUs, marking these as failures and going to close this as WontFix.

 

Comment 1 by kbr@chromium.org, May 3 2017

Here's the GPU information from this machine:

OS: mac sierra
Model: Macmini
GPU device 0: VENDOR = 0x8086 (Intel), DEVICE = 0xa2e
GPU Attributes:
  amd_switchable      : False
  basic_info_state    : 1
  context_info_state  : 1
  direct_rendering    : True
  driver_date         : 
  driver_vendor       : 
  driver_version      : 10.24.45
  encrypted_only      : False
  gl_extensions       : GL_ARB_blend_func_extended GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_ES2_compatibility GL_ARB_explicit_attrib_location GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader5 GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_occlusion_query2 GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_subroutine GL_ARB_shading_language_include GL_ARB_tessellation_shader GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_vertex_attrib_64bit GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_sRGB_decode GL_APPLE_client_storage GL_APPLE_container_object_shareable GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_texture_range GL_ATI_texture_mirror_once GL_NV_texture_barrier
  gl_renderer         : Intel Iris OpenGL Engine
  gl_reset_notification_strategy: 0
  gl_vendor           : Intel Inc.
  gl_version          : 4.1 INTEL-10.24.45
  gl_ws_extensions    : 
  gl_ws_vendor        : 
  gl_ws_version       : 
  in_process_gpu      : False
  initialization_time : 0.036183
  jpeg_decode_accelerator_supported: False
  max_framerate_denominator: 1
  max_framerate_numerator: 30
  max_msaa_samples    : 8
  max_resolution_height: 2160
  max_resolution_width: 4096
  min_resolution_height: 16
  min_resolution_width: 16
  optimus             : False
  passthrough_cmd_decoder: False
  pixel_shader_version: 4.10
  process_crash_count : 0
  profile             : 0
  sandboxed           : True
  software_rendering  : False
  supports_overlays   : False
  vertex_shader_version: 4.10
  video_decode_accelerator_flags: 0
Feature Status:
  2d_canvas           : enabled
  flash_3d            : enabled
  flash_stage3d       : enabled
  flash_stage3d_baseline: enabled
  gpu_compositing     : enabled
  multiple_raster_threads: enabled_on
  native_gpu_memory_buffers: enabled
  rasterization       : enabled
  video_decode        : enabled
  video_encode        : enabled
  vpx_decode          : enabled
  webgl               : enabled
  webgl2              : enabled
Driver Bug Workarounds:
  add_and_true_to_loop_condition
  adjust_src_dst_region_for_blitframebuffer
  decode_encode_srgb_for_generatemipmap
  disable_framebuffer_cmaa
  disable_multimonitor_multisampling
  disable_webgl_rgb_multisampling_usage
  emulate_abs_int_function
  get_frag_data_info_bug
  init_two_cube_map_levels_before_copyteximage
  msaa_is_slow
  pack_parameters_workaround_with_pack_buffer
  rebind_transform_feedback_before_resume
  regenerate_struct_names
  remove_invariant_and_centroid_for_essl3
  rewrite_texelfetchoffset_to_texelfetch
  scalarize_vec_and_mat_constructor_args
  set_zero_level_before_generating_mipmap
  unfold_short_circuit_as_ternary_operation
  unpack_alignment_workaround_with_unpack_buffer
  unpack_image_height_workaround_with_unpack_buffer
  use_intermediary_for_copy_texture_image
  use_unused_standard_shared_blocks

Comment 2 by kbr@chromium.org, May 3 2017

Blocking: 716670
Project Member

Comment 3 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/543cbcbb37d29652edb36adcb64e1dee09e4efe8

commit 543cbcbb37d29652edb36adcb64e1dee09e4efe8
Author: kbr <kbr@chromium.org>
Date: Wed May 03 23:30:47 2017

Suppress regressions in Haswell graphics driver in macOS 10.12.4.

BUG= 718183 ,  718194 
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2858123002
Cr-Commit-Position: refs/heads/master@{#469200}

[modify] https://crrev.com/543cbcbb37d29652edb36adcb64e1dee09e4efe8/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/543cbcbb37d29652edb36adcb64e1dee09e4efe8/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 4 by kbr@chromium.org, May 3 2017

Status: WontFix (was: Assigned)
Cc: jie.a.c...@intel.com

Comment 6 by junov@chromium.org, Jun 19 2017

Status: Assigned (was: WontFix)
re-opening because there are still suppressions associated with this bug.

The tests are passing on the affected bot:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Experimental%20Release%20(Intel)

Much to my surprise, the suppression are not affecting this bot, so I am not sure what is going on. The bot matches the suppression criteria, I checked.  But for some reason the tests are all expected to pass acctording to the json output:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.gpu.fyi%2FMac_Experimental_Release__Intel_%2F479%2F%2B%2Frecipes%2Fsteps%2Fpixel_test%2F0%2Flogs%2Fjson.output%2F0

Comment 7 by junov@chromium.org, Jun 19 2017

I think we could just remove the suppressions?

Comment 8 by kbr@chromium.org, Jun 19 2017

Blockedon: 733089
Status: Started (was: Assigned)
The suppressions are taking effect. The JSON output, which is generated by typ, doesn't know about these test expectations, which are handled by the test harness.

See for example this output from a recent run of the pixel tests:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.gpu.fyi%2FMac_Experimental_Release__Intel_%2F481%2F%2B%2Frecipes%2Fsteps%2Fpixel_test%2F0%2Fstdout

I double checked and the tests are passing now, but the reason is that the machines have been upgraded to 10.12.5 (as shown in the logs). This upgrade is happening under Issue 733089 and so we can't remove the suppressions until it's been completed for all of them.

Comment 9 by kbr@chromium.org, Jul 6 2017

Now that Issue 733089 has been fixed, removing the unneeded suppressions in https://chromium-review.googlesource.com/560674 .

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4ac9f46202c9659c5b684856e847eaf10317bb9

commit b4ac9f46202c9659c5b684856e847eaf10317bb9
Author: Kenneth Russell <kbr@chromium.org>
Date: Thu Jul 06 04:52:00 2017

Remove suppressions for macOS Intel graphics driver bugs.

These were regressions in 10.12.4, fixed in 10.12.5.

BUG= 718194 ,  718183 
TBR=junov@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I19a0e30b87b7a72fde0a968ba2f91ecb2ec66d2f
Reviewed-on: https://chromium-review.googlesource.com/560674
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484468}
[modify] https://crrev.com/b4ac9f46202c9659c5b684856e847eaf10317bb9/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/b4ac9f46202c9659c5b684856e847eaf10317bb9/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 11 by kbr@chromium.org, Jul 6 2017

Status: WontFix (was: Started)
This was a driver bug, so closing as WontFix.

Sign in to add a comment