New issue
Advanced search Search tips

Issue 718174 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 718159


Participants' hotlists:
LoginRefresh

Show other hotlists

Other hotlists containing this issue:
Hotlist-1
Hotlist-2


Sign in to add a comment

Refresh PIN keyboard UI on sign-in screen

Project Member Reported by jdufault@chromium.org, May 3 2017

Issue description

Refresh PIN keyboard UI on sign-in screen.

It may make sense to fork PIN keyboard assets as well, because the PIN keyboard is also used in settings and oobe.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be738df8f289bf20423865f1bc555f2976a2e921

commit be738df8f289bf20423865f1bc555f2976a2e921
Author: wzang <wzang@chromium.org>
Date: Fri May 12 21:36:22 2017

Fork PIN keyboard assets and create additional flag for lock screen

Fork relevant assets (as follow-up to CL 2855883005) so that the new
design of lock screen can be implemented in tandem with login screen.

The recently added flag (kShowMdLogin) is reserved for views-based login
and lock screen as they are being implemented.

The new flag added by this CL (kShowNonViewMdLogin) is a temporary flag
used until the views-based screens become available.

The two flags should not be used together.

BUG= 718174 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2874303003
Cr-Commit-Position: refs/heads/master@{#471449}

[modify] https://crrev.com/be738df8f289bf20423865f1bc555f2976a2e921/chrome/browser/browser_resources.grd
[modify] https://crrev.com/be738df8f289bf20423865f1bc555f2976a2e921/chrome/browser/chromeos/login/chrome_restart_request.cc
[add] https://crrev.com/be738df8f289bf20423865f1bc555f2976a2e921/chrome/browser/resources/chromeos/login/md_lock.html
[add] https://crrev.com/be738df8f289bf20423865f1bc555f2976a2e921/chrome/browser/resources/chromeos/login/md_lock.js
[add] https://crrev.com/be738df8f289bf20423865f1bc555f2976a2e921/chrome/browser/resources/chromeos/login/md_lock_screens.html
[add] https://crrev.com/be738df8f289bf20423865f1bc555f2976a2e921/chrome/browser/resources/chromeos/quick_unlock/md_pin_keyboard.html
[add] https://crrev.com/be738df8f289bf20423865f1bc555f2976a2e921/chrome/browser/resources/chromeos/quick_unlock/md_pin_keyboard.js
[modify] https://crrev.com/be738df8f289bf20423865f1bc555f2976a2e921/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/be738df8f289bf20423865f1bc555f2976a2e921/chromeos/chromeos_switches.cc
[modify] https://crrev.com/be738df8f289bf20423865f1bc555f2976a2e921/chromeos/chromeos_switches.h

Project Member

Comment 2 by bugdroid1@chromium.org, May 19 2017

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77f0e077eb8829867334297ab10e19561bb07bd9

commit 77f0e077eb8829867334297ab10e19561bb07bd9
Author: wzang <wzang@chromium.org>
Date: Mon Jun 05 18:07:57 2017

Fix misplacement of PIN keyboard and sign-in banner for new login screen

1) Dynamically center the PIN keyboard and remove the !important CSS rule
in the old UI implementation.

2) Postpone the positioning the sign-in banner until after pod placement
because in the new design it depends on the pod positions.

3) Rename two functions which are called before and after pod placement
respectively and refactor some codes.

4) Change the animation duration back to 180ms.
refactor

BUG= 718174 

Review-Url: https://codereview.chromium.org/2921213002
Cr-Commit-Position: refs/heads/master@{#477027}

[modify] https://crrev.com/77f0e077eb8829867334297ab10e19561bb07bd9/ui/login/account_picker/md_screen_account_picker.css
[modify] https://crrev.com/77f0e077eb8829867334297ab10e19561bb07bd9/ui/login/account_picker/md_user_pod_row.css
[modify] https://crrev.com/77f0e077eb8829867334297ab10e19561bb07bd9/ui/login/account_picker/md_user_pod_row.js

Components: UI>Shell>StartScreen

Comment 5 by wzang@chromium.org, Oct 6 2017

Status: Fixed (was: Assigned)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 7 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment