Cast Streaming should always send the sender report |
||||
Issue descriptionAt some point, code was changed to disable sending the RTCP sender report if Cast Streaming was being used for Media Remoting. We should re-enable this, to allow the receiver watchdog to detect a connection failure. Also, we should undo any other "early optimizations" to keep things simple for both the sender and receiver impl, unless there are things we know would significantly regress performance.
,
May 4 2017
The sender report was stopped sending per the previous discussion with zhengxiong@ as the lip-sync info in the report is not needed any more by the receiver in media remoting mode. Now if re-enable it for remoting, does receiver need the exact lip-sync info as in mirroring, or just a periodical RTCP packet with some time stamp?
,
May 4 2017
The receiver does not use the sender report during remoting. In order to prevent keepalive timeouts during media pause, the sender should periodically transfer a valid RTCP packet, which could be the sender report.
,
May 4 2017
Sounds good. Will do.
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f727a7e734fbbf7f018cda55a97bb751d8bcdac commit 0f727a7e734fbbf7f018cda55a97bb751d8bcdac Author: xjz <xjz@chromium.org> Date: Mon May 08 21:31:57 2017 Periodically send RTCP report during Media Remoting. To prevent keepalive timeouts on receiver side during media pause. BUG= 718167 Review-Url: https://codereview.chromium.org/2861053002 Cr-Commit-Position: refs/heads/master@{#470137} [modify] https://crrev.com/0f727a7e734fbbf7f018cda55a97bb751d8bcdac/chrome/browser/media/cast_remoting_sender.cc [modify] https://crrev.com/0f727a7e734fbbf7f018cda55a97bb751d8bcdac/chrome/browser/media/cast_remoting_sender.h
,
May 8 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by zhengxiong@chromium.org
, May 3 2017