Remove GYP_DEFINES when building Chrome |
||||||||||||
Issue descriptionFor example, https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.lkgr%2FUBSan_vptr_Release%2F7117%2F%2B%2Frecipes%2Fsteps%2Fgclient_runhooks%2F0%2Fstdout still have GYP_DEFINES. I have been told GYP_DEFINES is not needed. We have a command-line tool that copies what buildbot does, and if buildbot removes GYP_DEFINES, it'll simplify our code tremendously. I wonder if we can remove them. Thank you.
,
May 4 2017
Until bug 570091 is fixed, GYP_DEFINES are still needed during the `gclient runhooks` step to conditionally control whether some hooks do work or not.
,
Jun 22 2017
,
Jul 18 2017
,
Aug 18 2017
I'm going to remove the "on buildbot" part of this, since we want to remove all uses of GYP_DEFINES, period :).
I'll use this bug to file sub-bugs for the individual uses I can find.
Using the following command run from the directory above src/:
$ grep GYP_DEFINES $(cd src && grep "\.py" DEPS buildtools/DEPS | sort | uniq | sed -e "s/^DEPS://" -e "s/'action': \['python', //" -e "s/,.*$//" -e "/#/d" -e "s/\]$//" -e "s/'//g" | awk '{print $1}')
src/build/download_nacl_toolchains.py
src/third_party/binutils/download.py
src/build/linux/sysroot_scripts/install-sysroot.py
src/build/vs_toolchain.py
src/third_party/instrumented_libraries/scripts/download_binaries.py
src/tools/clang/scripts/update.py
So we can start with at least those.
In addition, I'll file another bug to remove other uses of the environment (as a flag, at least) when running as a hook.
,
Aug 18 2017
,
Aug 18 2017
,
Aug 18 2017
Paweł, I've filed bug 756686 for NaCl and bug 756688 for clang and assigned them to you; the first one should be straightforward and the second somewhat more complicated. Once we've got those two working, we should be able to get other people to help convert the remaining flags over and we can figure out who should then own this bug to make sure that everything is completed.
,
Nov 2 2017
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1d528fc0a6602a03e9c7a2f0a8f0422cd8bad9c commit c1d528fc0a6602a03e9c7a2f0a8f0422cd8bad9c Author: Dirk Pranke <dpranke@chromium.org> Date: Fri Nov 03 15:15:03 2017 Check out telemetry dependencies properly using a gclient condition. This adds a 'checkout_telemetry_dependencies' flag, so that we can stop relying on the GYP_DEFINE. This defaults to off for now because the dependencies contain some internal things; eventually we should split them into public and private dependencies. R=martiniss@chromium.org, nednguyen@google.com, iannucci@chromium.org BUG= 780967 , 718157 Change-Id: I1c2681af21a547b21e772b2ec729a7af17045f3d Reviewed-on: https://chromium-review.googlesource.com/752044 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#513777} [modify] https://crrev.com/c1d528fc0a6602a03e9c7a2f0a8f0422cd8bad9c/DEPS
,
Dec 1 2017
Removing myself from bugs because of team transfer, back to re-triage. See https://goto.google.com/phajdan-goodbye-chrome (Google-internal) and issue 783662 . In case of any questions, feel free to ask - use phajdan@google.com for a faster response.
,
Dec 19 2017
,
Dec 19 2017
,
Feb 15 2018
,
Aug 30
,
Oct 31
I'm doing a bit of work on this.
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b16601dcfc66c1479bd9e287bd5bcd7b38d5b99d commit b16601dcfc66c1479bd9e287bd5bcd7b38d5b99d Author: Stephen Martinis <martiniss@chromium.org> Date: Wed Oct 31 16:59:42 2018 Remove GYP_DEFINE reference from binutils/download.py It appears that this isn't being set anywhere in recipes, so this should maybe be safe to remove? Bug: 718157 Change-Id: Iec1934638ec6f1acaf5b1b96c1e8fdb129457c39 Reviewed-on: https://chromium-review.googlesource.com/c/1308912 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#604301} [modify] https://crrev.com/b16601dcfc66c1479bd9e287bd5bcd7b38d5b99d/third_party/binutils/README.chromium [modify] https://crrev.com/b16601dcfc66c1479bd9e287bd5bcd7b38d5b99d/third_party/binutils/download.py
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71b391b5759845dd41fe3ed19c9bc6b7c166e9b4 commit 71b391b5759845dd41fe3ed19c9bc6b7c166e9b4 Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Dec 04 15:08:04 2018 Remove GYP_DEFINES reference from cygprofile Removes the references to GYP_DEFINES in //tools/cygprofile. Default to just 'arm' for the architecture. The scripts in here allow for this to be customized. Bug: 873373, 718157 Change-Id: Ic3dd78e47b7ceebd7d1228d2432c7b41c16556e6 Reviewed-on: https://chromium-review.googlesource.com/c/1359136 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#613552} [modify] https://crrev.com/71b391b5759845dd41fe3ed19c9bc6b7c166e9b4/tools/cygprofile/check_orderfile.py [modify] https://crrev.com/71b391b5759845dd41fe3ed19c9bc6b7c166e9b4/tools/cygprofile/cyglog_to_orderfile.py [modify] https://crrev.com/71b391b5759845dd41fe3ed19c9bc6b7c166e9b4/tools/cygprofile/cygprofile_utils.py [modify] https://crrev.com/71b391b5759845dd41fe3ed19c9bc6b7c166e9b4/tools/cygprofile/orderfile_generator_backend.py [modify] https://crrev.com/71b391b5759845dd41fe3ed19c9bc6b7c166e9b4/tools/cygprofile/patch_orderfile.py
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71b391b5759845dd41fe3ed19c9bc6b7c166e9b4 commit 71b391b5759845dd41fe3ed19c9bc6b7c166e9b4 Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Dec 04 15:08:04 2018 Remove GYP_DEFINES reference from cygprofile Removes the references to GYP_DEFINES in //tools/cygprofile. Default to just 'arm' for the architecture. The scripts in here allow for this to be customized. Bug: 873373, 718157 Change-Id: Ic3dd78e47b7ceebd7d1228d2432c7b41c16556e6 Reviewed-on: https://chromium-review.googlesource.com/c/1359136 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#613552} [modify] https://crrev.com/71b391b5759845dd41fe3ed19c9bc6b7c166e9b4/tools/cygprofile/check_orderfile.py [modify] https://crrev.com/71b391b5759845dd41fe3ed19c9bc6b7c166e9b4/tools/cygprofile/cyglog_to_orderfile.py [modify] https://crrev.com/71b391b5759845dd41fe3ed19c9bc6b7c166e9b4/tools/cygprofile/cygprofile_utils.py [modify] https://crrev.com/71b391b5759845dd41fe3ed19c9bc6b7c166e9b4/tools/cygprofile/orderfile_generator_backend.py [modify] https://crrev.com/71b391b5759845dd41fe3ed19c9bc6b7c166e9b4/tools/cygprofile/patch_orderfile.py
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f15fff781a560f28d82e8521fbfacecb4af1a567 commit f15fff781a560f28d82e8521fbfacecb4af1a567 Author: Stephen Martinis <martiniss@chromium.org> Date: Wed Dec 05 01:41:47 2018 Remove GYP_DEFINES reference in breakpad dump reader This used to be used to detect cdb on windows. I don't think this value is set in GYP_DEFINES anywhere, and GYP_DEFINES is deprecated anyways, so just remove that. Bug: 718157 Change-Id: I7041adcfc18b719e951d4135548e8e944b674f2b Reviewed-on: https://chromium-review.googlesource.com/c/1361804 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#613801} [modify] https://crrev.com/f15fff781a560f28d82e8521fbfacecb4af1a567/third_party/blink/tools/blinkpy/web_tests/breakpad/dump_reader_win.py
,
Dec 8
Update! Most references have been removed. The following remain: * https://cs.chromium.org/chromium/src/build/download_nacl_toolchains.py?l=47&rcl=303292c37af00787ae2d204a10bf8a9dec1027ca I think we need to replicate this functionality, as we are still setting target_arch to something. I think we should just pass the data in a different way, maybe set an environment variable name CHROME_TARGET_ARCH or GN_TARGET_ARCH or something. Don't think it can look at gn args to discover this. * https://cs.chromium.org/chromium/src/v8/third_party/binutils/download.py?l=41&rcl=915144a5b35f665a1ffc2a71d5d588074645c35e This was already fixed in chromium source, but I think the script was manually copied to v8 before the fix. Just need to land the same CL there. * A few scripts which seem to reference this, like https://cs.chromium.org/chromium/src/third_party/boringssl/src/util/bot/vs_toolchain.py?l=56&rcl=0f5ecd3a854546d943104e1f7421e489b7f4d5aa. I don't believe this is running anymore, so should be safe to delete. * https://cs.chromium.org/chromium/src/third_party/blink/tools/blinkpy/web_tests/port/base.py?l=1131&rcl=a54d576cb356b3e7e8d07e503800d07fb6dec20b. I removed this actually being used in #20, but forgot to remove this. Full list of references is in https://cs.chromium.org/search/?q=GYP_DEFINES+-file:%5C.json&sq=package:chromium&type=cs. There are more than the above that exist, but most of them don't seem to affect functionality, and they can be cleaned up in separate stages, as they mostly are documentation.
,
Dec 11
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/f4f8cc56aacf075306bbb6ee0da845e4f3ae32e3 commit f4f8cc56aacf075306bbb6ee0da845e4f3ae32e3 Author: Lei Zhang <thestig@chromium.org> Date: Tue Dec 11 01:37:45 2018 Roll third_party/binutils/ 4110e0919..2be73f7fb (1 commit) https://chromium.googlesource.com/chromium/src/third_party/binutils.git/+log/4110e0919711..2be73f7fbf78 $ git log 4110e0919..2be73f7fb --date=short --no-merges --format='%ad %ae %s' 2018-10-31 martiniss Remove GYP_DEFINE reference from binutils/download.py Created with: roll-dep third_party/binutils TBR=tsepez@chromium.org BUG=chromium:718157 Change-Id: I3553bef1a94ea726f0d152f6008e416f487a8581 Reviewed-on: https://pdfium-review.googlesource.com/c/46992 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> [modify] https://crrev.com/f4f8cc56aacf075306bbb6ee0da845e4f3ae32e3/DEPS
,
Dec 11
I took another look at the usages. I think we only have to fix the download_nacl_toolchains.py script. The reference in boringssl seems to be outside the purvey of this bug. It appears boringssl still supports gyp, and that code isn't used to build Chrome as far as I can tell. There are a few other references in //native_client_sdk, but those also seem to be related to running their builds on buildbot, which isn't related to the main way of building chrome. I'll work on a solution to download_nacl_toolchains.py.
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1995d2c7d234af7b464bd423f340b8f1ef467581 commit 1995d2c7d234af7b464bd423f340b8f1ef467581 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 02:49:40 2018 Roll src/third_party/pdfium 1ccf890a09a3..f4f8cc56aacf (1 commits) https://pdfium.googlesource.com/pdfium.git/+log/1ccf890a09a3..f4f8cc56aacf git log 1ccf890a09a3..f4f8cc56aacf --date=short --no-merges --format='%ad %ae %s' 2018-12-11 thestig@chromium.org Roll third_party/binutils/ 4110e0919..2be73f7fb (1 commit) Created with: gclient setdep -r src/third_party/pdfium@f4f8cc56aacf The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:718157 TBR=dsinclair@chromium.org Change-Id: I8d4b53f64fabc8647349c3766852e89947b22ad1 Reviewed-on: https://chromium-review.googlesource.com/c/1371193 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615401} [modify] https://crrev.com/1995d2c7d234af7b464bd423f340b8f1ef467581/DEPS
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/f12466441c61c122cbf8b3ccffd82ca74b641035 commit f12466441c61c122cbf8b3ccffd82ca74b641035 Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Dec 11 07:34:58 2018 Remove GYP_DEFINES reference This was deleted source side in https://crrev.com/c/1308912 with seemingly no ill effects. Bug: chromium:718157 Change-Id: Ic2516b391b76a8fb72df97f6f090af3c24f35766 Reviewed-on: https://chromium-review.googlesource.com/c/1371035 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58141} [modify] https://crrev.com/f12466441c61c122cbf8b3ccffd82ca74b641035/third_party/binutils/download.py
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed965e659fb7e10656a80dc52ed438c0cf4c47af commit ed965e659fb7e10656a80dc52ed438c0cf4c47af Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Dec 11 22:24:29 2018 Remove reference to GYP_DEFINES This was removed in https://crrev.com/c/1361804. I missed this reference though. Bug: 718157 Change-Id: Idbddfec89d5c143c494df1f5572cb82f631baf62 Reviewed-on: https://chromium-review.googlesource.com/c/1371192 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#615691} [modify] https://crrev.com/ed965e659fb7e10656a80dc52ed438c0cf4c47af/third_party/blink/tools/blinkpy/web_tests/port/base.py
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/98bbb636b12a6ef6c2015e99f4b70e84924d4556 commit 98bbb636b12a6ef6c2015e99f4b70e84924d4556 Author: Michael Achenbach <machenbach@chromium.org> Date: Wed Dec 12 09:46:01 2018 [build] Pull binutils via DEPS This pulls binutils from a subtreed repository of Chromium: https://chromium.googlesource.com/chromium/src/third_party/binutils/ Bug: chromium:718157 Change-Id: I532c7e84d83f716728e4f9f715cfdb82ea5d5f98 Reviewed-on: https://chromium-review.googlesource.com/c/1370043 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58180} [modify] https://crrev.com/98bbb636b12a6ef6c2015e99f4b70e84924d4556/.gitignore [modify] https://crrev.com/98bbb636b12a6ef6c2015e99f4b70e84924d4556/DEPS [delete] https://crrev.com/0d7cc2ccdd60790b19cdd6cc91adad9ae01e169d/third_party/binutils/.gitignore [delete] https://crrev.com/0d7cc2ccdd60790b19cdd6cc91adad9ae01e169d/third_party/binutils/Linux_ia32/binutils.tar.bz2.sha1 [delete] https://crrev.com/0d7cc2ccdd60790b19cdd6cc91adad9ae01e169d/third_party/binutils/Linux_x64/binutils.tar.bz2.sha1 [delete] https://crrev.com/0d7cc2ccdd60790b19cdd6cc91adad9ae01e169d/third_party/binutils/detect_v8_host_arch.py [delete] https://crrev.com/0d7cc2ccdd60790b19cdd6cc91adad9ae01e169d/third_party/binutils/download.py
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/b33fcd7e8351e69feb8fd9e76507c74e1c57c5d6 commit b33fcd7e8351e69feb8fd9e76507c74e1c57c5d6 Author: Michael Achenbach <machenbach@chromium.org> Date: Wed Dec 12 14:05:12 2018 Revert "[build] Pull binutils via DEPS" This reverts commit 98bbb636b12a6ef6c2015e99f4b70e84924d4556. Reason for revert: https://crbug.com/v8/8584 Original change's description: > [build] Pull binutils via DEPS > > This pulls binutils from a subtreed repository of Chromium: > https://chromium.googlesource.com/chromium/src/third_party/binutils/ > > Bug: chromium:718157 > Change-Id: I532c7e84d83f716728e4f9f715cfdb82ea5d5f98 > Reviewed-on: https://chromium-review.googlesource.com/c/1370043 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58180} TBR=machenbach@chromium.org,yangguo@chromium.org,sergiyb@chromium.org Change-Id: I43126c54846b14de10a0cd6bdc0b9d6e2e64999c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:718157 Reviewed-on: https://chromium-review.googlesource.com/c/1373780 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58187} [modify] https://crrev.com/b33fcd7e8351e69feb8fd9e76507c74e1c57c5d6/.gitignore [modify] https://crrev.com/b33fcd7e8351e69feb8fd9e76507c74e1c57c5d6/DEPS [add] https://crrev.com/b33fcd7e8351e69feb8fd9e76507c74e1c57c5d6/third_party/binutils/.gitignore [add] https://crrev.com/b33fcd7e8351e69feb8fd9e76507c74e1c57c5d6/third_party/binutils/Linux_ia32/binutils.tar.bz2.sha1 [add] https://crrev.com/b33fcd7e8351e69feb8fd9e76507c74e1c57c5d6/third_party/binutils/Linux_x64/binutils.tar.bz2.sha1 [add] https://crrev.com/b33fcd7e8351e69feb8fd9e76507c74e1c57c5d6/third_party/binutils/detect_v8_host_arch.py [add] https://crrev.com/b33fcd7e8351e69feb8fd9e76507c74e1c57c5d6/third_party/binutils/download.py
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/09c49ee064392bec6ffb562f8e9ad4ce7338e526 commit 09c49ee064392bec6ffb562f8e9ad4ce7338e526 Author: Michael Achenbach <machenbach@chromium.org> Date: Thu Dec 13 11:34:18 2018 Reland "[build] Pull binutils via DEPS" This is a reland of 98bbb636b12a6ef6c2015e99f4b70e84924d4556 Original change's description: > [build] Pull binutils via DEPS > > This pulls binutils from a subtreed repository of Chromium: > https://chromium.googlesource.com/chromium/src/third_party/binutils/ > > Bug: chromium:718157 > Change-Id: I532c7e84d83f716728e4f9f715cfdb82ea5d5f98 > Reviewed-on: https://chromium-review.googlesource.com/c/1370043 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58180} Bug: chromium:718157, v8:8584 Change-Id: I1c9773bc5fa0a629e35db5151e535e63839f2801 Reviewed-on: https://chromium-review.googlesource.com/c/1375655 Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58213} [modify] https://crrev.com/09c49ee064392bec6ffb562f8e9ad4ce7338e526/.gitignore [modify] https://crrev.com/09c49ee064392bec6ffb562f8e9ad4ce7338e526/DEPS [delete] https://crrev.com/e61d3564e7f2ca5f7bd5cc18daaae5d3969d5875/third_party/binutils/.gitignore [delete] https://crrev.com/e61d3564e7f2ca5f7bd5cc18daaae5d3969d5875/third_party/binutils/Linux_ia32/binutils.tar.bz2.sha1 [delete] https://crrev.com/e61d3564e7f2ca5f7bd5cc18daaae5d3969d5875/third_party/binutils/Linux_x64/binutils.tar.bz2.sha1 [delete] https://crrev.com/e61d3564e7f2ca5f7bd5cc18daaae5d3969d5875/third_party/binutils/detect_v8_host_arch.py [delete] https://crrev.com/e61d3564e7f2ca5f7bd5cc18daaae5d3969d5875/third_party/binutils/download.py
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/50b72266ff5c0c4f7944e5a60209582f6cfa9530 commit 50b72266ff5c0c4f7944e5a60209582f6cfa9530 Author: Michael Achenbach <machenbach@chromium.org> Date: Thu Dec 13 12:05:58 2018 Revert "Reland "[build] Pull binutils via DEPS"" This reverts commit 09c49ee064392bec6ffb562f8e9ad4ce7338e526. Reason for revert: Still breaks the node.js bot. Original change's description: > Reland "[build] Pull binutils via DEPS" > > This is a reland of 98bbb636b12a6ef6c2015e99f4b70e84924d4556 > > Original change's description: > > [build] Pull binutils via DEPS > > > > This pulls binutils from a subtreed repository of Chromium: > > https://chromium.googlesource.com/chromium/src/third_party/binutils/ > > > > Bug: chromium:718157 > > Change-Id: I532c7e84d83f716728e4f9f715cfdb82ea5d5f98 > > Reviewed-on: https://chromium-review.googlesource.com/c/1370043 > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#58180} > > Bug: chromium:718157, v8:8584 > Change-Id: I1c9773bc5fa0a629e35db5151e535e63839f2801 > Reviewed-on: https://chromium-review.googlesource.com/c/1375655 > Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58213} TBR=machenbach@chromium.org,yangguo@chromium.org,sergiyb@chromium.org Change-Id: I1935f4aef0d6eb4f58e25197d14ccf2c2c645b15 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:718157, v8:8584 Reviewed-on: https://chromium-review.googlesource.com/c/1375659 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58214} [modify] https://crrev.com/50b72266ff5c0c4f7944e5a60209582f6cfa9530/.gitignore [modify] https://crrev.com/50b72266ff5c0c4f7944e5a60209582f6cfa9530/DEPS [add] https://crrev.com/50b72266ff5c0c4f7944e5a60209582f6cfa9530/third_party/binutils/.gitignore [add] https://crrev.com/50b72266ff5c0c4f7944e5a60209582f6cfa9530/third_party/binutils/Linux_ia32/binutils.tar.bz2.sha1 [add] https://crrev.com/50b72266ff5c0c4f7944e5a60209582f6cfa9530/third_party/binutils/Linux_x64/binutils.tar.bz2.sha1 [add] https://crrev.com/50b72266ff5c0c4f7944e5a60209582f6cfa9530/third_party/binutils/detect_v8_host_arch.py [add] https://crrev.com/50b72266ff5c0c4f7944e5a60209582f6cfa9530/third_party/binutils/download.py |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by ta...@google.com
, May 3 2017