New issue
Advanced search Search tips

Issue 718156 link

Starred by 4 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 733709
issue 737255

Blocking:
issue 718159


Participants' hotlists:
LoginRefresh

Show other hotlists

Other hotlists containing this issue:
Hotlist-1
Hotlist-2


Sign in to add a comment

Darken login background

Project Member Reported by jdufault@chromium.org, May 3 2017

Issue description

The wallpaper behind login needs to be darkened. We already do this inside of OOBE, but login may need a separate implementation because we don't pull in all of OOBE.

Consider using ash::ScreenDimmer, or applying a style to the body element so it applies to the entire document.

When we have native shelf the login WebView may shrink so it is no longer full-screen. If this happens, dimming via the <body> element will not work for the shelf (ie, we will have to use ash::ScreenDimmer). It's unlikely we will go down this approach though.
 
Blocking: -718151 718159
Labels: -Hotlist-LoginRefresh
Project Member

Comment 3 by bugdroid1@chromium.org, May 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a80f688d6757bd90c05fa0ecd7cec210624e89ae

commit a80f688d6757bd90c05fa0ecd7cec210624e89ae
Author: wzang <wzang@chromium.org>
Date: Sat May 13 00:15:18 2017

Login screen redesign (CL 1)

The goal is to make the single user login screen look the same with the new
design, without worrying much about the extensibility / reusability.

Please refer to
https://docs.google.com/a/google.com/document/d/1gILlP9VyBvfikcFZifkxZT4dEdZ1nLFV__X6RHT9ZNg/edit?usp=sharing
for more details.

All browser tests passed.

BUG= 718158 ,  718156 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2875513002
Cr-Commit-Position: refs/heads/master@{#471504}

[modify] https://crrev.com/a80f688d6757bd90c05fa0ecd7cec210624e89ae/chrome/browser/resources/chromeos/login/md_header_bar.css
[modify] https://crrev.com/a80f688d6757bd90c05fa0ecd7cec210624e89ae/chrome/browser/resources/chromeos/login/md_screen_container.html
[modify] https://crrev.com/a80f688d6757bd90c05fa0ecd7cec210624e89ae/ui/login/account_picker/md_screen_account_picker.js
[modify] https://crrev.com/a80f688d6757bd90c05fa0ecd7cec210624e89ae/ui/login/account_picker/md_user_pod_row.css
[modify] https://crrev.com/a80f688d6757bd90c05fa0ecd7cec210624e89ae/ui/login/account_picker/md_user_pod_row.js
[modify] https://crrev.com/a80f688d6757bd90c05fa0ecd7cec210624e89ae/ui/login/account_picker/md_user_pod_template.css
[modify] https://crrev.com/a80f688d6757bd90c05fa0ecd7cec210624e89ae/ui/login/account_picker/md_user_pod_template.html
[modify] https://crrev.com/a80f688d6757bd90c05fa0ecd7cec210624e89ae/ui/login/md_screen_container.css

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fb48db2c5ca7f6525489cea5c2d30cdc52c1edf

commit 7fb48db2c5ca7f6525489cea5c2d30cdc52c1edf
Author: wzang <wzang@chromium.org>
Date: Fri Jun 02 00:29:57 2017

Fix two container issues for new login screen

1) We need the outer-container to be scrollable when gaia screen and
virtual keyboard are shown together, so the dark overlay ('login-shield')
should always have the same size with the larger one of
the outer-container and the scroll-container, otherwise we see areas
without overlay when scrolling up.

2) We should remember to clear contents on the small pods container
before rebuilding pods.

BUG= 718156 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2916973002
Cr-Commit-Position: refs/heads/master@{#476497}

[modify] https://crrev.com/7fb48db2c5ca7f6525489cea5c2d30cdc52c1edf/chrome/browser/resources/chromeos/login/md_login_shared.js
[modify] https://crrev.com/7fb48db2c5ca7f6525489cea5c2d30cdc52c1edf/ui/login/account_picker/md_user_pod_row.js

Comment 5 by wzang@chromium.org, Jun 15 2017

Blockedon: 733709

Comment 6 by wzang@chromium.org, Jul 17 2017

Blockedon: 737255

Comment 7 by wutao@chromium.org, Jul 17 2017

In the blur mode, do you only show the wallpaper layer?
we might have a fast path for wallpaper blur, I want to make sure you have a the same use case as here:  bug 738185 

Comment 8 by wutao@chromium.org, Jul 17 2017

Cc: wutao@chromium.org

Comment 9 by wzang@chromium.org, Jul 17 2017

I think it's the same use case. It's the same with this: https://cs.chromium.org/chromium/src/ash/login/ui/lock_screen.cc?q=setbackgroundblur&dr=C&l=83

Comment 10 by wutao@chromium.org, Jul 17 2017

I guess before login, there is no any apps so you always see the wallpaper?

Comment 11 by wzang@chromium.org, Jul 17 2017

I think tbarzic@ is working on lock screen apps that will hide the wallpaper on lock screen. 

Comment 12 by r...@chromium.org, Jul 18 2017

Cc: tbarzic@chromium.org

Comment 13 by wutao@chromium.org, Jul 25 2017

wzang@, could you try the ToT code to turn on blur on the login page.
Thanks.

Comment 14 by wutao@chromium.org, Jul 26 2017

Please use this function to set blur for login/lock screen:
SetLayerBlur()
https://cs.chromium.org/chromium/src/ui/compositor/layer.cc?l=407&rcl=754953a479eab9a4255852ec1e29c65e7bdc14a2

Comment 15 by wzang@chromium.org, Jul 26 2017

I'm working on it. Thanks!

Comment 16 by wzang@chromium.org, Aug 16 2017

Status: Fixed (was: Assigned)

Comment 17 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment