New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718143 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

[Windows][Host] Whitescreen displayed when connecting via curtain mode w/o resize option set

Project Member Reported by joedow@chromium.org, May 3 2017

Issue description

I've reproduced this problem on my Win10 host.

If I connect to it with 'resize to fit' unchecked, then I just see a white screen on the client.  As soon as I check the resize box, I see video immediately.  Also, this problem does not reproduce if curtain mode is not enabled.


We have received reports of this issue in the past (based on the invalid resolution being reported) but no repro steps.

Here is an excerpt from the console log (resize not set, host in curtain mode), note the 0x0 resolution:
client_plugin_impl.js:246 plugin: setCapabilities: [rateLimitResizeRequests securityKey sendInitialResolution touchEvents]
client_session.js:629 Connection established.
ui_mode.js:123 App mode: in-session
clipboard.js:87 Got clipboard from OS, type: text/plain length: 43 new: true blocking-send: true
clipboard.js:87 Got clipboard from OS, type: text/plain length: 43 new: false blocking-send: false
desktop_viewport.js:286 desktop size changed: 0x0 @ 96x96 DPI
client_session.js:530 Video channel ready.


Here is a trace with 'resize' set and host in curtain mode:
client_plugin_impl.js:246 plugin: setCapabilities: [rateLimitResizeRequests securityKey sendInitialResolution touchEvents]
client_session.js:629 Connection established.
ui_mode.js:123 App mode: in-session
clipboard.js:87 Got clipboard from OS, type: text/plain length: 2451 new: true blocking-send: true
clipboard.js:87 Got clipboard from OS, type: text/plain length: 2451 new: false blocking-send: false
client_session.js:530 Video channel ready.
desktop_viewport.js:286 desktop size changed: 1244x1090 @ 96x96 DPI
desktop_viewport.js:353 plugin dimensions:1244x1090

Here is a trace with 'resize' disabled and the host in non-curtain mode:
client_plugin_impl.js:246 plugin: setCapabilities: [rateLimitResizeRequests securityKey touchEvents]
client_session.js:629 Connection established.
ui_mode.js:123 App mode: in-session
clipboard.js:87 Got clipboard from OS, type: text/plain length: 1143 new: true blocking-send: true
clipboard.js:87 Got clipboard from OS, type: text/plain length: 1143 new: false blocking-send: false
desktop_viewport.js:286 desktop size changed: 0x0 @ 96x96 DPI
client_session.js:530 Video channel ready.
desktop_viewport.js:286 desktop size changed: 2560x1600 @ 96x96 DPI


It seems related to sending 'sendInitialResolution' and whether the host waits for that or not.
 
Labels: M-60
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 5 2017

Labels: Merge-Request-59
This change only affects the Chrome Remote Desktop webapp client, requesting a merge into M59.
Project Member

Comment 5 by sheriffbot@chromium.org, May 6 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, May 6 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b28aa836f3063bfa8effa2027a376f938c8edc1

commit 4b28aa836f3063bfa8effa2027a376f938c8edc1
Author: Joe Downing <joedow@chromium.org>
Date: Sat May 06 23:16:00 2017

Fixing white-screen problem for Curtain-mode Windows host connections

BUG= 718143 

Review-Url: https://codereview.chromium.org/2860203003
Cr-Commit-Position: refs/heads/master@{#469777}
(cherry picked from commit 699aaa5fdd0d66259d48d32cbe586ab841076eb6)

Review-Url: https://codereview.chromium.org/2861333002 .
Cr-Commit-Position: refs/branch-heads/3071@{#435}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/4b28aa836f3063bfa8effa2027a376f938c8edc1/remoting/webapp/crd/js/desktop_connected_view.js
[modify] https://crrev.com/4b28aa836f3063bfa8effa2027a376f938c8edc1/remoting/webapp/crd/js/desktop_viewport.js

Labels: -M-60 M-59
Owner: ajnolley@chromium.org
Status: Fixed (was: Assigned)
Fixed in M60 and merged back to M59
Status: Verified (was: Fixed)
Verified Fixed in web app version 59.0.3071.47

Sign in to add a comment