New issue
Advanced search Search tips

Issue 718136 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Stop doing slow synchronous work in ChromeActivity onResume

Project Member Reported by mthiesse@chromium.org, May 3 2017

Issue description

Currently the work done in onResume takes ~16-25ms on a daydream-ready device, and ~8-9ms on a cardboard device. We need to get this down to ~0.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d3151bb4c3bf0346ceec9c4b43f895607fe8d2c

commit 2d3151bb4c3bf0346ceec9c4b43f895607fe8d2c
Author: mthiesse <mthiesse@chromium.org>
Date: Wed May 03 21:46:04 2017

VR: Make work done during onResume in VrShellDelegate asynchronous.

Makes registerDaydreamIntent run after onResume. Makes static checking of VR support level in onResume an async task.

Note that doing this work asynchronously is racy. In practice this shouldn't be an issue because the user would have to put their phone into their daydream headset within a few milliseconds of launching chrome. The failure mode is also not terrible, the user would return to Daydream home instead of Chrome.

BUG= 718136 

Review-Url: https://codereview.chromium.org/2859893002
Cr-Commit-Position: refs/heads/master@{#469141}

[modify] https://crrev.com/2d3151bb4c3bf0346ceec9c4b43f895607fe8d2c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Going to let this bake a bit on ToT, but this is worth merging back to M-59.
Labels: Merge-Request-59
Project Member

Comment 4 by sheriffbot@chromium.org, May 5 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, May 5 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aab1355ed623db4c9af5a6ec04693e170db9bb3d

commit aab1355ed623db4c9af5a6ec04693e170db9bb3d
Author: Michael Thiessen <mthiesse@google.com>
Date: Fri May 05 14:33:29 2017

VR: Make work done during onResume in VrShellDelegate asynchronous.

Makes registerDaydreamIntent run after onResume. Makes static checking of VR support level in onResume an async task.

Note that doing this work asynchronously is racy. In practice this shouldn't be an issue because the user would have to put their phone into their daydream headset within a few milliseconds of launching chrome. The failure mode is also not terrible, the user would return to Daydream home instead of Chrome.

BUG= 718136 

Review-Url: https://codereview.chromium.org/2859893002
Cr-Commit-Position: refs/heads/master@{#469141}
(cherry picked from commit 2d3151bb4c3bf0346ceec9c4b43f895607fe8d2c)

Review-Url: https://codereview.chromium.org/2855123008 .
Cr-Commit-Position: refs/branch-heads/3071@{#415}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/aab1355ed623db4c9af5a6ec04693e170db9bb3d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Owner: vsupruniuk@google.com
Status: Fixed (was: Started)
vsupruniuk, can we please get some manual testing on this change in the next M59 build?

This change would have affected things like returning to chrome on headset insertion, though do note that we're forced to make this racy, so if you put your phone in the headset immediately as chrome is launching it's expected that might would return to daydream home instead of chrome.
Verified in Chrome Beta 59.0.3071.39. There are no new issues found, presentation mode is successfully started after DON flow is completed. 
Also I was able to reproduce behavior when device is inserted immediately after Chrome is started and transferred to DD Home instead of Chrome. 
Status: Verified (was: Fixed)

Sign in to add a comment