New issue
Advanced search Search tips

Issue 718127 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Add ability to collapse top-level sections

Project Member Reported by aga...@chromium.org, May 3 2017

Issue description

The four subsections in the "Trooper Queue" section can each be collapsed, which is nice. But it would also be nice to be able to collapse that section entirely, or collapse the Swarming, or Android Infra Failures, sections.
 
Labels: Milestone-UX
Owner: zhangtiff@chromium.org
Status: Assigned (was: Untriaged)
Thanks for the bug report! I had thought that perhaps adding collapse all/expand all to all the sections would potentially help with this. It's really useful for me to know that collapsing the whole sections is still a desirable feature. 

I will have to think a bit on how to best add a toggle collapse feature to the whole section that isn't confusing when we already have collapse/expand all. 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b52adb9090fafd482cc1570f321fdddcf2dc9ad2

commit b52adb9090fafd482cc1570f321fdddcf2dc9ad2
Author: Tiff Zhang <zhangtiff@google.com>
Date: Fri Jun 09 22:43:37 2017

SoM: Make infra failures/other alert sections collapsible and refactored alert categories into a separate element.

Bug:730315
Bug:718127
Bug:717717
Change-Id: I51bb83fa49bdf0c47a8db017cd8cc112b035ee64
Reviewed-on: https://chromium-review.googlesource.com/529966
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-app/som-app.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.html
[add] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-category/som-alert-category.js
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotation-manager-behavior.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-app/som-app.js
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-build-failure/som-extension-build-failure.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.js
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-settings/som-settings.html
[add] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-category/som-alert-category.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.js
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.js
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-alert-item-test.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.html
[add] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-utility-styles.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-alert-view-test.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-bug-queue/som-bug-queue.html
[add] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-alert-category-test.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-settings/som-settings.js
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/test/index.html

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d15d07954c36210bfdb01a844daa7ae0477da642

commit d15d07954c36210bfdb01a844daa7ae0477da642
Author: Tiff Zhang <zhangtiff@google.com>
Date: Tue Jun 13 00:57:41 2017

SoM: Make all top level sections collapsible.

Bug:718127
Change-Id: I18066da728d7420bcc38998bfc821f644d7694ce
Reviewed-on: https://chromium-review.googlesource.com/530032
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/d15d07954c36210bfdb01a844daa7ae0477da642/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-category/som-alert-category.js
[modify] https://crrev.com/d15d07954c36210bfdb01a844daa7ae0477da642/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-swarming-bots/som-swarming-bots.html
[modify] https://crrev.com/d15d07954c36210bfdb01a844daa7ae0477da642/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-bug-queue/som-bug-queue.html
[modify] https://crrev.com/d15d07954c36210bfdb01a844daa7ae0477da642/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-category/som-alert-category.html
[modify] https://crrev.com/d15d07954c36210bfdb01a844daa7ae0477da642/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.html
[modify] https://crrev.com/d15d07954c36210bfdb01a844daa7ae0477da642/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-bug-queue/som-bug-queue.js
[modify] https://crrev.com/d15d07954c36210bfdb01a844daa7ae0477da642/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-swarming-bots/som-swarming-bots.js

Status: Fixed (was: Assigned)

Sign in to add a comment