New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718116 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Network grouping experiment doesn't group properly

Project Member Reported by allada@chromium.org, May 3 2017

Issue description

Recent refactor broke the grouping ability recently added to network panel in devtools.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e9adc6c75e97b47626520733f9a6ac3b3c010ef

commit 0e9adc6c75e97b47626520733f9a6ac3b3c010ef
Author: allada <allada@chromium.org>
Date: Thu May 04 02:40:40 2017

[Devtools] Fix network grouping experiment

There was a regression recently that was fixed (https://codereview.chromium.org/2838673003/) but broke the network grouping experiment. This patch fixes that regression.

We were deeming the item as not needing to be removed or added without checking if there is a new parent.

R=dgozman,pfeldman
BUG= 718116 

Review-Url: https://codereview.chromium.org/2856863006
Cr-Commit-Position: refs/heads/master@{#469250}

[modify] https://crrev.com/0e9adc6c75e97b47626520733f9a6ac3b3c010ef/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/0e9adc6c75e97b47626520733f9a6ac3b3c010ef/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Project Member

Comment 2 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e9adc6c75e97b47626520733f9a6ac3b3c010ef

commit 0e9adc6c75e97b47626520733f9a6ac3b3c010ef
Author: allada <allada@chromium.org>
Date: Thu May 04 02:40:40 2017

[Devtools] Fix network grouping experiment

There was a regression recently that was fixed (https://codereview.chromium.org/2838673003/) but broke the network grouping experiment. This patch fixes that regression.

We were deeming the item as not needing to be removed or added without checking if there is a new parent.

R=dgozman,pfeldman
BUG= 718116 

Review-Url: https://codereview.chromium.org/2856863006
Cr-Commit-Position: refs/heads/master@{#469250}

[modify] https://crrev.com/0e9adc6c75e97b47626520733f9a6ac3b3c010ef/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/0e9adc6c75e97b47626520733f9a6ac3b3c010ef/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Status: Fixed (was: Assigned)

Sign in to add a comment