Crash after enabling web payment modifiers |
|||||
Issue description1), enable 'Enable web payment modifiers Android' from chrome://flags 2), navigate to 'https://rsolomakhin.github.io/pr/' Chrome crashed,
,
May 3 2017
,
May 3 2017
Hi wuandy@, could you take a look of this issue since you are working on related codes,
,
May 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e09b31bb236f5fa84ee8c987c91329dc3e22509 commit 7e09b31bb236f5fa84ee8c987c91329dc3e22509 Author: wuandy <wuandy@chromium.org> Date: Fri May 12 18:46:00 2017 Fix chrome crash issue when payment modifiers are enabled on android. PaymentRequestImpl tries to call Set.retainAll in order to match payment method and modifiers. However, the Set is Unmodifieable when returned from AutoFill and other PaymentApp. This caused chrome crash. Fixed by copying the set into a HashSet then do retainAll. After above, a second bug is triggerd from inside updateOrderSummary because it tries to dereference UI object before it is created. Simply removed the dereference because it seems redundant. BUG= 718097 Review-Url: https://codereview.chromium.org/2874883002 Cr-Commit-Position: refs/heads/master@{#471385} [modify] https://crrev.com/7e09b31bb236f5fa84ee8c987c91329dc3e22509/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
,
May 12 2017
fixed.
,
May 12 2017
,
Jun 27 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by gogerald@chromium.org
, May 3 2017