New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 718094 link

Starred by 1 user
Status: WontFix
Owner:
█ warx@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
abodenha@chromium.org
weifangsun@chromium.org
steve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Tracking bug: Simplify chrome's portal detection on Chrome OS

Project Member Reported by warx@chromium.org, May 3 2017 
Chrome OS has connection manager ("Shill") which manages shill state: [1].
The shill's state is managed in chromeos::NetworkStateHandler. On chrome side, we are doing the full portal detection again based on if it is needed [2]. This tracking bug is in an effort to simplify chrome side logic.

Set it to P2 since I don't strongly think this will fix the existing captive portal issue.

Something have done:
a. Do not schedule attempt when behind captive portal with response 200 is detected: crrev.com/2756643002.
b. close dialog when shill detects captive portal network switched to online: crrev.com/2823323002.

[1] https://cs.chromium.org/chromium/src/third_party/cros_system_api/dbus/shill/dbus-constants.h?type=cs&l=205
[2] if it is needed: something like network changed, connection state changed, etc.
Project Member

Comment 1 by bugdroid1@chromium.org, May 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ce76f805592a7be9a1a7ee470cba75eba4d9585

commit 6ce76f805592a7be9a1a7ee470cba75eba4d9585
Author: warx <warx@chromium.org>
Date: Thu May 25 21:41:20 2017

Revert "cros: Do not schedule attempt when behind captive portal with response 200 is detected"

This reverts commit db14329b13d1109723acf5528a0253d6ee8c1651, reviewed on: https://codereview.chromium.org/2756643002

This should get rid of the existing issue of 705813. Do not schedule
attempts when behind portal is causing the trouble. When portal side
disconnects the connected device, and device reconnects, shill doesn't
report network changed. This case should be handled. Let us reconsider
the reducing detection attempts approach.

BUG=702273,  705813 ,  718094 
TEST=705813 is fixed. We shall reconsider the reducing detection
attempts approach.

Review-Url: https://codereview.chromium.org/2910503002
Cr-Commit-Position: refs/heads/master@{#474815}

[modify] https://crrev.com/6ce76f805592a7be9a1a7ee470cba75eba4d9585/chrome/browser/chromeos/net/network_portal_detector_impl.cc
[modify] https://crrev.com/6ce76f805592a7be9a1a7ee470cba75eba4d9585/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

Comment 3 by warx@chromium.org, Jun 6 2017

Status: WontFix (was: Assigned)

Comment 4 by yoshi@chromium.org, Aug 14

Cc: -yoshi@chromium.org
►

Sign in to add a comment