Update DrawDashRect to not use bitmaps. |
|
Issue descriptionWe should switch DrawDashRect to not use bitmaps, since Skia has a way to draw a dashed border that does not include bitmap shaders. The patch to do this is here: https://codereview.chromium.org/2863453002 The results are uploaded for different device scale factors (1, 1.5, 2, and 3). The results have two images side by side, before the patch on the left and after the patch on the right. Note that the difference is in the dashed border around "learn more" link. Does the visual result look acceptable?
,
May 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/519f83ea3b9d9d99fb1057f2d388fd3d834545f3 commit 519f83ea3b9d9d99fb1057f2d388fd3d834545f3 Author: vmpstr <vmpstr@chromium.org> Date: Thu May 04 16:38:59 2017 ui: Change DrawDashedRect to use a dash effect instead of bitmap. This patch changes the draw dash rect to use SkDashPathEffect instead of a bitmap shader to produce a dash effect. The visual result is different, but I think it's still acceptable. Please take a look at the referenced bug for the list of comparison. R=danakj@chromium.org, enne@chromium.org BUG=718084 Review-Url: https://codereview.chromium.org/2863453002 Cr-Commit-Position: refs/heads/master@{#469357} [modify] https://crrev.com/519f83ea3b9d9d99fb1057f2d388fd3d834545f3/ui/gfx/canvas.cc |
|
►
Sign in to add a comment |
|
Comment 1 by vmp...@chromium.org
, May 3 20179.0 KB
9.0 KB View Download
15.5 KB
15.5 KB View Download
22.6 KB
22.6 KB View Download
38.1 KB
38.1 KB View Download