UMA system_profile cpu_architecture field is not filled in. |
||||||||
Issue descriptionThe iOS device model (e.g. iPhone7,2) is stored in the cpu_architecture field. While it may not be the best place for it, it is the only place where this information is available for dissecting our crash and usage data. This is due to Issue 370104
,
May 3 2017
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f89092a8f533da1537b0a441b1e137b3d3b2728 commit 9f89092a8f533da1537b0a441b1e137b3d3b2728 Author: pkl <pkl@chromium.org> Date: Wed May 03 19:08:18 2017 Revert of Don't set cpu architecture field on iOS in UMA logs. (patchset #2 id:20001 of https://codereview.chromium.org/2671433002/ ) Reason for revert: This breaks Chrome iOS dashboards because cpu_architecture is the only field where we have the device model info (e.g. iPhone7,2). Original issue's description: > Don't set cpu architecture field on iOS in UMA logs. > > The value we were setting it to before was not correct, so this > change instead just makes the value not get set on iOS. > > BUG=370104 > > Review-Url: https://codereview.chromium.org/2671433002 > Cr-Commit-Position: refs/heads/master@{#447578} > Committed: https://chromium.googlesource.com/chromium/src/+/a86e8e115054ad167458d0379980db5473cb20de TBR=rkaplow@chromium.org,asvitkine@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=370104, 718080 Review-Url: https://codereview.chromium.org/2855943005 Cr-Commit-Position: refs/heads/master@{#469062} [modify] https://crrev.com/9f89092a8f533da1537b0a441b1e137b3d3b2728/components/metrics/metrics_log.cc [modify] https://crrev.com/9f89092a8f533da1537b0a441b1e137b3d3b2728/components/metrics/metrics_log_unittest.cc
,
May 4 2017
,
May 4 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-58; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-58 label, otherwise remove Merge-TBD label. Thanks.
,
May 5 2017
,
May 5 2017
,
May 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b293236194e22d784a5d77a04ebfad88e33f824e commit b293236194e22d784a5d77a04ebfad88e33f824e Author: asvitkine <asvitkine@chromium.org> Date: Fri May 05 14:02:47 2017 Reland of Don't set cpu architecture field on iOS in UMA logs. (patchset #1 id:1 of https://codereview.chromium.org/2855943005/ ) Reason for revert: Can be relanded now that we're filling in hardware class on iOS. Original issue's description: > Revert of Don't set cpu architecture field on iOS in UMA logs. (patchset #2 id:20001 of https://codereview.chromium.org/2671433002/ ) > > Reason for revert: > This breaks Chrome iOS dashboards because cpu_architecture is the only field where we have the device model info (e.g. iPhone7,2). > > Original issue's description: > > Don't set cpu architecture field on iOS in UMA logs. > > > > The value we were setting it to before was not correct, so this > > change instead just makes the value not get set on iOS. > > > > BUG=370104 > > > > Review-Url: https://codereview.chromium.org/2671433002 > > Cr-Commit-Position: refs/heads/master@{#447578} > > Committed: https://chromium.googlesource.com/chromium/src/+/a86e8e115054ad167458d0379980db5473cb20de > > TBR=rkaplow@chromium.org,asvitkine@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=370104, 718080 > > Review-Url: https://codereview.chromium.org/2855943005 > Cr-Commit-Position: refs/heads/master@{#469062} > Committed: https://chromium.googlesource.com/chromium/src/+/9f89092a8f533da1537b0a441b1e137b3d3b2728 TBR=pkl@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=370104, 718080 Review-Url: https://codereview.chromium.org/2863813002 Cr-Commit-Position: refs/heads/master@{#469638} [modify] https://crrev.com/b293236194e22d784a5d77a04ebfad88e33f824e/components/metrics/metrics_log.cc [modify] https://crrev.com/b293236194e22d784a5d77a04ebfad88e33f824e/components/metrics/metrics_log_unittest.cc
,
May 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0532b2e7b14f5c68d294a2faa6c03315ba5fd93 commit a0532b2e7b14f5c68d294a2faa6c03315ba5fd93 Author: sczs <sczs@chromium.org> Date: Fri May 05 15:08:02 2017 Revert of Don't set cpu architecture field on iOS in UMA logs. (patchset #2 id:20001 of https://codereview.chromium.org/2671433002/ ) Reason for revert: This breaks Chrome iOS dashboards because cpu_architecture is the only field where we have the device model info (e.g. iPhone7,2). Original issue's description: > Don't set cpu architecture field on iOS in UMA logs. > > The value we were setting it to before was not correct, so this > change instead just makes the value not get set on iOS. > > BUG=370104 > > Review-Url: https://codereview.chromium.org/2671433002 > Cr-Commit-Position: refs/heads/master@{#447578} > Committed: https://chromium.googlesource.com/chromium/src/+/a86e8e115054ad167458d0379980db5473cb20de TBR=rkaplow@chromium.org,asvitkine@chromium.org BUG=370104, 718080 Review-Url: https://codereview.chromium.org/2855943005 Cr-Commit-Position: refs/heads/master@{#469062} (cherry picked from commit 9f89092a8f533da1537b0a441b1e137b3d3b2728) Review-Url: https://codereview.chromium.org/2863143002 . Cr-Commit-Position: refs/branch-heads/3029@{#803} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/a0532b2e7b14f5c68d294a2faa6c03315ba5fd93/components/metrics/metrics_log.cc [modify] https://crrev.com/a0532b2e7b14f5c68d294a2faa6c03315ba5fd93/components/metrics/metrics_log_unittest.cc
,
May 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c13071f30acdea27138d85bb960103f8506f099 commit 8c13071f30acdea27138d85bb960103f8506f099 Author: sczs <sczs@chromium.org> Date: Fri May 05 15:22:22 2017 Revert of Don't set cpu architecture field on iOS in UMA logs. (patchset #2 id:20001 of https://codereview.chromium.org/2671433002/ ) Reason for revert: This breaks Chrome iOS dashboards because cpu_architecture is the only field where we have the device model info (e.g. iPhone7,2). Original issue's description: > Don't set cpu architecture field on iOS in UMA logs. > > The value we were setting it to before was not correct, so this > change instead just makes the value not get set on iOS. > > BUG=370104 > > Review-Url: https://codereview.chromium.org/2671433002 > Cr-Commit-Position: refs/heads/master@{#447578} > Committed: https://chromium.googlesource.com/chromium/src/+/a86e8e115054ad167458d0379980db5473cb20de TBR=rkaplow@chromium.org,asvitkine@chromium.org BUG=370104, 718080 Review-Url: https://codereview.chromium.org/2855943005 Cr-Commit-Position: refs/heads/master@{#469062} (cherry picked from commit 9f89092a8f533da1537b0a441b1e137b3d3b2728) Review-Url: https://codereview.chromium.org/2860093004 . Cr-Commit-Position: refs/branch-heads/3071@{#416} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/8c13071f30acdea27138d85bb960103f8506f099/components/metrics/metrics_log.cc [modify] https://crrev.com/8c13071f30acdea27138d85bb960103f8506f099/components/metrics/metrics_log_unittest.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by pkl@chromium.org
, May 3 2017