New issue
Advanced search Search tips

Issue 718079 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Add dchecks to prevent accidental construction of WebMouseEvent from WebMouseWheelEvent.

Project Member Reported by lfg@chromium.org, May 3 2017

Issue description

The idea is to prevent issues like  bug 701965 .

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2d91c0898fdf1feec4e335d25932da4de28bdf4

commit d2d91c0898fdf1feec4e335d25932da4de28bdf4
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Fri Jun 02 22:14:23 2017

Add DCHECKS to prevent incorrect construction of WebMouseEvent.

Bug:  718079 
Change-Id: I2f315038d0fb748d5c770daad9ed335b3cb1b364
Reviewed-on: https://chromium-review.googlesource.com/517730
Commit-Queue: Lucas Furukawa Gadani <lfg@chromium.org>
Reviewed-by: David Tapuska <dtapuska@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476813}
[modify] https://crrev.com/d2d91c0898fdf1feec4e335d25932da4de28bdf4/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/d2d91c0898fdf1feec4e335d25932da4de28bdf4/third_party/WebKit/Source/platform/WebMouseEvent.cpp
[modify] https://crrev.com/d2d91c0898fdf1feec4e335d25932da4de28bdf4/third_party/WebKit/public/platform/WebMouseEvent.h

Comment 2 by lfg@chromium.org, Jun 5 2017

Status: Fixed (was: Assigned)

Sign in to add a comment