New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718058 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Reorganize Service Manager client lib directory

Project Member Reported by ben@chromium.org, May 3 2017

Issue description

Currently we have a soup in cpp/ with impl files in lib/ which is generally annoying. I propose we blow this up, & do something like this:

cpp/
  -> connector_impl.cc,h
  -> service_context.cc
  -> service.cc
  standalone/
  test/
    -> service_test.cc,h
  types/
    -> bind_source_info*, identity*, interface_provider_spec*,
  util/
    -> connect.h
    -> binder_registry.cc,h
    -> interface_binder.h, callback_binder.cc,h
    -> service_context_ref.cc,h
    -> interface_provider.cc,h
    -> init_commandline.cc
    -> initialize_base_and_icu.cc
    -> service_runner.cc,h

Additionally I propose flattening connector.h & connector_impl.cc/h. There's no real reason to have a virtual interface for this, considering ServiceContext etc are concrete classes.

 
Can we start by just killing lib/ and flattening connector? Also init_commandline.cc and initialize_base_and_icu.cc can just be deleted.

Comment 2 by ben@chromium.org, May 3 2017

sg
Components: -Internals>Mojo Internals>Services>ServiceManager
Status: Fixed (was: Assigned)
This was done a long time ago, closing

Sign in to add a comment