Is this related to some Mojo usage of gin?
Mojo is moving away from gin very soon (I hope it happens in this quarter.)

Per offline discussion, gin::Runner is currently only used by Mojo. So instead of fixing it, we could remove it after we finish switching to the new Mojo JS bindings. 

yzshen: Any updates?  Bug 629431  is fixed but it depends on this one.

There is still one last old Mojo JS bindings (i.e., usage of gin by Mojo) left: an external dependency caused by the mojoPrivate extension API.

I am planning to work on it. Will need to chat with the users of this API. If I could create some adapter preserving the behavior of that API but backed by the new JS bindings, it would be easier.

Any updates on this bug? We'd like to close out  Bug 629431  if possible. There's a bug priority inversion thing going on, so fixing that.

Sorry. Haven't got a chance to work on this since Sep.
I will start dealing with it today.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eca9c1de14c95fc5c4f23f1b2b144349de5f2817

commit eca9c1de14c95fc5c4f23f1b2b144349de5f2817
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Thu Nov 02 17:20:00 2017

Remove unused method define() in the private mojoPrivate extensions API.

Bug:  699569 , 718047 
Change-Id: I2ebda3e66b6cb7f74cb6bc3f577f978022374a14
Reviewed-on: https://chromium-review.googlesource.com/750191
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513529}
[modify] https://crrev.com/eca9c1de14c95fc5c4f23f1b2b144349de5f2817/extensions/common/api/mojo_private.idl
[modify] https://crrev.com/eca9c1de14c95fc5c4f23f1b2b144349de5f2817/extensions/renderer/api/mojo_private/mojo_private_unittest.cc
[modify] https://crrev.com/eca9c1de14c95fc5c4f23f1b2b144349de5f2817/extensions/renderer/resources/mojo_private_custom_bindings.js
[modify] https://crrev.com/eca9c1de14c95fc5c4f23f1b2b144349de5f2817/extensions/test/data/mojo_private_unittest.js
[modify] https://crrev.com/eca9c1de14c95fc5c4f23f1b2b144349de5f2817/tools/valgrind/memcheck/suppressions.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a07793629b292186d42e059b36275549745202c

commit 4a07793629b292186d42e059b36275549745202c
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Fri Nov 10 17:38:41 2017

extensions::ModuleSystem: expose a loadScript('module_name') function.

This function directly runs the given module in the current scope.

Bug:  699569 ,  718047 
Change-Id: I233392e2c5cce5c26ebc6c10f324f2bcfb1e12b1
Reviewed-on: https://chromium-review.googlesource.com/762399
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515584}
[modify] https://crrev.com/4a07793629b292186d42e059b36275549745202c/extensions/renderer/module_system.cc
[modify] https://crrev.com/4a07793629b292186d42e059b36275549745202c/extensions/renderer/module_system.h
[modify] https://crrev.com/4a07793629b292186d42e059b36275549745202c/extensions/renderer/module_system_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2efe42776d86948a7e0cdb69ef2462c66bbd8abf

commit 2efe42776d86948a7e0cdb69ef2462c66bbd8abf
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Sat Nov 11 02:01:09 2017

Move the mojo JS bindings resource into a separate grd file in mojo/pubilc/js.

So that the resource could be used from both WebUI and extensions.

BUG= 699569 ,  718047 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If2ce60b15e0351aba801746cd863e5a2b9e85485
Reviewed-on: https://chromium-review.googlesource.com/762393
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515792}
[modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/ash/resources/BUILD.gn
[modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/chrome/chrome_paks.gni
[modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/chromecast/BUILD.gn
[modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/content/browser/BUILD.gn
[modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/content/browser/webui/shared_resources_data_source.cc
[modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/content/shell/BUILD.gn
[modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/extensions/BUILD.gn
[modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/headless/BUILD.gn
[modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/ios/chrome/app/resources/BUILD.gn
[modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/mojo/public/js/BUILD.gn
[add] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/mojo/public/js/mojo_bindings_resources.grd
[modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/tools/gritsettings/resource_ids
[modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/ui/resources/BUILD.gn
[modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/ui/webui/resources/webui_resources.grd

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcd734d18252271a42d52a0e9f263f6b16ac88a1

commit bcd734d18252271a42d52a0e9f263f6b16ac88a1
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Wed Nov 15 20:40:58 2017

Enable new mojo JS bindings in extensions blessed context.

This CL:
- Adds support to load extensions JS sources from gzipped resources, since the
  JS file for new mojo JS bindings is gzipped. The alternative is to change the
  JS file to uncompressed, which would increase Chrome size quite significantly.
  For example, adding ~132KB to resources.pak for Linux official build.
- Converts mimeHandlerPrivate to use new Mojo JS bindings.

BUG= 699569 ,  718047 

Change-Id: If485020558f607a1d2e81296476c60a20e7dd21b
Reviewed-on: https://chromium-review.googlesource.com/767649
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516811}
[modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/common/api/BUILD.gn
[modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/DEPS
[modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/api_test_base.cc
[modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/dispatcher.h
[modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/module_system.cc
[modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/module_system_test.cc
[modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/module_system_test.h
[modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/resource_bundle_source_map.cc
[modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/resource_bundle_source_map.h
[modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/resources/extensions_renderer_resources.grd
[modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/resources/mime_handler_private_custom_bindings.js
[modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/string_source_map.cc
[modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/string_source_map.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d91c0f145e1dfd5364e6f8bb5441257d84d2fc51

commit d91c0f145e1dfd5364e6f8bb5441257d84d2fc51
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Mon Nov 20 22:51:17 2017

Extensions: convert keep_alive.js to use new Mojo JS bindings.

Bug:  699569 ,  718047 
Change-Id: I61f40ef3a6e7248eb11b3fba75ead7f96ca9cb51
Reviewed-on: https://chromium-review.googlesource.com/770149
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517966}
[modify] https://crrev.com/d91c0f145e1dfd5364e6f8bb5441257d84d2fc51/extensions/common/BUILD.gn
[modify] https://crrev.com/d91c0f145e1dfd5364e6f8bb5441257d84d2fc51/extensions/renderer/BUILD.gn
[delete] https://crrev.com/d550293969c69349438e5f8e18d074489e905261/extensions/renderer/mojo/keep_alive_client_unittest.cc
[modify] https://crrev.com/d91c0f145e1dfd5364e6f8bb5441257d84d2fc51/extensions/renderer/resources/keep_alive.js
[modify] https://crrev.com/d91c0f145e1dfd5364e6f8bb5441257d84d2fc51/extensions/renderer/resources/utils.js
[delete] https://crrev.com/d550293969c69349438e5f8e18d074489e905261/extensions/test/data/keep_alive_client_unittest.js
[modify] https://crrev.com/d91c0f145e1dfd5364e6f8bb5441257d84d2fc51/mojo/public/js/new_bindings/base.js

Is this bug fixed? I'd like to unblock  Issue 629431  and mark it as Fixed as well, if possible. Thank you!

It is being actively worked on.

At the moment, old mojo JS bindings is only exposed to blessed extension context. And only the private extension API mojoPrivate uses it. This API is used by the media router extension living in google3. There is a CL under review to remove that: https://chromium-review.googlesource.com/c/chromium/src/+/783645

I don't have access to 629431. But if it is about normal web pages, then it shouldn't be a concern.

Thank you, yzshen! I have added you to  Issue 629431 .

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd47059ede03db6318da217f017bc73b186e09eb

commit cd47059ede03db6318da217f017bc73b186e09eb
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Fri Dec 01 23:50:20 2017

Extensions: convert media_router_bindings.js to use new Mojo JS bindings.

This CL also changes the mojoPrivate API to be simply an async wrapper around
require().

Bug:  699569 ,  718047 
Change-Id: I271887d1cc1eb49fd2faefff47467c47be23a3be
Reviewed-on: https://chromium-review.googlesource.com/783645
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521129}
[modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/chrome/common/media_router/mojo/BUILD.gn
[modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/chrome/renderer/resources/extensions/media_router_bindings.js
[modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/extensions/common/BUILD.gn
[modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/extensions/renderer/api/mojo_private/mojo_private_unittest.cc
[modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/extensions/renderer/resources/mime_handler_private_custom_bindings.js
[modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/extensions/renderer/resources/mojo_private_custom_bindings.js
[modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/extensions/test/data/mojo_private_unittest.js
[modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/media/mojo/interfaces/BUILD.gn
[modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/mojo/common/BUILD.gn
[modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/net/interfaces/BUILD.gn
[modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/url/mojo/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/312031eec9c97d5cb9dea801f4f3cefe2f3ad937

commit 312031eec9c97d5cb9dea801f4f3cefe2f3ad937
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Mon Dec 04 23:31:23 2017

Extensions: Remove old Mojo JS bindings support and AMD-style module support.

This significantly reduces non-Android chrome size. With an official build on Linux,
  before the change - resources.pak 12230694
  after  the change - resources.pak 12069587
The difference is about 160KB.

Bug:  699569 ,  718047 
Change-Id: I2d2f6985cb10c27637a8a7d478001b18ac1b8111
Reviewed-on: https://chromium-review.googlesource.com/804974
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521516}
[modify] https://crrev.com/312031eec9c97d5cb9dea801f4f3cefe2f3ad937/extensions/renderer/BUILD.gn
[delete] https://crrev.com/deb6be0c94f8f9724f6e73b2092964fed8b6a6b6/extensions/renderer/api/mojo_private/mojo_private_unittest.cc
[delete] https://crrev.com/deb6be0c94f8f9724f6e73b2092964fed8b6a6b6/extensions/renderer/api_test_base.cc
[delete] https://crrev.com/deb6be0c94f8f9724f6e73b2092964fed8b6a6b6/extensions/renderer/api_test_base.h
[delete] https://crrev.com/deb6be0c94f8f9724f6e73b2092964fed8b6a6b6/extensions/renderer/api_test_base_unittest.cc
[modify] https://crrev.com/312031eec9c97d5cb9dea801f4f3cefe2f3ad937/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/312031eec9c97d5cb9dea801f4f3cefe2f3ad937/extensions/renderer/module_system.cc
[modify] https://crrev.com/312031eec9c97d5cb9dea801f4f3cefe2f3ad937/extensions/renderer/module_system.h
[modify] https://crrev.com/312031eec9c97d5cb9dea801f4f3cefe2f3ad937/extensions/renderer/module_system_unittest.cc
[delete] https://crrev.com/deb6be0c94f8f9724f6e73b2092964fed8b6a6b6/extensions/renderer/resources/async_waiter.js
[modify] https://crrev.com/312031eec9c97d5cb9dea801f4f3cefe2f3ad937/extensions/renderer/resources/extensions_renderer_resources.grd
[delete] https://crrev.com/deb6be0c94f8f9724f6e73b2092964fed8b6a6b6/extensions/test/data/api_test_base_unittest.js
[delete] https://crrev.com/deb6be0c94f8f9724f6e73b2092964fed8b6a6b6/extensions/test/data/mojo_private_unittest.js
[delete] https://crrev.com/deb6be0c94f8f9724f6e73b2092964fed8b6a6b6/extensions/test/data/unit_test_environment_specific_bindings.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb7807f3c81a129ad2f734f3904fc91ba5d507ac

commit cb7807f3c81a129ad2f734f3904fc91ba5d507ac
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Wed Dec 06 19:19:07 2017

extensions::ScriptContext: remove gin::Runner implementation.

It is only used by the old-style Mojo JS bindings, which have been removed.

Bug:  718047 
Change-Id: Ib3e112f8b2a9cd772bb15146ee52eb1de63b2eff
Reviewed-on: https://chromium-review.googlesource.com/809772
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522160}
[modify] https://crrev.com/cb7807f3c81a129ad2f734f3904fc91ba5d507ac/extensions/renderer/BUILD.gn
[modify] https://crrev.com/cb7807f3c81a129ad2f734f3904fc91ba5d507ac/extensions/renderer/script_context.cc
[modify] https://crrev.com/cb7807f3c81a129ad2f734f3904fc91ba5d507ac/extensions/renderer/script_context.h
[delete] https://crrev.com/db77c44916a84b82327d64608bfb8ef2dc4ff090/extensions/renderer/script_context_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/332f5981400c7806126279035c96a96dc777f89c

commit 332f5981400c7806126279035c96a96dc777f89c
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Wed Dec 06 21:11:05 2017

Remove support for old-style Mojo JS bindings.

Bug:  699569 ,  718047 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3e2d9e55cac52b392bd31c96c51cc94a361b618b
Reviewed-on: https://chromium-review.googlesource.com/809545
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522193}
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/build/sanitizers/lsan_suppressions.cc
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/chrome/browser/BUILD.gn
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/chrome/renderer/resources/extensions/media_router_bindings.js
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/components/cronet/tools/generators/cronet_bindings_generator.py
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/content/browser/BUILD.gn
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/content/public/common/bindings_policy.h
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/content/public/renderer/render_frame.h
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/content/renderer/BUILD.gn
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/content/renderer/mojo/blink_connector_js_wrapper.cc
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/content/renderer/mojo/blink_connector_js_wrapper.h
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/content/renderer/mojo/interface_provider_js_wrapper.cc
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/content/renderer/mojo/interface_provider_js_wrapper.h
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/content/renderer/render_frame_impl.h
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/content/shell/BUILD.gn
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/content/test/BUILD.gn
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/extensions/BUILD.gn
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/BUILD.gn
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/edk/DEPS
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/BUILD.gn
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/core.cc
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/core.h
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/drain_data.cc
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/drain_data.h
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/handle.cc
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/handle.h
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/handle_close_observer.h
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/handle_unittest.cc
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/js_export.h
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/mojo_runner_delegate.cc
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/mojo_runner_delegate.h
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/support.cc
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/support.h
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/tests/BUILD.gn
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/tests/OWNERS
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/tests/run_js_unittests.cc
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/threading.cc
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/threading.h
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/waiting_callback.cc
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/waiting_callback.h
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/BUILD.gn
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/interfaces/bindings/BUILD.gn
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/interfaces/bindings/new_bindings/OWNERS
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/interfaces/bindings/new_bindings/interface_control_messages.mojom
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/interfaces/bindings/new_bindings/pipe_control_messages.mojom
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/js/BUILD.gn
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/js/README.md
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/associated_bindings.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/bindings.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/buffer.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/codec.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/connector.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/constants.cc
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/constants.h
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/core.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/interface_types.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/lib/control_message_handler.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/lib/control_message_proxy.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/lib/interface_endpoint_client.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/lib/interface_endpoint_handle.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/lib/pipe_control_message_handler.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/lib/pipe_control_message_proxy.js
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/js/new_bindings/lib/control_message_handler.js
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/js/new_bindings/lib/control_message_proxy.js
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/js/new_bindings/lib/pipe_control_message_handler.js
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/js/new_bindings/lib/pipe_control_message_proxy.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/router.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/support.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/tests/core_unittest.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/threading.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/unicode.js
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/validator.js
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/tools/bindings/generators/mojom_js_generator.py
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/tools/bindings/mojom.gni
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/testing/buildbot/chromium.sandbox.json
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/testing/buildbot/filters/BUILD.gn
[delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/testing/buildbot/filters/fuchsia.mojo_js_unittests.filter
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/tools/determinism/deterministic_build_whitelist.pyl

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1ab49a9e23036de2f94da601782da9985a9a481

commit c1ab49a9e23036de2f94da601782da9985a9a481
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Fri Dec 08 19:54:49 2017

Remove AMD-style module support from gin/.

Bug:  718047 
Change-Id: If480fff65a2e5993ed5143eede8354f890de3a3b
Reviewed-on: https://chromium-review.googlesource.com/812172
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522850}
[modify] https://crrev.com/c1ab49a9e23036de2f94da601782da9985a9a481/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
[modify] https://crrev.com/c1ab49a9e23036de2f94da601782da9985a9a481/gin/BUILD.gn
[modify] https://crrev.com/c1ab49a9e23036de2f94da601782da9985a9a481/gin/modules/console.cc
[modify] https://crrev.com/c1ab49a9e23036de2f94da601782da9985a9a481/gin/modules/console.h
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/modules/file_module_provider.cc
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/modules/file_module_provider.h
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/modules/module_registry.cc
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/modules/module_registry.h
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/modules/module_registry_observer.h
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/modules/module_registry_unittest.cc
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/modules/module_registry_unittests.js
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/modules/module_runner_delegate.cc
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/modules/module_runner_delegate.h
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/modules/timer.cc
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/modules/timer.h
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/modules/timer_unittest.cc
[modify] https://crrev.com/c1ab49a9e23036de2f94da601782da9985a9a481/gin/runner.h
[modify] https://crrev.com/c1ab49a9e23036de2f94da601782da9985a9a481/gin/shell/gin_main.cc
[modify] https://crrev.com/c1ab49a9e23036de2f94da601782da9985a9a481/gin/shell/hello_world.js
[modify] https://crrev.com/c1ab49a9e23036de2f94da601782da9985a9a481/gin/shell_runner.cc
[modify] https://crrev.com/c1ab49a9e23036de2f94da601782da9985a9a481/gin/shell_runner.h
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/test/expect.js
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/test/file.cc
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/test/file.h
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/test/file_runner.cc
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/test/file_runner.h
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/test/file_unittests.js
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/test/gc.cc
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/test/gc.h
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/test/gtest.cc
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/test/gtest.h
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/test/gtest_unittests.js
[delete] https://crrev.com/468456a69c7144ac9eede7e32fc999452ab6f2e2/gin/test/run_js_tests.cc

gin::Runner::Call is gone!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8f25f1e37e561d17222773d869ca460e00d8fe1

commit a8f25f1e37e561d17222773d869ca460e00d8fe1
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Fri Dec 08 23:37:45 2017

Revert "Remove AMD-style module support from gin/."

This reverts commit c1ab49a9e23036de2f94da601782da9985a9a481.

Reason for revert: Likely the cause of
RunnerTest.Run failure in gin_unittests: Check failed: (isolate->snapshot_blob()) == nullptr.

Original change's description:
> Remove AMD-style module support from gin/.
> 
> Bug:  718047 
> Change-Id: If480fff65a2e5993ed5143eede8354f890de3a3b
> Reviewed-on: https://chromium-review.googlesource.com/812172
> Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#522850}

TBR=yzshen@chromium.org,jochen@chromium.org

Change-Id: I4a6efb21dd7972994a06ddab1316fa43e5d3e060
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  718047 ,  793480 
Reviewed-on: https://chromium-review.googlesource.com/817373
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522921}
[modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
[modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/BUILD.gn
[modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/console.cc
[modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/console.h
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/file_module_provider.cc
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/file_module_provider.h
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/module_registry.cc
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/module_registry.h
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/module_registry_observer.h
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/module_registry_unittest.cc
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/module_registry_unittests.js
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/module_runner_delegate.cc
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/module_runner_delegate.h
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/timer.cc
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/timer.h
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/timer_unittest.cc
[modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/runner.h
[modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/shell/gin_main.cc
[modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/shell/hello_world.js
[modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/shell_runner.cc
[modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/shell_runner.h
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/expect.js
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/file.cc
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/file.h
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/file_runner.cc
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/file_runner.h
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/file_unittests.js
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/gc.cc
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/gc.h
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/gtest.cc
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/gtest.h
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/gtest_unittests.js
[add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/run_js_tests.cc

Have figured out the reason of test failure (missing deps not part of this CL).
Will fix that and reland.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fab605346784c79e72973e1a41dfce5cda7903a

commit 4fab605346784c79e72973e1a41dfce5cda7903a
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Mon Dec 11 20:50:07 2017

Reland "Remove AMD-style module support from gin/."

This is a reland of c1ab49a9e23036de2f94da601782da9985a9a481
Original change's description:
> Remove AMD-style module support from gin/.
>
> Bug:  718047 
> Change-Id: If480fff65a2e5993ed5143eede8354f890de3a3b
> Reviewed-on: https://chromium-review.googlesource.com/812172
> Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#522850}

TBR=jochen@chromium.org
(There is no changes to the original CL.)

Bug:  718047 
Change-Id: I95600ef92ce7014e5240712b4dc4e962f431b526
Reviewed-on: https://chromium-review.googlesource.com/820091
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523198}
[modify] https://crrev.com/4fab605346784c79e72973e1a41dfce5cda7903a/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
[modify] https://crrev.com/4fab605346784c79e72973e1a41dfce5cda7903a/gin/BUILD.gn
[modify] https://crrev.com/4fab605346784c79e72973e1a41dfce5cda7903a/gin/modules/console.cc
[modify] https://crrev.com/4fab605346784c79e72973e1a41dfce5cda7903a/gin/modules/console.h
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/modules/file_module_provider.cc
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/modules/file_module_provider.h
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/modules/module_registry.cc
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/modules/module_registry.h
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/modules/module_registry_observer.h
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/modules/module_registry_unittest.cc
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/modules/module_registry_unittests.js
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/modules/module_runner_delegate.cc
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/modules/module_runner_delegate.h
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/modules/timer.cc
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/modules/timer.h
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/modules/timer_unittest.cc
[modify] https://crrev.com/4fab605346784c79e72973e1a41dfce5cda7903a/gin/runner.h
[modify] https://crrev.com/4fab605346784c79e72973e1a41dfce5cda7903a/gin/shell/gin_main.cc
[modify] https://crrev.com/4fab605346784c79e72973e1a41dfce5cda7903a/gin/shell/hello_world.js
[modify] https://crrev.com/4fab605346784c79e72973e1a41dfce5cda7903a/gin/shell_runner.cc
[modify] https://crrev.com/4fab605346784c79e72973e1a41dfce5cda7903a/gin/shell_runner.h
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/test/expect.js
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/test/file.cc
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/test/file.h
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/test/file_runner.cc
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/test/file_runner.h
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/test/file_unittests.js
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/test/gc.cc
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/test/gc.h
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/test/gtest.cc
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/test/gtest.h
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/test/gtest_unittests.js
[delete] https://crrev.com/c268c911c7def0c5431a39b612ca83e1a6f5e02a/gin/test/run_js_tests.cc

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot