Issue metadata
Sign in to add a comment
|
10% regression in blink_perf.paint at 466902:466954 |
||||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 3 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8980603683508566896
,
May 3 2017
=== Auto-CCing suspected CL author chrishtr@chromium.org === Hi chrishtr@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : chrishtr Commit : 7c90da71a8f435ae99bb7f90e0cc1cfcc96cc1fd Date : Tue Apr 25 07:27:45 2017 Subject: Refactor to centralize code which decides whether ObjectPaintProperties are needed. Bisect Details Configuration: winx64ati_perf_bisect Benchmark : blink_perf.paint Metric : complex-content-slow-scroll/complex-content-slow-scroll Change : 10.53% | 184.9625 -> 204.447666667 Revision Result N chromium@466901 184.963 +- 0.930897 6 good chromium@466915 186.251 +- 1.24692 6 good chromium@466916 204.122 +- 4.3497 6 bad <-- chromium@466917 200.319 +- 1.40643 6 bad chromium@466919 202.405 +- 2.00423 6 bad chromium@466922 200.689 +- 1.76128 6 bad chromium@466928 203.493 +- 1.62821 6 bad chromium@466954 204.448 +- 1.95859 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.paint Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8980603683508566896 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5284258760884224 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
May 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba864de6c45b5a5379488e3b234474d7ca574f4e commit ba864de6c45b5a5379488e3b234474d7ca574f4e Author: chrishtr <chrishtr@chromium.org> Date: Mon May 15 21:28:20 2017 Don't clear or allocate paint properties if they won't change. BUG= 718045 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2880423002 Cr-Commit-Position: refs/heads/master@{#471907} [modify] https://crrev.com/ba864de6c45b5a5379488e3b234474d7ca574f4e/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
,
May 15 2017
,
May 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b717e22b72275498d43183016392b2ae0a011b3e commit b717e22b72275498d43183016392b2ae0a011b3e Author: chrishtr <chrishtr@chromium.org> Date: Mon May 15 23:58:48 2017 Don't bother checking for paint properties for classes that never need them. In local testing, PerformanceTests/Paint/complex-content-slow-scroll.html improves by about 10%. BUG= 718045 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2883153002 Cr-Commit-Position: refs/heads/master@{#471952} [modify] https://crrev.com/b717e22b72275498d43183016392b2ae0a011b3e/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
,
May 17 2017
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b3799fee23bfbfc578c184236a4b3f663509f95 commit 1b3799fee23bfbfc578c184236a4b3f663509f95 Author: chrishtr <chrishtr@chromium.org> Date: Thu May 18 16:52:12 2017 Only call paint property-requiring subroutines if there are actually properties. Local testing seems to show a 10% or so performance improvement on Paint/complex-content-slow-scroll.html. BUG= 718045 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2886133003 Cr-Commit-Position: refs/heads/master@{#472846} [modify] https://crrev.com/1b3799fee23bfbfc578c184236a4b3f663509f95/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/1b3799fee23bfbfc578c184236a4b3f663509f95/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
,
Jun 9 2017
Dup'ing the rest of the bug into the other one. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by mustaq@chromium.org
, May 3 2017