TBD: We could present this all the time, or only when the user is interacting with touch (via an on-screen-keyboard)

drive-by: the text in the omnibox is commonly a URL.  A tool-tip of "Clear search text" seems inappropriate.  Perhaps "Clear text"?

@1: Please do this only with OSK, not all the time.

+shimi for help with tooltip string. I think "Clear text" is a reasonable first proposal.

This button will be an 'x', right? Bettes will need to tell us which version to use to fit in with Harmony.

"Clear text" or "Clear address bar" for the tooltip. 

BTW, another use case could be for the screen reader user.

re: the premise of this bug, why do touch users have a hard time removing text? One tap selects all and brings up the OSK. Then you can begin typing.

so here is my proposal, reflected in WIP (but mostly finished) CL here: https://chromium-review.googlesource.com/517915

Show the close button when a) the virtual keyboard is visible, AND b) input is in progress in the omnibox.

Currently we hide other location bar decorations (star, zoom icon, etc.) when input is in progress. This will be the reverse: only *show* the clear button when input is in progress. This means you won't see it on first tap, when the text all gets highlighted anyway and typing will clear it, and you won't see it in addition to any other decorations (except sometimes the keyword hint view that says "Press to search...").

What asset are we using for this icon? Screenshot attached using the same X icon that we use in a few other places like the find bar.

Deleted: L8zK1pNROgn.png 12.7 KB

	L8zK1pNROgn.png 12.7 KB View Download

Thanks evan. That looks good to me. +hwi to review.

And here's what it looks like with the keyword hint, which I think is a bit off. It makes it look like the [x] applies to the search bubble somehow.

Hwi, please assign back to me after review, thanks.

- See the attached for spec 
- X from tab strip looks better to me. Let me know if this needs a separate set of svgs.
- Label idea: "Clear input" (we use this for clank a11y label)

Deleted: 02 suggest-append-on-touch-spec.png 31.3 KB

	02 suggest-append-on-touch-spec.png 31.3 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cadfcdcc9c336034eb55128765768d393d443a70

commit cadfcdcc9c336034eb55128765768d393d443a70
Author: Evan Stade <estade@chromium.org>
Date: Thu Jun 08 01:59:07 2017

Show a clear all button in the omnibox when editing with virtual keyboard.

Bug:  718037 
Change-Id: I9b9761919b9211fa4b2605c3317bf6de5ad668eb
Reviewed-on: https://chromium-review.googlesource.com/517915
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477858}
[modify] https://crrev.com/cadfcdcc9c336034eb55128765768d393d443a70/chrome/app/generated_resources.grd
[modify] https://crrev.com/cadfcdcc9c336034eb55128765768d393d443a70/chrome/browser/ui/views/location_bar/keyword_hint_view.cc
[modify] https://crrev.com/cadfcdcc9c336034eb55128765768d393d443a70/chrome/browser/ui/views/location_bar/keyword_hint_view.h
[modify] https://crrev.com/cadfcdcc9c336034eb55128765768d393d443a70/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/cadfcdcc9c336034eb55128765768d393d443a70/chrome/browser/ui/views/location_bar/location_bar_view.h

Tested the issue on Windows-10 using chrome latest Dev M61-61.0.3128.0 by following steps mentioned in the original comment. 
Steps Followed:
Scenario-1 : Install chrome and change windows to tablet mode and enter the text in omnibox with keyboard.
Scenario-2 : Install chrome and change windows to tablet mode and connect external keyboard to laptop and enter the text in omnibox.
Scenario-3 : Install chrome and change windows to tablet mode and enter the text in omnibox with on screen keyboard.
Scenario-4 : Install chrome & Virtual Keyboard in windows tablet mode and enter the text in omnibox
Please find the screen shot for reference.

@estade: Not able to find the clear all icon in omnibox. Could you please help us to provide the test steps of the issue which would help us to verify the issue.

Thanks in Advance.

Deleted: 718037.PNG 318 KB

	718037.PNG 318 KB View Download

+bsep, pkasting, does keyboard_util:: work on Windows?

rbasuvula, does this work for you on chrome os?

+gene who said he was looking into #17

I'm not sure. I can't find a reason it wouldn't work just by looking at it. But I seem to recall virtual keyboard detection is weird (related to bug 491516?). Rob might know more.

If this is Pri-2, it probably should have a milestone.  Where does it fit on the roadmap?

Verified that this works in Windows (tablet mode) in 62.0.3188.0