testSignInOpenSettings and testSignInAndTapSettingsLink are failing. |
|||||||
Issue descriptionSign in tests are failing in the target ios_chrome_ui_egtests: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone10-simulator/builds/5352/steps/ios_chrome_ui_egtests%20%28iPhone%205%20iOS%2010.0%29%20on%20Mac There seems to be a problem with the account_tracker: [0503/064058.584598:ERROR:account_tracker.cc(374)] OnOAuthError [0503/064058.584729:WARNING:account_tracker.cc(294)] Failed to get UserInfo for fooID Full log of failure of testSignInOpenSettings: https://paste.googleplex.com/5483254505275392 Full log of failure of testSignInAndTapSettingsLink: https://paste.googleplex.com/4887266858106880
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ce3e34232f0f46251b4a844720f1374433219ee commit 2ce3e34232f0f46251b4a844720f1374433219ee Author: jif <jif@chromium.org> Date: Wed May 03 15:06:02 2017 Disable testSignInOpenSettings and testSignInAndTapSettingsLink on iOS. TBR=bzanotti NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 718023 Review-Url: https://codereview.chromium.org/2857993002 Cr-Commit-Position: refs/heads/master@{#468973} [modify] https://crrev.com/2ce3e34232f0f46251b4a844720f1374433219ee/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm [modify] https://crrev.com/2ce3e34232f0f46251b4a844720f1374433219ee/ios/chrome/browser/ui/first_run/first_run_egtest.mm
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f55aca28408bd2647c045b8e93c97e7cb93c5ab commit 2f55aca28408bd2647c045b8e93c97e7cb93c5ab Author: michaeldo <michaeldo@chromium.org> Date: Wed May 03 20:24:03 2017 Fix disabled test method name format. BUG= 718023 TBR=jif@chromium.org Review-Url: https://codereview.chromium.org/2859723003 Cr-Commit-Position: refs/heads/master@{#469105} [modify] https://crrev.com/2f55aca28408bd2647c045b8e93c97e7cb93c5ab/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm [modify] https://crrev.com/2f55aca28408bd2647c045b8e93c97e7cb93c5ab/ios/chrome/browser/ui/first_run/first_run_egtest.mm
,
May 4 2017
I need to investigate if this could help: [GREYTestHelper enableFastAnimation];
,
May 4 2017
Need to find a way to test several time the same test, to check the flakiness locally.
,
May 23 2017
Same here. This should have been a RBB for M60
,
May 31 2017
After talking with Mihai, we decided to add a delay after the sign-in to make sure confirmation view is arrived before EarlGrey clicks on the settings link. I can't reproduce the flakiness on my computer.
,
May 31 2017
There is definitely no bug in Chromium code. The bug is somewhere in the tests.
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b87d80f6485276511b3c543e90cde926eed2838d commit b87d80f6485276511b3c543e90cde926eed2838d Author: jlebel <jlebel@chromium.org> Date: Fri Jun 02 16:40:46 2017 Making the gradient click-through in ChromeSigninViewController "Settings" button is partially below the gradient while using small screen like iPhone SE. This is probably the reason why testSignInOpenSettings and testSignInAndTapSettingsLink can be flaky. Also, updating those 2 tests to make it more robust to animation by adding calls to WaitForMatcher(), to wait for "Settings" to be displayed. BUG= 718023 Review-Url: https://codereview.chromium.org/2906313004 Cr-Commit-Position: refs/heads/master@{#476691} [modify] https://crrev.com/b87d80f6485276511b3c543e90cde926eed2838d/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm [modify] https://crrev.com/b87d80f6485276511b3c543e90cde926eed2838d/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm [modify] https://crrev.com/b87d80f6485276511b3c543e90cde926eed2838d/ios/chrome/browser/ui/first_run/BUILD.gn [modify] https://crrev.com/b87d80f6485276511b3c543e90cde926eed2838d/ios/chrome/browser/ui/first_run/first_run_egtest.mm
,
Jun 5 2017
Jerome has fixed the bug last week and forgot to mark it as fixed. He did not merge it yet to M60. I do not think this bug should be RBB though as it is a bug in the test. Moving it to RBS.
,
Jun 5 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-60; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-60 label, otherwise remove Merge-TBD label. Thanks.
,
Jun 12 2017
,
Jun 12 2017
The bug is marked as P3 or Feature. It should not be merged as M60 is in beta. Please contact the approriate milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 24 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jif@chromium.org
, May 3 2017