New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718014 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Remove Autofill UKM logging killswitch

Project Member Reported by se...@chromium.org, May 3 2017

Issue description

The logging of Autofill UKMs is hidden behing a Feature. The objective of that Feature was to act as a killswitch, but this is now handled directly with UKMs.

 

Comment 1 by se...@chromium.org, May 12 2017

Cc: se...@chromium.org csashi@google.com
 Issue 721787  has been merged into this issue.

Comment 2 by ma...@chromium.org, May 12 2017

Labels: M-60
Summary: Remove Autofill UKM logging killswitch (was: Enable Autofill UKM logging)

Comment 4 by se...@chromium.org, May 16 2017

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3573e1fcb10702a8d842cef0ca9ff2825a4c85db

commit 3573e1fcb10702a8d842cef0ca9ff2825a4c85db
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue May 16 18:50:28 2017

Revert of [Autofill] Enable Autofill UKM by default. (patchset #4 id:60001 of https://codereview.chromium.org/2874413004/ )

Reason for revert:
Failing consistently on
chromium.memory/Linux ASan LSan Tests (1)

See  crbug.com/722947 

Original issue's description:
> [Autofill] Enable Autofill UKM by default.
>
> BUG= 718014 
>
> Review-Url: https://codereview.chromium.org/2874413004
> Cr-Commit-Position: refs/heads/master@{#472094}
> Committed: https://chromium.googlesource.com/chromium/src/+/06fc093968064421daf828caf503ef5fafb07cba

TBR=csashi@google.com,mathp@chromium.org,sebsg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 718014 

Review-Url: https://codereview.chromium.org/2888633002
Cr-Commit-Position: refs/heads/master@{#472178}

[modify] https://crrev.com/3573e1fcb10702a8d842cef0ca9ff2825a4c85db/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/3573e1fcb10702a8d842cef0ca9ff2825a4c85db/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/3573e1fcb10702a8d842cef0ca9ff2825a4c85db/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/3573e1fcb10702a8d842cef0ca9ff2825a4c85db/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/3573e1fcb10702a8d842cef0ca9ff2825a4c85db/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/3573e1fcb10702a8d842cef0ca9ff2825a4c85db/components/payments/core/journey_logger.cc
[modify] https://crrev.com/3573e1fcb10702a8d842cef0ca9ff2825a4c85db/components/payments/core/journey_logger_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, May 19 2017

Sign in to add a comment