New issue
Advanced search Search tips

Issue 718011 link

Starred by 1 user
Status: Fixed
Owner:
xiy...@chromium.org
Closed: May 2017
Cc:
msw@chromium.org
alemate@chromium.org
jamescook@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

shelf icons become visible before login UI is completely gone

Project Member Reported by osh...@chromium.org, May 3 2017 
This is on yesterday's ToT (m60) + Caroline.

I'm not sure if this happens on 58/59.

alemate@, can you take a look?

Comment 1 by osh...@chromium.org, May 3 2017

IMG_20170503_063939.jpg
4.3 MB View Download

Comment 2 by alemate@chromium.org, May 4 2017

Cc: jamescook@chromium.org
+jamescook

James, could this be because of some mustash changes?

Comment 3 by jamescook@chromium.org, May 4 2017

Cc: xiy...@chromium.org msw@chromium.org
Labels: OS-Chrome
Hrm. Maybe. Mike - shelf refactors? Xiyuan - session state changes?

Comment 4 by xiy...@chromium.org, May 4 2017

Cc: -xiy...@chromium.org alemate@chromium.org
Owner: xiy...@chromium.org
Likely because of https://codereview.chromium.org/2832053003/. The change that makes WallpaperController to move by observing the session state change instead of explicitly called by LoginDisplayHostImpl. If that is the case, this should only happen in 60.0.3078.0 (or later).

Will take a look.
Project Member

Comment 5 by bugdroid1@chromium.org, May 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6a229fa45aa9c57619d7e8f7bae4abe8351600c

commit e6a229fa45aa9c57619d7e8f7bae4abe8351600c
Author: xiyuan <xiyuan@chromium.org>
Date: Thu May 25 15:04:59 2017

cros: Move wallpaper after login screen is gone

- Make LoginDisplayHost::Finalize to take a callback to
  be invoked just before login screen is dismissed;
- Set ACTIVE session state via the callback so that
  wallpaper is moved to unlock container after login
  screen is gone;
- Add LOGGED_IN_NOT_ACTIVE as another user session blocked
  exception so that initial browser window created in
  this state can be activated;

BUG= 718011 

Review-Url: https://codereview.chromium.org/2891223002
Cr-Commit-Position: refs/heads/master@{#474654}

[modify] https://crrev.com/e6a229fa45aa9c57619d7e8f7bae4abe8351600c/ash/session/session_controller.cc
[modify] https://crrev.com/e6a229fa45aa9c57619d7e8f7bae4abe8351600c/ash/session/session_controller_unittest.cc
[modify] https://crrev.com/e6a229fa45aa9c57619d7e8f7bae4abe8351600c/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[modify] https://crrev.com/e6a229fa45aa9c57619d7e8f7bae4abe8351600c/chrome/browser/chromeos/login/app_launch_controller.cc
[modify] https://crrev.com/e6a229fa45aa9c57619d7e8f7bae4abe8351600c/chrome/browser/chromeos/login/arc_kiosk_controller.cc
[modify] https://crrev.com/e6a229fa45aa9c57619d7e8f7bae4abe8351600c/chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc
[modify] https://crrev.com/e6a229fa45aa9c57619d7e8f7bae4abe8351600c/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
[modify] https://crrev.com/e6a229fa45aa9c57619d7e8f7bae4abe8351600c/chrome/browser/chromeos/login/login_browsertest.cc
[modify] https://crrev.com/e6a229fa45aa9c57619d7e8f7bae4abe8351600c/chrome/browser/chromeos/login/login_manager_test.cc
[modify] https://crrev.com/e6a229fa45aa9c57619d7e8f7bae4abe8351600c/chrome/browser/chromeos/login/oobe_localization_browsertest.cc
[modify] https://crrev.com/e6a229fa45aa9c57619d7e8f7bae4abe8351600c/chrome/browser/chromeos/login/screens/error_screen.cc
[modify] https://crrev.com/e6a229fa45aa9c57619d7e8f7bae4abe8351600c/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/e6a229fa45aa9c57619d7e8f7bae4abe8351600c/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/e6a229fa45aa9c57619d7e8f7bae4abe8351600c/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/e6a229fa45aa9c57619d7e8f7bae4abe8351600c/chrome/browser/chromeos/login/ui/login_display_host_impl.h
[modify] https://crrev.com/e6a229fa45aa9c57619d7e8f7bae4abe8351600c/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/e6a229fa45aa9c57619d7e8f7bae4abe8351600c/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc

Comment 6 by xiy...@chromium.org, May 25 2017

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 12 2017

Labels: merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/358a5df9871e31bdb8ee8b815dba6d3b2a905656

commit 358a5df9871e31bdb8ee8b815dba6d3b2a905656
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Mon Jun 12 19:40:04 2017

Merge "cros: Move wallpaper after login screen is gone"

> - Make LoginDisplayHost::Finalize to take a callback to
>   be invoked just before login screen is dismissed;
> - Set ACTIVE session state via the callback so that
>   wallpaper is moved to unlock container after login
>   screen is gone;
> - Add LOGGED_IN_NOT_ACTIVE as another user session blocked
>   exception so that initial browser window created in
>   this state can be activated;
>
> BUG= 718011 
>
> Review-Url: https://codereview.chromium.org/2891223002
> Cr-Commit-Position: refs/heads/master@{#474654}
> (cherry picked from commit e6a229fa45aa9c57619d7e8f7bae4abe8351600c)

Review-Url: https://codereview.chromium.org/2935623003 .
Cr-Commit-Position: refs/branch-heads/3071@{#778}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/358a5df9871e31bdb8ee8b815dba6d3b2a905656/ash/session/session_controller.cc
[modify] https://crrev.com/358a5df9871e31bdb8ee8b815dba6d3b2a905656/ash/session/session_controller_unittest.cc
[modify] https://crrev.com/358a5df9871e31bdb8ee8b815dba6d3b2a905656/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[modify] https://crrev.com/358a5df9871e31bdb8ee8b815dba6d3b2a905656/chrome/browser/chromeos/login/app_launch_controller.cc
[modify] https://crrev.com/358a5df9871e31bdb8ee8b815dba6d3b2a905656/chrome/browser/chromeos/login/arc_kiosk_controller.cc
[modify] https://crrev.com/358a5df9871e31bdb8ee8b815dba6d3b2a905656/chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc
[modify] https://crrev.com/358a5df9871e31bdb8ee8b815dba6d3b2a905656/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
[modify] https://crrev.com/358a5df9871e31bdb8ee8b815dba6d3b2a905656/chrome/browser/chromeos/login/login_browsertest.cc
[modify] https://crrev.com/358a5df9871e31bdb8ee8b815dba6d3b2a905656/chrome/browser/chromeos/login/login_manager_test.cc
[modify] https://crrev.com/358a5df9871e31bdb8ee8b815dba6d3b2a905656/chrome/browser/chromeos/login/oobe_localization_browsertest.cc
[modify] https://crrev.com/358a5df9871e31bdb8ee8b815dba6d3b2a905656/chrome/browser/chromeos/login/screens/error_screen.cc
[modify] https://crrev.com/358a5df9871e31bdb8ee8b815dba6d3b2a905656/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/358a5df9871e31bdb8ee8b815dba6d3b2a905656/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/358a5df9871e31bdb8ee8b815dba6d3b2a905656/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/358a5df9871e31bdb8ee8b815dba6d3b2a905656/chrome/browser/chromeos/login/ui/login_display_host_impl.h
[modify] https://crrev.com/358a5df9871e31bdb8ee8b815dba6d3b2a905656/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/358a5df9871e31bdb8ee8b815dba6d3b2a905656/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc

Comment 8 by xiy...@chromium.org, Jun 12 2017 

Merged to M59 for  issue 730122 .
►

Sign in to add a comment