Some new types have been defined (vr_shell::Transform and vr::Mat4), but it looks possible to use or upgrade the code in gfx and use it instead.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2c30bb5110a526dc260951ae6e78b6d151f595a commit d2c30bb5110a526dc260951ae6e78b6d151f595a Author: Ian Vollick <vollick@chromium.org> Date: Mon Jun 12 15:39:58 2017 Quaternion::Lerp should return a normalized value This was missed in the patch that introduced the Quaternion. Unittests have been updated to reflect the change (and I've made a minor refactor to avoid so many component-wise comparisons). Bug: 718004 Change-Id: Ife5618aadf33c9908ffa13e3ffabad9ae419fa3e Reviewed-on: https://chromium-review.googlesource.com/530325 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#478634} [modify] https://crrev.com/d2c30bb5110a526dc260951ae6e78b6d151f595a/ui/gfx/geometry/quaternion.cc [modify] https://crrev.com/d2c30bb5110a526dc260951ae6e78b6d151f595a/ui/gfx/geometry/quaternion.h [modify] https://crrev.com/d2c30bb5110a526dc260951ae6e78b6d151f595a/ui/gfx/geometry/quaternion_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bed672a16779591caaaa3f9f3f1814dbfc48fc16 commit bed672a16779591caaaa3f9f3f1814dbfc48fc16 Author: Ian Vollick <vollick@chromium.org> Date: Wed Jun 14 04:00:45 2017 Add Vector3dF::GetNormalized This is a common operation that can fail if the vector is too short. Bug: 718004 Change-Id: I8b379249e3d4b2bc8c500d756899064d8fbb74a5 Reviewed-on: https://chromium-review.googlesource.com/535113 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#479278} [modify] https://crrev.com/bed672a16779591caaaa3f9f3f1814dbfc48fc16/ui/gfx/geometry/vector3d_f.cc [modify] https://crrev.com/bed672a16779591caaaa3f9f3f1814dbfc48fc16/ui/gfx/geometry/vector3d_f.h [modify] https://crrev.com/bed672a16779591caaaa3f9f3f1814dbfc48fc16/ui/gfx/geometry/vector3d_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a25066c9a379ed1ed98830c504986ea2e2363b1b commit a25066c9a379ed1ed98830c504986ea2e2363b1b Author: Ian Vollick <vollick@chromium.org> Date: Wed Jun 14 17:01:56 2017 Convert ElbowModel to gfx types This is one step in the migration away from vr types. I've also introduced some vr <-> gfx conversion routines in vr_math to ease the transition. Bug: 718004 Change-Id: I1bc686f2a9794c46ff4422b4bcea78861678dc39 Reviewed-on: https://chromium-review.googlesource.com/535793 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#479426} [modify] https://crrev.com/a25066c9a379ed1ed98830c504986ea2e2363b1b/chrome/browser/android/vr_shell/DEPS [modify] https://crrev.com/a25066c9a379ed1ed98830c504986ea2e2363b1b/chrome/browser/android/vr_shell/elbow_model.cc [modify] https://crrev.com/a25066c9a379ed1ed98830c504986ea2e2363b1b/chrome/browser/android/vr_shell/elbow_model.h [modify] https://crrev.com/a25066c9a379ed1ed98830c504986ea2e2363b1b/chrome/browser/android/vr_shell/vr_controller.cc [modify] https://crrev.com/a25066c9a379ed1ed98830c504986ea2e2363b1b/device/vr/vr_math.cc [modify] https://crrev.com/a25066c9a379ed1ed98830c504986ea2e2363b1b/device/vr/vr_math.h [modify] https://crrev.com/a25066c9a379ed1ed98830c504986ea2e2363b1b/ui/gfx/geometry/point3_f.h [modify] https://crrev.com/a25066c9a379ed1ed98830c504986ea2e2363b1b/ui/gfx/geometry/vector3d_f.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8a637aba5d330a6d002302e376e4952d5ca4482 commit b8a637aba5d330a6d002302e376e4952d5ca4482 Author: Ian Vollick <vollick@chromium.org> Date: Thu Jun 15 00:46:40 2017 [vr] Convert ui_elements/ to use gfx types This is part of the ongoing migration. In this CL, I also introduce functions to convert between vr::Mat4f and gfx::Transform Bug: 718004 Change-Id: Ib480e6d5cc3bae77b6396ce67ee289d901d01fc6 Reviewed-on: https://chromium-review.googlesource.com/536013 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#479560} [modify] https://crrev.com/b8a637aba5d330a6d002302e376e4952d5ca4482/chrome/browser/android/vr_shell/ui_elements/screen_dimmer.cc [modify] https://crrev.com/b8a637aba5d330a6d002302e376e4952d5ca4482/chrome/browser/android/vr_shell/ui_elements/screen_dimmer.h [modify] https://crrev.com/b8a637aba5d330a6d002302e376e4952d5ca4482/chrome/browser/android/vr_shell/ui_elements/textured_element.cc [modify] https://crrev.com/b8a637aba5d330a6d002302e376e4952d5ca4482/chrome/browser/android/vr_shell/ui_elements/textured_element.h [modify] https://crrev.com/b8a637aba5d330a6d002302e376e4952d5ca4482/chrome/browser/android/vr_shell/ui_elements/ui_element.cc [modify] https://crrev.com/b8a637aba5d330a6d002302e376e4952d5ca4482/chrome/browser/android/vr_shell/ui_elements/ui_element.h [modify] https://crrev.com/b8a637aba5d330a6d002302e376e4952d5ca4482/chrome/browser/android/vr_shell/ui_elements/ui_element_unittest.cc [modify] https://crrev.com/b8a637aba5d330a6d002302e376e4952d5ca4482/chrome/browser/android/vr_shell/ui_scene.cc [modify] https://crrev.com/b8a637aba5d330a6d002302e376e4952d5ca4482/chrome/browser/android/vr_shell/ui_scene_manager.cc [modify] https://crrev.com/b8a637aba5d330a6d002302e376e4952d5ca4482/chrome/browser/android/vr_shell/ui_scene_unittest.cc [modify] https://crrev.com/b8a637aba5d330a6d002302e376e4952d5ca4482/chrome/browser/android/vr_shell/vr_shell_gl.cc [modify] https://crrev.com/b8a637aba5d330a6d002302e376e4952d5ca4482/device/vr/vr_math.cc [modify] https://crrev.com/b8a637aba5d330a6d002302e376e4952d5ca4482/device/vr/vr_math.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/909b2948037f5d7bbc042449cdb9da61f25b15c4 commit 909b2948037f5d7bbc042449cdb9da61f25b15c4 Author: Ian Vollick <vollick@chromium.org> Date: Thu Jun 15 16:34:23 2017 [vr] Convert vr_shell/ to gfx types This is another patch in the migration. The vr_math.h header is still included here and there in vr_shell/ since we must still communicate with device/vr which has not yet been migrated. # Presubmit doesn't like float casts in the shader code, which it thinks is c++ when it isn't. NOPRESUBMIT=true Bug: 718004 Change-Id: I0d4c24288da5df53a6ba87933b8180852dbe4ff0 Reviewed-on: https://chromium-review.googlesource.com/536494 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#479731} [modify] https://crrev.com/909b2948037f5d7bbc042449cdb9da61f25b15c4/chrome/browser/android/vr_shell/ui_element_renderer.h [modify] https://crrev.com/909b2948037f5d7bbc042449cdb9da61f25b15c4/chrome/browser/android/vr_shell/ui_elements/screen_dimmer.cc [modify] https://crrev.com/909b2948037f5d7bbc042449cdb9da61f25b15c4/chrome/browser/android/vr_shell/ui_elements/textured_element.cc [modify] https://crrev.com/909b2948037f5d7bbc042449cdb9da61f25b15c4/chrome/browser/android/vr_shell/ui_scene.cc [modify] https://crrev.com/909b2948037f5d7bbc042449cdb9da61f25b15c4/chrome/browser/android/vr_shell/ui_scene_manager.h [modify] https://crrev.com/909b2948037f5d7bbc042449cdb9da61f25b15c4/chrome/browser/android/vr_shell/ui_scene_unittest.cc [modify] https://crrev.com/909b2948037f5d7bbc042449cdb9da61f25b15c4/chrome/browser/android/vr_shell/vr_controller.cc [modify] https://crrev.com/909b2948037f5d7bbc042449cdb9da61f25b15c4/chrome/browser/android/vr_shell/vr_controller.h [modify] https://crrev.com/909b2948037f5d7bbc042449cdb9da61f25b15c4/chrome/browser/android/vr_shell/vr_gl_util.cc [modify] https://crrev.com/909b2948037f5d7bbc042449cdb9da61f25b15c4/chrome/browser/android/vr_shell/vr_gl_util.h [modify] https://crrev.com/909b2948037f5d7bbc042449cdb9da61f25b15c4/chrome/browser/android/vr_shell/vr_shell_gl.cc [modify] https://crrev.com/909b2948037f5d7bbc042449cdb9da61f25b15c4/chrome/browser/android/vr_shell/vr_shell_gl.h [modify] https://crrev.com/909b2948037f5d7bbc042449cdb9da61f25b15c4/chrome/browser/android/vr_shell/vr_shell_renderer.cc [modify] https://crrev.com/909b2948037f5d7bbc042449cdb9da61f25b15c4/chrome/browser/android/vr_shell/vr_shell_renderer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff0c8647b281db4cb0078a63b69c2156b424a195 commit ff0c8647b281db4cb0078a63b69c2156b424a195 Author: Ian Vollick <vollick@chromium.org> Date: Thu Jun 15 19:42:58 2017 [vr] Convert device/vr to gfx types This is the last step in the migration. After this cl, vr_math* and vr_types.h are no more. Bug: 718004 Change-Id: I3e595eb4ce6ab6ee27123c8510b40ad512985499 Reviewed-on: https://chromium-review.googlesource.com/536475 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#479793} [modify] https://crrev.com/ff0c8647b281db4cb0078a63b69c2156b424a195/chrome/browser/android/vr_shell/BUILD.gn [modify] https://crrev.com/ff0c8647b281db4cb0078a63b69c2156b424a195/chrome/browser/android/vr_shell/vr_controller.cc [modify] https://crrev.com/ff0c8647b281db4cb0078a63b69c2156b424a195/chrome/browser/android/vr_shell/vr_shell_gl.cc [modify] https://crrev.com/ff0c8647b281db4cb0078a63b69c2156b424a195/device/vr/BUILD.gn [modify] https://crrev.com/ff0c8647b281db4cb0078a63b69c2156b424a195/device/vr/android/gvr/cardboard_gamepad_data_fetcher.cc [modify] https://crrev.com/ff0c8647b281db4cb0078a63b69c2156b424a195/device/vr/android/gvr/cardboard_gamepad_data_provider.h [modify] https://crrev.com/ff0c8647b281db4cb0078a63b69c2156b424a195/device/vr/android/gvr/gvr_delegate.cc [modify] https://crrev.com/ff0c8647b281db4cb0078a63b69c2156b424a195/device/vr/android/gvr/gvr_delegate.h [modify] https://crrev.com/ff0c8647b281db4cb0078a63b69c2156b424a195/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/ff0c8647b281db4cb0078a63b69c2156b424a195/device/vr/android/gvr/gvr_gamepad_data_fetcher.cc [modify] https://crrev.com/ff0c8647b281db4cb0078a63b69c2156b424a195/device/vr/android/gvr/gvr_gamepad_data_provider.h [delete] https://crrev.com/20f9c9aa8d11c3c84921177a56513f6ec751d059/device/vr/vr_math.cc [delete] https://crrev.com/20f9c9aa8d11c3c84921177a56513f6ec751d059/device/vr/vr_math.h [delete] https://crrev.com/20f9c9aa8d11c3c84921177a56513f6ec751d059/device/vr/vr_types.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c7f6df48120d44213fabf09fb6b6b0cfe0c5f27 commit 0c7f6df48120d44213fabf09fb6b6b0cfe0c5f27 Author: Ian Vollick <vollick@chromium.org> Date: Fri Jun 16 02:38:04 2017 [vr] Remove vr_shell::Transform This class is now just a bit of sugar around gfx::Transform. With this patch, we use the wrapped class directly. Bug: 718004 Change-Id: I0fe6b998d084af315af990b7b7443eb027f86a45 Reviewed-on: https://chromium-review.googlesource.com/536496 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#479929} [modify] https://crrev.com/0c7f6df48120d44213fabf09fb6b6b0cfe0c5f27/chrome/browser/android/vr_shell/ui_elements/ui_element.cc [modify] https://crrev.com/0c7f6df48120d44213fabf09fb6b6b0cfe0c5f27/chrome/browser/android/vr_shell/ui_elements/ui_element.h [modify] https://crrev.com/0c7f6df48120d44213fabf09fb6b6b0cfe0c5f27/chrome/browser/android/vr_shell/ui_scene.cc [modify] https://crrev.com/0c7f6df48120d44213fabf09fb6b6b0cfe0c5f27/chrome/browser/android/vr_shell/ui_scene_unittest.cc [modify] https://crrev.com/0c7f6df48120d44213fabf09fb6b6b0cfe0c5f27/chrome/browser/android/vr_shell/vr_shell_gl.cc
Comment 1 by ddorwin@chromium.org
, May 3 2017