New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717959 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 711146



Sign in to add a comment

RendererSettings::disable_display_vsync should be a state of GpuProcessTransportFactory

Project Member Reported by staraz@chromium.org, May 3 2017

Issue description

disable_display_vsync is set based on command line switches and is read
only in GpuProcessTransportFactory. Renderers don't use this value so it
shouldn't be in RendererSettings.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60f32e2dc84431ea6131e760fd5480b415aff5e8

commit 60f32e2dc84431ea6131e760fd5480b415aff5e8
Author: staraz <staraz@chromium.org>
Date: Thu May 04 20:04:53 2017

Move disable_display_vsync out of RendererSettings

disable_display_vsync is read by GpuProcessTransportFactory and
TestCompositorFrameSink only. It is not used by Renderers so it should not be
in RendererSettings.

GpuProcessTransportFactory gets disable_display_vsync from command line switch
and stores it in disable_display_vsync_.

LayerTreeTest and its subclasses pass disable_display_vsync in to
TestCompositorFrameSink via its constructor. LayerTreeHostPerfTest overrides
LayerTreeTest::CreateCompositorFrameSink to set disable_display_vsync to true
to preserve behaviors.

BUG= 717959 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2854953006
Cr-Commit-Position: refs/heads/master@{#469439}

[modify] https://crrev.com/60f32e2dc84431ea6131e760fd5480b415aff5e8/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/60f32e2dc84431ea6131e760fd5480b415aff5e8/cc/output/renderer_settings.h
[modify] https://crrev.com/60f32e2dc84431ea6131e760fd5480b415aff5e8/cc/test/layer_tree_pixel_test.cc
[modify] https://crrev.com/60f32e2dc84431ea6131e760fd5480b415aff5e8/cc/test/layer_tree_test.cc
[modify] https://crrev.com/60f32e2dc84431ea6131e760fd5480b415aff5e8/cc/test/test_compositor_frame_sink.cc
[modify] https://crrev.com/60f32e2dc84431ea6131e760fd5480b415aff5e8/cc/test/test_compositor_frame_sink.h
[modify] https://crrev.com/60f32e2dc84431ea6131e760fd5480b415aff5e8/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/60f32e2dc84431ea6131e760fd5480b415aff5e8/cc/trees/layer_tree_host_perftest.cc
[modify] https://crrev.com/60f32e2dc84431ea6131e760fd5480b415aff5e8/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/60f32e2dc84431ea6131e760fd5480b415aff5e8/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/60f32e2dc84431ea6131e760fd5480b415aff5e8/content/browser/compositor/gpu_process_transport_factory.h
[modify] https://crrev.com/60f32e2dc84431ea6131e760fd5480b415aff5e8/content/test/layouttest_support.cc
[modify] https://crrev.com/60f32e2dc84431ea6131e760fd5480b415aff5e8/ui/compositor/compositor.cc

Status: Fixed (was: Assigned)

Sign in to add a comment