New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 717953 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: May 2017
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Show desktop shortcut' toggle button is misplaced

Reported by sans...@etouch.net, May 3 2017 
Chrome Version: 60.0.3088.0 (Official Build) 0ea8510a570b6556ea40679bb03b64a5fdcc7550-refs/heads/master@{#468845} (32/64-bit) 
OS: Windows (7,8,8.1,10)

Steps:
1. Launch Chrome and add one more person from switch person overlay
2. Navigate to chrome://settings, click on Person name and observe

Actual: 'Show desktop shortcut' toggle button is misplaced

Expected: 'Show desktop shortcut' toggle button should be seen properly

This is a regression issue broken in 'M60' and will soon update the bisect info

Good Build: 60.0.3081.0
Bad Build:  60.0.3082.0

Note: This is Windows OS specific issue, not seen on Mac and Linux OS
Actual_Expected_result.jpg
90.7 KB View Download

Comment 1 by sans...@etouch.net, May 3 2017

Labels: Proj-MaterialDesign-WebUI
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Providing changelog url as 'Show desktop shortcut' toggle button is not seen for Chromium builds

Changelog url:
https://chromium.googlesource.com/chromium/src/+log/60.0.3081.0..60.0.3082.0?pretty=fuller&n=10000

Suspecting: r467529 ?

Please help to re-assign if your change is not the cause for this issue.

Comment 2 by dpa...@chromium.org, May 3 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4540741c764a85583b0ea02a1d533f43c70afedd

commit 4540741c764a85583b0ea02a1d533f43c70afedd
Author: dpapad <dpapad@chromium.org>
Date: Wed May 03 21:18:04 2017

MD Settings: Fix "show desktop shortcut" spacing, after removing iron-flex-layout.html.

BUG= 717953 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2862543004
Cr-Commit-Position: refs/heads/master@{#469128}

[modify] https://crrev.com/4540741c764a85583b0ea02a1d533f43c70afedd/chrome/browser/resources/settings/people_page/manage_profile.html

Comment 4 by dpa...@chromium.org, May 3 2017

Status: Fixed (was: Started)
►

Sign in to add a comment