New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717945 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Public Session whitelisting - Restrict activeTab permission for use in PS

Project Member Reported by isandrk@chromium.org, May 3 2017

Issue description

In Public Sessions, apps and extensions are force-installed by admin policy so the user does not get a chance to review the permissions for these apps. This is not acceptable from a security standpoint, so we:

- show a permission prompt the first time an extension tries to use activeTab permission;
- scrub the URL available to chrome.tabs.executeScript context down to the origin.


 
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1296202771665ed3ecd53b31c16391258933cb08

commit 1296202771665ed3ecd53b31c16391258933cb08
Author: isandrk <isandrk@chromium.org>
Date: Thu May 04 15:27:33 2017

PS - Filtering activeTab URL

In Public Sessions, apps and extensions are force-installed by admin policy so the user does not get a chance to review the permissions for these apps. This is not acceptable from a security standpoint, so we:
- scrub the URL available to chrome.tabs.executeScript context (through activeTab permission) down to the origin.

This change also causes the tab object passed to the [page|browser]Action.onClicked to be scrubbed for the given extension.

TEST=
  unit_tests --gtest_filter=DeviceLocalAccountManagementPolicyProviderTest.IsWhitelisted
  unit_tests --gtest_filter=ExtensionTabUtilDelegateChromeOSTest.*
  unit_tests --gtest_filter=ExtensionTabUtilTest.Delegate

BUG= 717945 

Review-Url: https://codereview.chromium.org/2858643002
Cr-Commit-Position: refs/heads/master@{#469342}

[modify] https://crrev.com/1296202771665ed3ecd53b31c16391258933cb08/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
[modify] https://crrev.com/1296202771665ed3ecd53b31c16391258933cb08/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.h
[modify] https://crrev.com/1296202771665ed3ecd53b31c16391258933cb08/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
[modify] https://crrev.com/1296202771665ed3ecd53b31c16391258933cb08/chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos.cc
[modify] https://crrev.com/1296202771665ed3ecd53b31c16391258933cb08/chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos.h
[modify] https://crrev.com/1296202771665ed3ecd53b31c16391258933cb08/chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos_unittest.cc
[modify] https://crrev.com/1296202771665ed3ecd53b31c16391258933cb08/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos.cc
[modify] https://crrev.com/1296202771665ed3ecd53b31c16391258933cb08/chrome/browser/extensions/api/extension_action/extension_action_api.cc
[modify] https://crrev.com/1296202771665ed3ecd53b31c16391258933cb08/chrome/browser/extensions/api/extension_action/extension_action_api.h
[modify] https://crrev.com/1296202771665ed3ecd53b31c16391258933cb08/chrome/browser/extensions/extension_action_runner.cc
[modify] https://crrev.com/1296202771665ed3ecd53b31c16391258933cb08/chrome/browser/extensions/native_bindings_apitest.cc
[modify] https://crrev.com/1296202771665ed3ecd53b31c16391258933cb08/chromeos/BUILD.gn
[add] https://crrev.com/1296202771665ed3ecd53b31c16391258933cb08/chromeos/login/scoped_test_public_session_login_state.cc
[add] https://crrev.com/1296202771665ed3ecd53b31c16391258933cb08/chromeos/login/scoped_test_public_session_login_state.h

Components: Privacy
Project Member

Comment 3 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98a3e4a19ea5cbfe16f3486b14e458df441c394f

commit 98a3e4a19ea5cbfe16f3486b14e458df441c394f
Author: isandrk <isandrk@chromium.org>
Date: Fri May 26 21:14:50 2017

PS - Showing permission prompt for activeTab

In Public Sessions, apps and extensions are force-installed by admin policy so the user does not get a chance to review the permissions for these apps. This is not acceptable from a security standpoint, so we:
- show a permission prompt the first time an extension tries to use activeTab permission (and deny that first request).

BUG= 717945 

Review-Url: https://codereview.chromium.org/2858013002
Cr-Commit-Position: refs/heads/master@{#475128}

[modify] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/chrome/app/generated_resources.grd
[modify] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/chrome/browser/chromeos/BUILD.gn
[add] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos.cc
[add] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos.h
[add] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc
[modify] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
[modify] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/chrome/browser/chromeos/extensions/public_session_permission_helper.cc
[modify] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/chrome/browser/chromeos/extensions/public_session_permission_helper.h
[modify] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/chrome/browser/chromeos/extensions/public_session_permission_helper_unittest.cc
[modify] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/chrome/browser/extensions/active_tab_permission_granter.cc
[modify] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/chrome/browser/extensions/active_tab_permission_granter.h
[modify] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/chrome/browser/extensions/active_tab_unittest.cc
[modify] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/chrome/browser/extensions/extension_install_prompt.cc
[modify] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/chrome/browser/extensions/extension_install_prompt.h
[modify] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
[modify] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc
[modify] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/components/user_manager/user.h
[modify] https://crrev.com/98a3e4a19ea5cbfe16f3486b14e458df441c394f/components/user_manager/user_manager_base.h

Project Member

Comment 4 by bugdroid1@chromium.org, May 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a178ffe803c79a0f8a44750c67f17c3cde5a9d6

commit 3a178ffe803c79a0f8a44750c67f17c3cde5a9d6
Author: thestig <thestig@chromium.org>
Date: Sat May 27 02:05:16 2017

Fix new/free mismatch in ActiveTabTest.DelegateIsSet

As found by ASAN. The error is from r475128.

BUG= 717945 
TBR=isandrk@chromium.org

Review-Url: https://codereview.chromium.org/2907953002
Cr-Commit-Position: refs/heads/master@{#475218}

[modify] https://crrev.com/3a178ffe803c79a0f8a44750c67f17c3cde5a9d6/chrome/browser/extensions/active_tab_unittest.cc

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment