New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717935 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in approx_log2

Project Member Reported by ClusterFuzz, May 3 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5181047238295552

Fuzzer: libfuzzer_skia_color_space_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  approx_log2
  approx_powf
  parametric
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=468569:468582

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5181047238295552


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, May 3 2017

Labels: M-60
Project Member

Comment 2 by sheriffbot@chromium.org, May 3 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, May 3 2017

Labels: Pri-1
Components: Internals>Skia
Owner: msarett@chromium.org
Status: Assigned (was: Untriaged)
msarett, could you please take a look, or help get this assigned to the right person? thanks!
Project Member

Comment 5 by sheriffbot@chromium.org, May 4 2017

Labels: M-60
Cc: mtklein@chromium.org
If it's approx_log2() yelling, that's uninitialized color data.  Gamma never goes through approx_log2().  From the stack, it looks like the green channel.  

#6 0x73d82d in sk_callback ... could only be a color lookup table.  Think we looked up a bad green?
Yeah sorry, this is the fix:
https://skia-review.googlesource.com/c/15301/

Was CCing you for context.
Status: Fixed (was: Assigned)
Project Member

Comment 11 by ClusterFuzz, May 6 2017

ClusterFuzz has detected this issue as fixed in range 469678:469725.

Detailed report: https://clusterfuzz.com/testcase?key=5181047238295552

Fuzzer: libfuzzer_skia_color_space_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  approx_log2
  approx_powf
  parametric
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=468569:468582
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=469678:469725

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5181047238295552


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by sheriffbot@chromium.org, May 6 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Beta
Project Member

Comment 14 by sheriffbot@chromium.org, Aug 12 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment