Fix PolicyLoadStatusSample memory leak |
|||||
Issue descriptionShows up in asan tests. https://build.chromium.org/p/chromiumos/builders/amd64-generic-asan/builds/19641/steps/UnitTest/logs/stdio authpolicy-0.0.1-r349: * Direct leak of 224 byte(s) in 2 object(s) allocated from: authpolicy-0.0.1-r349: * #0 0x7f269146a980 in operator new(unsigned long) (/var/cache/portage/chromeos-base/authpolicy/out/Default/authpolicy_test+0x487980) authpolicy-0.0.1-r349: * #1 0x7f2690eb8470 in base::LinearHistogram::Factory::HeapAlloc(base::BucketRanges const*) (/usr/lib64/libbase-core-395517.so+0xbf470) authpolicy-0.0.1-r349: * #2 0x7f2690eb4066 in base::Histogram::Factory::Build() (/usr/lib64/libbase-core-395517.so+0xbb066) authpolicy-0.0.1-r349: * #3 0x7f2690eb69d8 in base::LinearHistogram::FactoryGetWithRangeDescription(std::string const&, int, int, unsigned int, int, base::LinearHistogram::DescriptionPair const*) (/usr/lib64/libbase-core-395517.so+0xbd9d8) authpolicy-0.0.1-r349: * #4 0x7f2690eb6ad4 in base::LinearHistogram::FactoryGet(char const*, int, int, unsigned int, int) (/usr/lib64/libbase-core-395517.so+0xbdad4) authpolicy-0.0.1-r349: * #5 0x7f2690df2f90 in policy::PolicyLoadStatusSample::PolicyLoadStatusSample() (/usr/lib64/libbase-policy-395517.so+0x2f90) authpolicy-0.0.1-r349: * #6 0x7f26915ae455 in policy::helper::LoadPRegFile(base::FilePath const&, policy::RegistryDict*) /build/amd64-generic/var/cache/portage/chromeos-base/authpolicy/out/Default/../../../../../../../../../mnt/host/source/src/platform2/authpolicy/policy/policy_encoder_helper.cc:69:26 authpolicy-0.0.1-r349: * #7 0x7f26915b0606 in policy::ParsePRegFilesIntoDevicePolicy(std::vector<base::FilePath, std::allocator<base::FilePath> > const&, enterprise_management::ChromeDeviceSettingsProto*) /build/amd64-generic/var/cache/portage/chromeos-base/authpolicy/out/Default/../../../../../../../../../mnt/host/source/src/platform2/authpolicy/policy/preg_policy_encoder.cc:64:10 authpolicy-0.0.1-r349: * #8 0x7f2691510462 in policy::PregPolicyEncoderTest_DevicePolicyFileOverride_Test::TestBody() /build/amd64-generic/var/cache/portage/chromeos-base/authpolicy/out/Default/../../../../../../../../../mnt/host/source/src/platform2/authpolicy/policy/preg_policy_encoder_unittest.cc:239:3 authpolicy-0.0.1-r349: * #9 0x7f2690fc0bef in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:2078:10 authpolicy-0.0.1-r349: * #10 0x7f2690fc0bef in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:2114 authpolicy-0.0.1-r349: * #11 0x7f2690fa2111 in testing::Test::Run() /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:2150:5 authpolicy-0.0.1-r349: * #12 0x7f2690fa3510 in testing::TestInfo::Run() /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:2326:11 authpolicy-0.0.1-r349: * #13 0x7f2690fa3d56 in testing::TestCase::Run() /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:2444:28 authpolicy-0.0.1-r349: * #14 0x7f2690fad4c6 in testing::internal::UnitTestImpl::RunAllTests() /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:4315:43 authpolicy-0.0.1-r349: * #15 0x7f2690fc18af in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:2078:10 authpolicy-0.0.1-r349: * #16 0x7f2690fc18af in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:2114 authpolicy-0.0.1-r349: * #17 0x7f2690fad081 in testing::UnitTest::Run() /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:3926:10 authpolicy-0.0.1-r349: * #18 0x7f269146ed05 in RUN_ALL_TESTS() /build/amd64-generic/var/cache/portage/chromeos-base/authpolicy/out/Default/../../../../../../../usr/include/gtest/gtest.h:2288:46 authpolicy-0.0.1-r349: * #19 0x7f269146ed05 in main /build/amd64-generic/var/cache/portage/chromeos-base/authpolicy/out/Default/../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_testrunner.cc:11 authpolicy-0.0.1-r349: * #20 0x7f268f62a815 in __libc_start_main /var/tmp/portage/cross-x86_64-cros-linux-gnu/glibc-2.23-r4/work/glibc-2.23/csu/../csu/libc-start.c:289 authpolicy-0.0.1-r349: * #21 0x7f269136a5c8 in _start (/var/cache/portage/chromeos-base/authpolicy/out/Default/authpolicy_test+0x3875c8)
,
May 10 2017
gardener here Is this really fixed? I'm still seeing the error: https://build.chromium.org/p/chromiumos.chromium/builders/amd64-generic-tot-asan-informational/builds/12996 authpolicy-0.0.1-r359: Error: /var/cache/portage/chromeos-base/authpolicy/out/Default/authpolicy_test: failed with exit code 1 authpolicy-0.0.1-r359: Error: the test leaked process llvm-symbolizer with pid 1044 (it was forcefully killed) authpolicy-0.0.1-r359: * ERROR: chromeos-base/authpolicy-0.0.1-r359::chromiumos failed (test phase): authpolicy-0.0.1-r359: * (no error message) authpolicy-0.0.1-r359: * authpolicy-0.0.1-r359: * Call stack: authpolicy-0.0.1-r359: * ebuild.sh, line 93: Called src_test authpolicy-0.0.1-r359: * environment, line 3955: Called platform_src_test authpolicy-0.0.1-r359: * environment, line 3549: Called platform_pkg_test authpolicy-0.0.1-r359: * environment, line 3531: Called platform_test 'run' '/build/amd64-generic/var/cache/portage/chromeos-base/authpolicy/out/Default/authpolicy_test' authpolicy-0.0.1-r359: * environment, line 3582: Called die authpolicy-0.0.1-r359: * The specific snippet of code: authpolicy-0.0.1-r359: * "${cmd[@]}" || die authpolicy-0.0.1-r359: * authpolicy-0.0.1-r359: * If you need support, post the output of `emerge --info '=chromeos-base/authpolicy-0.0.1-r359::chromiumos'`, authpolicy-0.0.1-r359: * the complete build log and the output of `emerge -pqv '=chromeos-base/authpolicy-0.0.1-r359::chromiumos'`. authpolicy-0.0.1-r359: authpolicy-0.0.1-r359: * ASAN error detected: authpolicy-0.0.1-r359: * authpolicy-0.0.1-r359: * ================================================================= authpolicy-0.0.1-r359: * ==17==ERROR: LeakSanitizer: detected memory leaks authpolicy-0.0.1-r359: * authpolicy-0.0.1-r359: * Direct leak of 896 byte(s) in 8 object(s) allocated from: authpolicy-0.0.1-r359: * #0 0x7f363efdfea0 in operator new(unsigned long) (/var/cache/portage/chromeos-base/authpolicy/out/Default/authpolicy_test+0x485ea0) authpolicy-0.0.1-r359: * #1 0x7f363ea2e470 in base::LinearHistogram::Factory::HeapAlloc(base::BucketRanges const*) /build/amd64-generic/tmp/portage/chromeos-base/libchrome-395517-r9/work/libchrome-395517/base/metrics/histogram.cc:759:9 authpolicy-0.0.1-r359: * #2 0x7f363ea2a066 in base::Histogram::Factory::Build() /build/amd64-generic/tmp/portage/chromeos-base/libchrome-395517-r9/work/libchrome-395517/base/metrics/histogram.cc:194:29 authpolicy-0.0.1-r359: * #3 0x7f363ea2c9d8 in base::LinearHistogram::FactoryGetWithRangeDescription(std::string const&, int, int, unsigned int, int, base::LinearHistogram::DescriptionPair const*) /build/amd64-generic/tmp/portage/chromeos-base/libchrome-395517-r9/work/libchrome-395517/base/metrics/histogram.cc:845:8 authpolicy-0.0.1-r359: * #4 0x7f363ea2cad4 in base::LinearHistogram::FactoryGet(std::string const&, int, int, unsigned int, int) /build/amd64-generic/tmp/portage/chromeos-base/libchrome-395517-r9/work/libchrome-395517/base/metrics/histogram.cc:787:10 authpolicy-0.0.1-r359: * #5 0x7f363ea2cad4 in base::LinearHistogram::FactoryGet(char const*, int, int, unsigned int, int) /build/amd64-generic/tmp/portage/chromeos-base/libchrome-395517-r9/work/libchrome-395517/base/metrics/histogram.cc:806 authpolicy-0.0.1-r359: * #6 0x7f363e968f90 in policy::PolicyLoadStatusSample::PolicyLoadStatusSample() /build/amd64-generic/tmp/portage/chromeos-base/libchrome-395517-r9/work/libchrome-395517/components/policy/core/common/policy_load_status.cc:20:18 authpolicy-0.0.1-r359: * #7 0x7f363f11a145 in policy::helper::LoadPRegFile(base::FilePath const&, policy::RegistryDict*) /build/amd64-generic/var/cache/portage/chromeos-base/authpolicy/out/Default/../../../../../../../../../mnt/host/source/src/platform2/authpolicy/policy/policy_encoder_helper.cc:69:26 authpolicy-0.0.1-r359: * #8 0x7f363f11bca3 in policy::ParsePRegFilesIntoUserPolicy(std::vector<base::FilePath, std::allocator<base::FilePath> > const&, enterprise_management::CloudPolicySettings*) /build/amd64-generic/var/cache/portage/chromeos-base/authpolicy/out/Default/../../../../../../../../../mnt/host/source/src/platform2/authpolicy/policy/preg_policy_encoder.cc:33:10 authpolicy-0.0.1-r359: * #9 0x7f363f07dbdf in policy::PregPolicyEncoderTest::TestUserPolicyFileOverride(policy::PolicyLevel, policy::PolicyLevel, policy::PregPolicyEncoderTest::WhoWins) /build/amd64-generic/var/cache/portage/chromeos-base/authpolicy/out/Default/../../../../../../../../../mnt/host/source/src/platform2/authpolicy/policy/preg_policy_encoder_unittest.cc:92:5 authpolicy-0.0.1-r359: * #10 0x7f363eb36bef in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:2078:10 authpolicy-0.0.1-r359: * #11 0x7f363eb36bef in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:2114 authpolicy-0.0.1-r359: * #12 0x7f363eb18111 in testing::Test::Run() /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:2150:5 authpolicy-0.0.1-r359: * #13 0x7f363eb19510 in testing::TestInfo::Run() /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:2326:11 authpolicy-0.0.1-r359: * #14 0x7f363eb19d56 in testing::TestCase::Run() /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:2444:28 authpolicy-0.0.1-r359: * #15 0x7f363eb234c6 in testing::internal::UnitTestImpl::RunAllTests() /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:4315:43 authpolicy-0.0.1-r359: * #16 0x7f363eb378af in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:2078:10 authpolicy-0.0.1-r359: * #17 0x7f363eb378af in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:2114 authpolicy-0.0.1-r359: * #18 0x7f363eb23081 in testing::UnitTest::Run() /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.7.0/work/gtest-1.7.0-abi_x86_64.amd64/./src/gtest.cc:3926:10 authpolicy-0.0.1-r359: * #19 0x7f363efe4225 in RUN_ALL_TESTS() /build/amd64-generic/var/cache/portage/chromeos-base/authpolicy/out/Default/../../../../../../../usr/include/gtest/gtest.h:2288:46 authpolicy-0.0.1-r359: * #20 0x7f363efe4225 in main /build/amd64-generic/var/cache/portage/chromeos-base/authpolicy/out/Default/../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_testrunner.cc:11 authpolicy-0.0.1-r359: * #21 0x7f363d1a1815 in __libc_start_main /var/tmp/portage/cross-x86_64-cros-linux-gnu/glibc-2.23-r6/work/glibc-2.23/csu/../csu/libc-start.c:289 authpolicy-0.0.1-r359: * #22 0x7f363eedfae8 in _start (/var/cache/portage/chromeos-base/authpolicy/out/Default/authpolicy_test+0x385ae8)
,
May 10 2017
This is 1/3 of the fix. The other two CLs https://chromium-review.googlesource.com/c/497434/ and https://chromium-review.googlesource.com/c/496128/ have been stuck in the CQ for 36 hours.
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/external/libchrome/+/5943df7448213fdf373bda6270044e1e79a88d2f commit 5943df7448213fdf373bda6270044e1e79a88d2f Author: Lutz Justen <ljusten@chromium.org> Date: Thu May 11 16:40:29 2017 Cherry-pick "Allow PolicyLoadStatusSample to override reporting method" Revision in chromium/src: 6410def39290ed829e0d56b92ab03ddd985a0c04 This cherry-pick is required to fix a memory leak in Chrome OS. PolicyLoadStatusSample reports stats to base::LinearHistogram by default, which does not work in Chrome OS. This CL introduces PolicyLoadStatusSampler, which just gathers samples without doing anything with them and can be used in preg_parser. BUG= chromium:717888 TEST=Compiles. Change-Id: I8cbac293fc6c24ee97dc514d631612a0debbd162 Reviewed-on: https://chromium-review.googlesource.com/497433 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/5943df7448213fdf373bda6270044e1e79a88d2f/components/policy/core/common/preg_parser_unittest.cc [modify] https://crrev.com/5943df7448213fdf373bda6270044e1e79a88d2f/components/policy/core/common/preg_parser.cc [modify] https://crrev.com/5943df7448213fdf373bda6270044e1e79a88d2f/components/policy/core/common/preg_parser.h [modify] https://crrev.com/5943df7448213fdf373bda6270044e1e79a88d2f/components/policy/core/common/policy_load_status.h [modify] https://crrev.com/5943df7448213fdf373bda6270044e1e79a88d2f/components/policy/core/common/policy_load_status.cc
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/external/libchrome/+/5943df7448213fdf373bda6270044e1e79a88d2f commit 5943df7448213fdf373bda6270044e1e79a88d2f Author: Lutz Justen <ljusten@chromium.org> Date: Thu May 11 16:40:29 2017 Cherry-pick "Allow PolicyLoadStatusSample to override reporting method" Revision in chromium/src: 6410def39290ed829e0d56b92ab03ddd985a0c04 This cherry-pick is required to fix a memory leak in Chrome OS. PolicyLoadStatusSample reports stats to base::LinearHistogram by default, which does not work in Chrome OS. This CL introduces PolicyLoadStatusSampler, which just gathers samples without doing anything with them and can be used in preg_parser. BUG= chromium:717888 TEST=Compiles. Change-Id: I8cbac293fc6c24ee97dc514d631612a0debbd162 Reviewed-on: https://chromium-review.googlesource.com/497433 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/5943df7448213fdf373bda6270044e1e79a88d2f/components/policy/core/common/preg_parser_unittest.cc [modify] https://crrev.com/5943df7448213fdf373bda6270044e1e79a88d2f/components/policy/core/common/preg_parser.cc [modify] https://crrev.com/5943df7448213fdf373bda6270044e1e79a88d2f/components/policy/core/common/preg_parser.h [modify] https://crrev.com/5943df7448213fdf373bda6270044e1e79a88d2f/components/policy/core/common/policy_load_status.h [modify] https://crrev.com/5943df7448213fdf373bda6270044e1e79a88d2f/components/policy/core/common/policy_load_status.cc
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e887363a656ed279fa31a3fbb49d375fe2675279 commit e887363a656ed279fa31a3fbb49d375fe2675279 Author: Lutz Justen <ljusten@chromium.org> Date: Thu May 11 16:40:24 2017 Add patch for "Allow PolicyLoadStatusSample to override reporting method" Revision in chromium/src: 6410def39290ed829e0d56b92ab03ddd985a0c04 Adds a patch that cherry-picks a CL required to fix a memory leak in Chrome OS. PolicyLoadStatusSample reports stats to LinearHistogram by default, which does not work in Chrome OS. This CL introduces a base class which just gathers samples without doing anything with them and can be used in preg_parser. Adds a patch to the ebuild instead of uprev'ing it because libchrome has been uprev'ed to the latest and greatest in revision c3f34a3e, but that change hasn't been picked up by the ebuild yet. The patch is an intermediate solution. When the ebuild is uprev'ed to the latest libchrome revision, the change is picked up from a similar commit to libchrome (CL:497433). CQ-DEPEND=CL:496128 BUG= chromium:717888 TEST=Compiles. Change-Id: I8cbac293fc6c24ee97dc514d631612a0debbd162 Reviewed-on: https://chromium-review.googlesource.com/497434 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [add] https://crrev.com/e887363a656ed279fa31a3fbb49d375fe2675279/chromeos-base/libchrome/files/libchrome-395517-preg_leak_fix.patch [modify] https://crrev.com/e887363a656ed279fa31a3fbb49d375fe2675279/chromeos-base/libchrome/libchrome-395517.ebuild [rename] https://crrev.com/e887363a656ed279fa31a3fbb49d375fe2675279/chromeos-base/libchrome/libchrome-395517-r10.ebuild
,
May 13 2017
jamescook@, please try again. It should be fixed now.
,
May 15 2017
+ahmed, this week's gardener. The ASAN bot is still red, but it looks like a compile failure. If you have time, can you check to see if it goes green? https://build.chromium.org/p/chromiumos.chromium/builders/amd64-generic-tot-asan-informational
,
Jul 6 2017
bulk Verify of older or not-user-facing Chromad bugs |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, May 5 2017