New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 717882 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: May 2017
Cc:
pdr@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
chrishtr@chromium.org
vmp...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Inner circle of radio button under 'on startup' section appears to be misplaced.

Reported by vku...@etouch.net, May 3 2017 
Chrome Version: 60.0.3088.0 (Official Build) 0ea8510a570b6556ea40679bb03b64a5fdcc7550-refs/heads/master@{#468845} (32/64-bit) 
OS: Windows (7,8,8.1,10),Mac OS X(10.11.6,10.12.1)

What steps will reproduce the problem?
(1)Launch chrome and navigate chrome://md-settings/
(2)Scroll down and observe the radio button under "On Startup"
(3)Click on other radio button, observe inner circle.

Actual: Inner circle of radio button under 'on startup' section appears to be misplaced.

Expected: Inner circle of radio button under 'on startup' section should be properly displayed.

This is a regression issue broken in 'M60' and below is the manual regression range
Good Build: 60.0.3087.0
Bad Build:  60.0.3088.0

Note: Will soon update Linux info
Actual_Button.mov
1.2 MB Download
Expected_Button.mov
876 KB Download

Comment 1 by rbasuvula@chromium.org, May 3 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision OS-Linux
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:60.0.3087.0 (Revision:468507).
Bad build:60.0.3088.0 (Revision:468845).

You are probably looking for a change made after 468515 (known good), but no later than 468516 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/2915191f0a64f34fcdf8c4e4a0a5d89b2271d816..098430b33423191b06dc32f13de764076cf60394

From the CL above, assigning the issue to the concern owner

@wangxianzhu: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:https://codereview.chromium.org/2847873002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #60.0.3088.0

Comment 2 by wangxianzhu@chromium.org, May 3 2017

Cc: chrishtr@chromium.org pdr@chromium.org
Components: Blink>Paint
This is a side-effect of not passing subpixels through transforms. I'm reverting the CL and updating  bug 716163  for all subpixel accumulation through transforms.
Project Member

Comment 3 by bugdroid1@chromium.org, May 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/763e91015ba203feaa3b27c77ce4aa52638ec6e4

commit 763e91015ba203feaa3b27c77ce4aa52638ec6e4
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Wed May 03 18:54:10 2017

Revert of Don't pass subpixel offsets through non-translation transforms (patchset #7 id:120001 of https://codereview.chromium.org/2847873002/ )

Reason for revert:
BUG= 717882 

Original issue's description:
> Don't pass subpixel offsets through non-translation transforms
>
> Non-translation transforms will change direction and/or scale, etc.
> of offsets thus making subpixel accumulation through the transform
> meaningless.
>
> This CL addresses the issue in PaintLayerPainter and
> PaintPropertyTreeBuilder. We still need to address the issue in
> CompositedLayerMapping ( crbug.com/716163 ).
>
> BUG= 710665 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2847873002
> Cr-Commit-Position: refs/heads/master@{#468516}
> Committed: https://chromium.googlesource.com/chromium/src/+/098430b33423191b06dc32f13de764076cf60394

TBR=chrishtr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 710665 

Review-Url: https://codereview.chromium.org/2859483004
Cr-Commit-Position: refs/heads/master@{#469054}

[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/fast/sub-pixel/sub-pixel-root-layer.html
[delete] https://crrev.com/e16cd1440c94c183b042fdd1c38a76138878a17b/third_party/WebKit/LayoutTests/paint/invalidation/subpixel-offset-scaled-transform-expected.png
[delete] https://crrev.com/e16cd1440c94c183b042fdd1c38a76138878a17b/third_party/WebKit/LayoutTests/paint/invalidation/subpixel-offset-scaled-transform-expected.txt
[delete] https://crrev.com/e16cd1440c94c183b042fdd1c38a76138878a17b/third_party/WebKit/LayoutTests/paint/invalidation/subpixel-offset-scaled-transform.html
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/linux/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/linux/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/linux/svg/transforms/svg-css-transforms-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/linux/transforms/svg-vs-css-expected.png
[delete] https://crrev.com/e16cd1440c94c183b042fdd1c38a76138878a17b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/reflection-repaint-test-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/transform-layout-repaint-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/compositing/shadows/shadow-drawing-expected.png
[delete] https://crrev.com/e16cd1440c94c183b042fdd1c38a76138878a17b/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/svg/transforms/svg-css-transforms-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/transforms/svg-vs-css-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac-retina/svg/transforms/svg-css-transforms-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac-retina/transforms/svg-vs-css-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac/svg/transforms/svg-css-transforms-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac/transforms/svg-vs-css-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac/transforms/transform-on-inline-expected.png
[delete] https://crrev.com/e16cd1440c94c183b042fdd1c38a76138878a17b/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win/svg/transforms/svg-css-transforms-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win/transforms/svg-vs-css-expected.png
[delete] https://crrev.com/e16cd1440c94c183b042fdd1c38a76138878a17b/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png
[add] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/reflection-repaint-test-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/transform-layout-repaint-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win7/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win7/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png
[add] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/invalidation-with-scale-transform-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Comment 4 by wangxianzhu@chromium.org, May 3 2017

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9e07a4e55c864a16fc67366c2a29efd037c5c3c

commit d9e07a4e55c864a16fc67366c2a29efd037c5c3c
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed May 10 22:31:01 2017

Don't pass subpixel offsets through non-translation transforms (composited case)

For non-translation transforms, discard subpixel accumulation.

BUG= 717882 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
R=chrishtr@chromium.org

Review-Url: https://codereview.chromium.org/2868933002 .
Cr-Commit-Position: refs/heads/master@{#470733}

[modify] https://crrev.com/d9e07a4e55c864a16fc67366c2a29efd037c5c3c/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[add] https://crrev.com/d9e07a4e55c864a16fc67366c2a29efd037c5c3c/third_party/WebKit/LayoutTests/paint/invalidation/compositing/subpixel-offset-scaled-transform-composited-expected.html
[add] https://crrev.com/d9e07a4e55c864a16fc67366c2a29efd037c5c3c/third_party/WebKit/LayoutTests/paint/invalidation/compositing/subpixel-offset-scaled-transform-composited-expected.txt
[add] https://crrev.com/d9e07a4e55c864a16fc67366c2a29efd037c5c3c/third_party/WebKit/LayoutTests/paint/invalidation/compositing/subpixel-offset-scaled-transform-composited.html
[modify] https://crrev.com/d9e07a4e55c864a16fc67366c2a29efd037c5c3c/third_party/WebKit/LayoutTests/platform/linux/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.png
[modify] https://crrev.com/d9e07a4e55c864a16fc67366c2a29efd037c5c3c/third_party/WebKit/LayoutTests/platform/mac/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.png
[modify] https://crrev.com/d9e07a4e55c864a16fc67366c2a29efd037c5c3c/third_party/WebKit/LayoutTests/platform/win/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.png
[modify] https://crrev.com/d9e07a4e55c864a16fc67366c2a29efd037c5c3c/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Comment 6 by sureshkumari@chromium.org, May 11 2017

Labels: TE-Verified-60.0.3095.5 TE-Verified-M60
Tested the issue on Windows-7,Mac-10.12.4 and Linux Ubuntu-14.04 using chrome version 60.0.3095.5 with the steps mentioned in comment#0.
Observed that the fix is working as expected. Hence adding TE-Verified labels.
Please find the attached screenshot for the same.

Thanks!!
717882.mp4
426 KB View Download
►

Sign in to add a comment