New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717875 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted red underline appears for Bing.com on Edit Search Engine overlay.

Reported by aiman.an...@etouch.net, May 3 2017

Issue description

Chrome: 59.0.3071.36 (Official Build) (cohort: win_58_96)0a97305f0587704e901b20cc4060c997d6c4eaff-refs/branch-heads/3071@{#365}(32/64-bit)

OS: Windows(7,8,8.1,10), Linux(14.04 LTS).

Steps to reproduce:
1. Launch chrome, go to chrome://settings/searchEngines, Click on Iron-icon for Bing and select Edit.
2. On Edit search Engine overlay observe.

Actual Result: Unwanted red underline appears for Search Engine and Keyword option.
Expected Result: Red underline should not appear.

This is Regression issue broken in M-58, will soon update other info

Manual Bisect:
Good Build: 58.0.3022.0
Bad Build: 58.0.3023.0

Note: Issue is not seen on MAC OS.
 
Actual Result.mp4
731 KB View Download
Expected Result.mp4
799 KB View Download
Result.png
34.0 KB View Download
Labels: hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: xiaoche...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 58.0.3032.0 (Revision: 452713).
Bad build : 58.0.3033.0 (Revision: 453044).

You are probably looking for a change made after 452898 (known good), but no later than 452899 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/f8de71db706d577e6f8e0407679277022af6c8d2..0fcdf64bf2b57cfc3c21965bd037d198f7fabd4e

@xiaochengh: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Thank You.
Cc: xiaoche...@chromium.org
Owner: dpa...@chromium.org
The CL in #1 fixes a bug that, text in <input> is not spellchecked if it ends with a letter.

chrome://md-settings/searchEngines (and possibly other pages?) should add spellcheck="false" to its input fields where spellchecking is unwanted.

Hence rerouting to Web UI team.
Cc: dbeam@chromium.org tbuck...@chromium.org
@dbeam, @tbuckley: The change at https://codereview.chromium.org/2712833004 causes a lot of our text inputs to be spellchecked (and annotated with red underlines), whereas before this was not happening.

Is this considered a bug? If so, should we fix this for M59? 

Comment 4 by dbeam@chromium.org, May 3 2017

Labels: -M-59
if you have to ask whether it's a bug, I'd say it's unlikely this is merge-worthy

i don't realllly see a huge problem with spellchecking too many inputs, but happy to turn it off as well in M60 if we don't want it.
Labels: Hotlist-MD-Settings-General

Comment 6 by dpa...@chromium.org, May 15 2017

Cc: jmukthavaram@chromium.org kavvaru@chromium.org dpa...@chromium.org brajkumar@chromium.org ajha@chromium.org
 Issue 721325  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dafa544f5e60db81cec06c308d1a2f4c3535226

commit 4dafa544f5e60db81cec06c308d1a2f4c3535226
Author: dpapad <dpapad@chromium.org>
Date: Tue Aug 15 20:31:46 2017

Settings WebUI: Turn off spellcheck on certain dialogs.

Stop spellchecking URLs and other non-free form text inputs.

Bug:  717875 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iee9ac2024e8e7b96e3c57f7ab9973081fc8d3e3d
Reviewed-on: https://chromium-review.googlesource.com/611568
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494524}
[modify] https://crrev.com/4dafa544f5e60db81cec06c308d1a2f4c3535226/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html
[modify] https://crrev.com/4dafa544f5e60db81cec06c308d1a2f4c3535226/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html
[modify] https://crrev.com/4dafa544f5e60db81cec06c308d1a2f4c3535226/chrome/browser/resources/settings/site_settings/add_site_dialog.html

Labels: TE-Verified-M62 TE-Verified-62.0.3187.0
Note: Retested the above issue on #62.0.3187.0 on Linux(14.04 LTS) and Win(7,8,10).
Fix is working as intended.

Result.mov
1.7 MB Download
Status: Fixed (was: Assigned)

Sign in to add a comment