Issue metadata
Sign in to add a comment
|
Regression: Unwanted red underline appears for Bing.com on Edit Search Engine overlay.
Reported by
aiman.an...@etouch.net,
May 3 2017
|
||||||||||||||||||||||
Issue descriptionChrome: 59.0.3071.36 (Official Build) (cohort: win_58_96)0a97305f0587704e901b20cc4060c997d6c4eaff-refs/branch-heads/3071@{#365}(32/64-bit) OS: Windows(7,8,8.1,10), Linux(14.04 LTS). Steps to reproduce: 1. Launch chrome, go to chrome://settings/searchEngines, Click on Iron-icon for Bing and select Edit. 2. On Edit search Engine overlay observe. Actual Result: Unwanted red underline appears for Search Engine and Keyword option. Expected Result: Red underline should not appear. This is Regression issue broken in M-58, will soon update other info Manual Bisect: Good Build: 58.0.3022.0 Bad Build: 58.0.3023.0 Note: Issue is not seen on MAC OS.
,
May 3 2017
The CL in #1 fixes a bug that, text in <input> is not spellchecked if it ends with a letter. chrome://md-settings/searchEngines (and possibly other pages?) should add spellcheck="false" to its input fields where spellchecking is unwanted. Hence rerouting to Web UI team.
,
May 3 2017
@dbeam, @tbuckley: The change at https://codereview.chromium.org/2712833004 causes a lot of our text inputs to be spellchecked (and annotated with red underlines), whereas before this was not happening. Is this considered a bug? If so, should we fix this for M59?
,
May 3 2017
if you have to ask whether it's a bug, I'd say it's unlikely this is merge-worthy i don't realllly see a huge problem with spellchecking too many inputs, but happy to turn it off as well in M60 if we don't want it.
,
May 8 2017
,
May 15 2017
Issue 721325 has been merged into this issue.
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4dafa544f5e60db81cec06c308d1a2f4c3535226 commit 4dafa544f5e60db81cec06c308d1a2f4c3535226 Author: dpapad <dpapad@chromium.org> Date: Tue Aug 15 20:31:46 2017 Settings WebUI: Turn off spellcheck on certain dialogs. Stop spellchecking URLs and other non-free form text inputs. Bug: 717875 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iee9ac2024e8e7b96e3c57f7ab9973081fc8d3e3d Reviewed-on: https://chromium-review.googlesource.com/611568 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#494524} [modify] https://crrev.com/4dafa544f5e60db81cec06c308d1a2f4c3535226/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html [modify] https://crrev.com/4dafa544f5e60db81cec06c308d1a2f4c3535226/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html [modify] https://crrev.com/4dafa544f5e60db81cec06c308d1a2f4c3535226/chrome/browser/resources/settings/site_settings/add_site_dialog.html
,
Aug 16 2017
Note: Retested the above issue on #62.0.3187.0 on Linux(14.04 LTS) and Win(7,8,10). Fix is working as intended.
,
Aug 16 2017
,
Sep 11 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, May 3 2017Owner: xiaoche...@chromium.org
Status: Assigned (was: Unconfirmed)