New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 717864 link

Starred by 0 users
Status: Fixed
Owner:
█ vabr@chromium.org
hobby only
Closed: May 2017
Cc:
█ lpromero@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

CollectionViewTestItem should use accessibilityLabel if present

Project Member Reported by vabr@chromium.org, May 3 2017 
CollectionViewTestItem is used to configure a CollectionViewTestCell. The Item can have an accessibilityLabel, but the current code will not copy it over if non-empty. Instead it always derives the label from the text [1].

lpromero@ pointed out [2] that this is a bug, and accessibilityLabel should be copied over from the item to the cell if non-empty.



[1] https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.mm?type=cs&sq=package:chromium&l=74-79

[2] https://codereview.chromium.org/2719023005/#msg11
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/887ed4b568cf6c67608c9838fef4be47fb962fd1

commit 887ed4b568cf6c67608c9838fef4be47fb962fd1
Author: vabr <vabr@chromium.org>
Date: Wed May 03 08:21:15 2017

CollectionViewTextItem should copy accessibilityLabel to the cell

Currently, the accessibilityLabel for the CollectionViewTextCell is always
composed from the text and detailText attributes. Instead, if present,
accessibilityLabel on the item should be copied over to the cell.

BUG= 717864 

Review-Url: https://codereview.chromium.org/2856113002
Cr-Commit-Position: refs/heads/master@{#468918}

[modify] https://crrev.com/887ed4b568cf6c67608c9838fef4be47fb962fd1/ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.mm
[modify] https://crrev.com/887ed4b568cf6c67608c9838fef4be47fb962fd1/ios/chrome/browser/ui/collection_view/cells/collection_view_text_item_unittest.mm

Comment 2 by vabr@chromium.org, May 3 2017

Status: Fixed (was: Started)
►

Sign in to add a comment