"benchmarks.benchmark_smoke_unittest.BenchmarkSmokeTest.v8.runtime_stats.top_25" is flaky |
||||||||
Issue description"benchmarks.benchmark_smoke_unittest.BenchmarkSmokeTest.v8.runtime_stats.top_25" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 28 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWQsSBUZsYWtlIk5iZW5jaG1hcmtzLmJlbmNobWFya19zbW9rZV91bml0dGVzdC5CZW5jaG1hcmtTbW9rZVRlc3QudjgucnVudGltZV9zdGF0cy50b3BfMjUM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
May 3 2017
...and it is quite reliably reproducible on: https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests
,
May 3 2017
Here's a trace from one of the builders: # # Fatal error in ../../v8/src/counters-inl.h, line 29 # Check failed: IsStarted(). # #0 0x7ffa23924d77 base::debug::StackTrace::StackTrace() #1 0x7ffa25ebc965 gin::(anonymous namespace)::PrintStackTrace() #2 0x7ffa25d78add V8_Fatal #3 0x7ffa22d14ccb v8::internal::RuntimeCallStats::Enter() #4 0x7ffa22a2d1d9 v8::String::NewFromTwoByte() #5 0x7ffa2333f80d v8_inspector::toV8String() #6 0x7ffa2336f719 v8_inspector::V8InspectorImpl::compileScript() #7 0x7ffa23379e4f v8_inspector::V8RuntimeAgentImpl::evaluate() #8 0x7ffa23322d98 v8_inspector::protocol::Runtime::DispatcherImpl::evaluate() #9 0x7ffa232c25d0 v8_inspector::protocol::Console::DispatcherImpl::dispatch() #10 0x7ffa232bac85 v8_inspector::protocol::UberDispatcher::dispatch() #11 0x7ffa23373b41 v8_inspector::V8InspectorSessionImpl::dispatchProtocolMessage() #12 0x7ffa2815c6d7 blink::InspectorSession::DispatchProtocolMessage() #13 0x7ffa263d9dac blink::WebDevToolsAgentImpl::DispatchOnInspectorBackend() #14 0x7ffa26c08083 content::DevToolsAgent::OnDispatchOnInspectorBackend() #15 0x7ffa26c07dfe _ZN3IPC8MessageTI48DevToolsAgentMsg_DispatchOnInspectorBackend_MetaSt5tupleIJiiSsSsEEvE8DispatchIN7content13DevToolsAgentES7_vMS7_FviiRKSsS9_EEEbPKNS_7MessageEPT_PT0_PT1_T2_ #16 0x7ffa26c073af content::DevToolsAgent::OnMessageReceived() #17 0x7ffa26ab1023 content::RenderFrameImpl::OnMessageReceived() #18 0x7ffa270a7e79 IPC::MessageRouter::RouteMessage() #19 0x7ffa270a7db4 IPC::MessageRouter::OnMessageReceived() #20 0x7ffa25ceb0dd content::ChildThreadImpl::OnMessageReceived() #21 0x7ffa23f29a05 IPC::ChannelProxy::Context::OnDispatchMessage() #22 0x7ffa22099f9a _ZN4base8internal7InvokerINS0_9BindStateINS0_18IgnoreResultHelperIMN7content20BrowserMessageFilter8InternalEFbRKN3IPC7MessageEEEEJ13scoped_refptrIS6_ES8_EEEFvvEE3RunEPNS0_13BindStateBaseE #23 0x7ffa21bf40e1 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv #24 0x7ffa239d4663 base::debug::TaskAnnotator::RunTask() #25 0x7ffa25ea4cf3 blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue() #26 0x7ffa25ea26ce blink::scheduler::TaskQueueManager::DoWork() #27 0x7ffa22013057 _ZN4base8internal7InvokerINS0_9BindStateIMN6policy17AsyncPolicyLoaderEFvbEJNS_7WeakPtrIS4_EEbEEEFvvEE3RunEPNS0_13BindStateBaseE #28 0x7ffa21bf40e1 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv #29 0x7ffa239d4663 base::debug::TaskAnnotator::RunTask() #30 0x7ffa239456dd base::MessageLoop::RunTask() #31 0x7ffa23945988 base::MessageLoop::DeferOrRunPendingTask() #32 0x7ffa23945e26 base::MessageLoop::DoWork() #33 0x7ffa23947689 base::MessagePumpDefault::Run() #34 0x7ffa2394543e base::MessageLoop::RunHandler() #35 0x7ffa2396df6c base::RunLoop::Run() #36 0x7ffa26b1797f content::RendererMain() #37 0x7ffa235046ea content::RunZygote() #38 0x7ffa23504c90 content::RunNamedProcessTypeMain() #39 0x7ffa235059c2 content::ContentMainRunnerImpl::Run() #40 0x7ffa2350d0a4 service_manager::Main() #41 0x7ffa235044c2 content::ContentMain() #42 0x7ffa21bef271 ChromeMain #43 0x7ffa1a599f45 __libc_start_main #44 0x7ffa21bef0dd <unknown>
,
May 3 2017
But it doesn't resemble the files changed in the mentioned autoroll. +cc V8 sheriffs if you have ideas
,
May 3 2017
Seems to be a check failing in runtime call stats. There's one CL that touched stuff there, +wiktorg. Also +cbruni as callstats expert.
,
May 3 2017
Most probably culprit: https://chromium.googlesource.com/v8/v8/+/8f4e8c0aee2154d0a18e5e578871e716a1cb26c9 wiktorg@ will have a look at it this afternoon.
,
May 3 2017
,
May 3 2017
,
May 3 2017
Revert on the way as quickfix: https://chromium-review.googlesource.com/c/494472
,
May 3 2017
Doesn't apply anymore. Can you handle the revert or provide a better quickfix?
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/ce5ffd931cad057e551de25f3a42b7b358e146ec commit ce5ffd931cad057e551de25f3a42b7b358e146ec Author: Michael Achenbach <machenbach@chromium.org> Date: Wed May 03 16:32:45 2017 Revert "Fix runtime_call_stats for background parsing." This reverts commit 8f4e8c0aee2154d0a18e5e578871e716a1cb26c9. Reason for revert: Speculative revert for http://crbug.com/717854 Original change's description: > Fix runtime_call_stats for background parsing. > > BUG= v8:6093 > > Change-Id: I365fbd7c3f33e2de47e0a84ee3ea631b4ffa6d35 > Reviewed-on: https://chromium-review.googlesource.com/488243 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> > Commit-Queue: Wiktor Garbacz <wiktorg@google.com> > Cr-Commit-Position: refs/heads/master@{#45013} TBR=marja@chromium.org R=marja@chromium.org,vogelheim@chromium.org,cbruni@chromium.org,jochen@chromium.org BUG= v8:6093 , chromium:717854 Change-Id: Ia58a420ec4c1e84a9f01eb90545fabb0bc03aa63 Reviewed-on: https://chromium-review.googlesource.com/494568 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#45070} [modify] https://crrev.com/ce5ffd931cad057e551de25f3a42b7b358e146ec/src/api.cc [modify] https://crrev.com/ce5ffd931cad057e551de25f3a42b7b358e146ec/src/background-parsing-task.cc [modify] https://crrev.com/ce5ffd931cad057e551de25f3a42b7b358e146ec/src/compiler-dispatcher/compiler-dispatcher-job.cc [modify] https://crrev.com/ce5ffd931cad057e551de25f3a42b7b358e146ec/src/parsing/parse-info.cc [modify] https://crrev.com/ce5ffd931cad057e551de25f3a42b7b358e146ec/src/parsing/parse-info.h [modify] https://crrev.com/ce5ffd931cad057e551de25f3a42b7b358e146ec/src/parsing/parser.cc
,
May 3 2017
Reverted: https://chromium-review.googlesource.com/c/494568/ A corrected CL in review: https://chromium-review.googlesource.com/c/494590/ FLAG_runtime_call_stats instead of FLAG_runtime_stats was the issue...
,
May 3 2017
Thanks. Roll that includes the revert: https://codereview.chromium.org/2859873002/
,
May 4 2017
Detected 19 new flakes for test/step "benchmarks.benchmark_smoke_unittest.BenchmarkSmokeTest.v8.runtime_stats.top_25". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWQsSBUZsYWtlIk5iZW5jaG1hcmtzLmJlbmNobWFya19zbW9rZV91bml0dGVzdC5CZW5jaG1hcmtTbW9rZVRlc3QudjgucnVudGltZV9zdGF0cy50b3BfMjUM. This message was posted automatically by the chromium-try-flakes app.
,
May 4 2017
The latest reported flake has a V8 version older than the revert. So I assume this is fixed?
,
May 4 2017
LGTM
,
May 4 2017
Issue 718290 has been merged into this issue. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by msramek@chromium.org
, May 3 2017Labels: OS-Linux OS-Mac