New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717820 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
inactive
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

TileGroupTests failing

Project Member Reported by aelias@chromium.org, May 3 2017

Issue description

Builder: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests
Example build: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/41264

Error: android.content.res.Resources$NotFoundException: Resource ID #0x7f0a0154
	at android.content.res.ResourcesImpl.getValue(ResourcesImpl.java:190)
	at android.content.res.Resources.getDimensionPixelSize(Resources.java:667)
	at org.chromium.chrome.browser.suggestions.TileGroup.<init>(TileGroup.java:193)
	at org.chromium.chrome.browser.suggestions.TileGroupTest.testRenderTileViewReplacing(TileGroupTest.java:241)

Culprit is https://codereview.chromium.org/2842603002
 
Status: Fixed (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0f8ac5d596602275b1820e3f63d4966430f0de7

commit a0f8ac5d596602275b1820e3f63d4966430f0de7
Author: aelias <aelias@chromium.org>
Date: Wed May 03 02:03:01 2017

Revert of (Reland x2) Expose resources in Robolectric/JUnit tests. (patchset #4 id:60001 of https://codereview.chromium.org/2842603002/ )

Reason for revert:
TileGroupTest failing on waterfall, see  http://crbug.com/717820 

BUG= 717820 

Original issue's description:
> (Reland x2) Expose resources in Robolectric/JUnit tests.
>
> Will let people use Android resources in Robolectric tests.
> To use, specify package_name GN variable in junit_binary
> targets with your apps package name.
>
> This change will also (basically) require that you use the
> generated wrappers from out_dir/bin/run_<suite name> to run
> the tests since GN will be generating many arguments to
> pass along to the test runner.
>
> BUG= 693573 
>
> Review-Url: https://codereview.chromium.org/2842603002
> Cr-Commit-Position: refs/heads/master@{#468822}
> Committed: https://chromium.googlesource.com/chromium/src/+/bc26a6f5b4ed9ee2b84878c17e8f4149db815db7

TBR=agrieve@chromium.org,jbudorick@chromium.org,nyquist@chromium.org,mikecase@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 693573 

Review-Url: https://codereview.chromium.org/2859583004
Cr-Commit-Position: refs/heads/master@{#468871}

[modify] https://crrev.com/a0f8ac5d596602275b1820e3f63d4966430f0de7/build/android/gyp/create_test_runner_script.py
[modify] https://crrev.com/a0f8ac5d596602275b1820e3f63d4966430f0de7/build/android/gyp/write_build_config.py
[modify] https://crrev.com/a0f8ac5d596602275b1820e3f63d4966430f0de7/build/android/lint/suppressions.xml
[modify] https://crrev.com/a0f8ac5d596602275b1820e3f63d4966430f0de7/build/android/pylib/junit/junit_test_instance.py
[modify] https://crrev.com/a0f8ac5d596602275b1820e3f63d4966430f0de7/build/android/pylib/local/machine/local_machine_junit_test_run.py
[modify] https://crrev.com/a0f8ac5d596602275b1820e3f63d4966430f0de7/build/android/test_runner.py
[modify] https://crrev.com/a0f8ac5d596602275b1820e3f63d4966430f0de7/build/android/test_runner.pydeps
[modify] https://crrev.com/a0f8ac5d596602275b1820e3f63d4966430f0de7/build/config/android/internal_rules.gni
[modify] https://crrev.com/a0f8ac5d596602275b1820e3f63d4966430f0de7/build/config/android/rules.gni
[modify] https://crrev.com/a0f8ac5d596602275b1820e3f63d4966430f0de7/chrome/android/BUILD.gn
[modify] https://crrev.com/a0f8ac5d596602275b1820e3f63d4966430f0de7/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
[modify] https://crrev.com/a0f8ac5d596602275b1820e3f63d4966430f0de7/testing/android/OWNERS
[modify] https://crrev.com/a0f8ac5d596602275b1820e3f63d4966430f0de7/testing/android/junit/java/src/org/chromium/testing/local/GNManifestFactory.java
[modify] https://crrev.com/a0f8ac5d596602275b1820e3f63d4966430f0de7/testing/android/junit/java/src/org/chromium/testing/local/LocalRobolectricTestRunner.java
[modify] https://crrev.com/a0f8ac5d596602275b1820e3f63d4966430f0de7/third_party/robolectric/README.chromium

Sign in to add a comment