New issue
Advanced search Search tips

Issue 717818 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Raster transparent animating layers but don't draw them

Project Member Reported by jaydasika@chromium.org, May 3 2017

Issue description

Raster them because they can become visible after animating. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d7e67c3c84d2f11e12d34bdb71fa1b2153e38a5

commit 2d7e67c3c84d2f11e12d34bdb71fa1b2153e38a5
Author: jaydasika <jaydasika@chromium.org>
Date: Thu May 04 03:01:13 2017

cc : Don't draw animating layers which are transparent but raster them.

This is similar to https://codereview.chromium.org/2838033002/ where
we do that same thing for animating layers with singular transform

BUG= 717818 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2858853002
Cr-Commit-Position: refs/heads/master@{#469253}

[modify] https://crrev.com/2d7e67c3c84d2f11e12d34bdb71fa1b2153e38a5/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/2d7e67c3c84d2f11e12d34bdb71fa1b2153e38a5/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/2d7e67c3c84d2f11e12d34bdb71fa1b2153e38a5/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/2d7e67c3c84d2f11e12d34bdb71fa1b2153e38a5/cc/trees/property_tree.cc

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50612fa00dfc8e79fe5bc92e2f235eee645739e9

commit 50612fa00dfc8e79fe5bc92e2f235eee645739e9
Author: jaydasika <jaydasika@chromium.org>
Date: Fri May 19 20:56:02 2017

Revert of cc : Don't draw animating layers which are transparent but raster them. (patchset #2 id:20001 of https://codereview.chromium.org/2858853002/ )

Reason for revert:
Could be the cause of crbug.com/724591

Original issue's description:
> cc : Don't draw animating layers which are transparent but raster them.
>
> This is similar to https://codereview.chromium.org/2838033002/ where
> we do that same thing for animating layers with singular transform
>
> BUG= 717818 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>

TBR=enne@chromium.org,weiliangc@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 717818 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2894953003
Cr-Commit-Position: refs/heads/master@{#473308}

[modify] https://crrev.com/50612fa00dfc8e79fe5bc92e2f235eee645739e9/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/50612fa00dfc8e79fe5bc92e2f235eee645739e9/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/50612fa00dfc8e79fe5bc92e2f235eee645739e9/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/50612fa00dfc8e79fe5bc92e2f235eee645739e9/cc/trees/property_tree.cc

Status: Assigned (was: Fixed)
Reopening as the patch is reverted
Owner: khushals...@chromium.org
Status: WontFix (was: Assigned)
Discussed on bug: crbug.com/724591

Sign in to add a comment