New issue
Advanced search Search tips

Issue 717816 link

Starred by 1 user
Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 518942



Sign in to add a comment

Remove BluetoothAdapterAndroid::GetAddress()

Project Member Reported by reillyg@chromium.org, May 3 2017 
device::BluetoothAdapterAndroid::GetAddress() calls the Java method 
android.bluetooth.BluetoothAdapter.getAddress() for which the linter raises a "HardwareIds" warning because this method accesses a unique device identifier contrary to the recommendations here:

https://developer.android.com/training/articles/user-data-ids.html

Additionally, this page says that in Android 6.0+:

The WifiInfo.getMacAddress() method and the BluetoothAdapter.getDefaultAdapter().getAddress() method will both return 02:00:00:00:00:00.

This means calling this method is not only not recommended but also useless. Web Bluetooth does not depend on access to the adapter MAC address so this method is not needed on Android and if possible the device::BluetoothAdapter::GetAddress() method should be removed entirely.

Comment 1 by ortuno@chromium.org, May 3 2017

Blocking: 518942
tldr; Removing device::BluetoothAdapter::GetAddress() is blocked on major refactor of device/bluetooth and Chrome Apps deprecation on non-ChromeOS platforms. But we should at least mention that the result is useless in Android.

1. BluetoothAdapter has many methods that control Bluetooth Adapters. Many of these methods are specific to Chrome OS and not available on other platforms so we end up with a bunch of #if's and NOTIMPLEMENTEDs. We plan on splitting BluetoothAdapter and have a Chrome OS only specific class to control the adapter.

2. The adapter address is exposed to Chrome Apps[1] so we are stuck with the method on other platforms until we deprecate non-ChromeOS chrome apps.

[1] https://developer.chrome.com/apps/bluetooth#type-AdapterState
Project Member

Comment 2 by sheriffbot@chromium.org, May 3 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by reillyg@chromium.org, May 3 2018

Status: Available (was: Untriaged)
►

Sign in to add a comment