Issue 717812 link

Starred by 9 users

Issue metadata

Status:	Started
Owner:	c...@chromium.org
Cc:	cmumford@chromium.org jsb...@chromium.org dmu...@chromium.org
Components:	Blink>Storage>IndexedDB
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Task

Blocked on:
issue 611935
issue 868995

Blocking:
issue 653295
issue 723846
issue 821175
issue 710726

Onion-soup for IndexedDB

Project Member Reported by dmu...@chromium.org, May 3 2017

Issue description

Remove the web layer, formalize mojo layer, etc.

Remove the web layer, formalize mojo layer, etc.

Will probably have the largest performance benefits for IndexedDB.

Unknowns
* The amount of work to untangle task queuing
* If this should be done before or after a mojoification update: https://bugs.chromium.org/p/chromium/issues/detail?id=717798

Comment 1 by jsb...@chromium.org, Jun 9 2017

Labels: -Type-Bug Type-Task

Comment 2 by dmu...@chromium.org, May 15 2018

content/renderer/indexed_db/

Comment 3 by dmu...@chromium.org, May 15 2018

Cc: dmu...@chromium.org

Issue 728811 has been merged into this issue.

Comment 4 by dmu...@chromium.org, May 15 2018

Cc: cmumford@chromium.org jsb...@chromium.org

Issue 787284 has been merged into this issue.

Comment 5 by dmu...@chromium.org, May 15 2018

Blocking: 723846

Comment 6 by dmu...@chromium.org, May 15 2018

Blocking: 710726

Comment 7 by dmu...@chromium.org, May 16 2018

Description: Show this description

Comment 8 by dmu...@chromium.org, May 16 2018

Blockedon: -717798

Comment 9 by dmu...@chromium.org, May 16 2018

Blocking: 653295

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a38f2f1a2858300a040a43c2cfd5e9041b70f0c

commit 3a38f2f1a2858300a040a43c2cfd5e9041b70f0c
Author: Chase Phillips <cmp@chromium.org>
Date: Wed Jul 25 21:08:35 2018

Move WebIDBFactoryImpl to a non-channel-associated interface

Bug: 717812
Change-Id: Id90b1199c9702e7f03864cb40958fae858c1c3cd
Reviewed-on: https://chromium-review.googlesource.com/1146335
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578062}
[modify] https://crrev.com/3a38f2f1a2858300a040a43c2cfd5e9041b70f0c/content/browser/indexed_db/indexed_db_dispatcher_host.cc
[modify] https://crrev.com/3a38f2f1a2858300a040a43c2cfd5e9041b70f0c/content/browser/indexed_db/indexed_db_dispatcher_host.h
[modify] https://crrev.com/3a38f2f1a2858300a040a43c2cfd5e9041b70f0c/content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc
[modify] https://crrev.com/3a38f2f1a2858300a040a43c2cfd5e9041b70f0c/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/3a38f2f1a2858300a040a43c2cfd5e9041b70f0c/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/3a38f2f1a2858300a040a43c2cfd5e9041b70f0c/content/renderer/indexed_db/webidbfactory_impl.cc
[modify] https://crrev.com/3a38f2f1a2858300a040a43c2cfd5e9041b70f0c/content/renderer/indexed_db/webidbfactory_impl.h
[modify] https://crrev.com/3a38f2f1a2858300a040a43c2cfd5e9041b70f0c/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/3a38f2f1a2858300a040a43c2cfd5e9041b70f0c/content/renderer/renderer_blink_platform_impl.h

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af6f49690caf8ba3279f4c207ee27b0cccc36637

commit af6f49690caf8ba3279f4c207ee27b0cccc36637
Author: Chase Phillips <cmp@chromium.org>
Date: Sat Jul 28 00:21:16 2018

Create a WebIDBFactory instance for each IdbFactory

Each WebIDBFactory has a bound mojo interface from the thread
that created the WebIDBFactory instance.  The previous code
allowed for the main thread and worker threads to use a single
instance.

There is a call-time constraint that the caller be on the same
thread as where the bind originally occurred.  When the previous
was always calling the mojo interface from the IO thread, the
constraint was never violated.

Since we want to remove the IO thread hopping, though, this
exposes the violation.  I'm fixing that by allowing each top-
level Blink IdbFactory to own its own WebIDBFactory.  Eventually
as part of this cleanup effort IdbFactory and WebIDBFactory will
merge into a single class and simplify more of this code.

Bug: 717812
Change-Id: I9571f5703261f0d6afda9ad04946cb10e42ce0e8
Reviewed-on: https://chromium-review.googlesource.com/1150914
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578873}
[modify] https://crrev.com/af6f49690caf8ba3279f4c207ee27b0cccc36637/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/af6f49690caf8ba3279f4c207ee27b0cccc36637/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/af6f49690caf8ba3279f4c207ee27b0cccc36637/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/af6f49690caf8ba3279f4c207ee27b0cccc36637/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/af6f49690caf8ba3279f4c207ee27b0cccc36637/third_party/blink/public/platform/modules/indexeddb/web_idb_factory.h
[modify] https://crrev.com/af6f49690caf8ba3279f4c207ee27b0cccc36637/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/af6f49690caf8ba3279f4c207ee27b0cccc36637/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/af6f49690caf8ba3279f4c207ee27b0cccc36637/third_party/blink/renderer/modules/indexeddb/idb_factory.h
[modify] https://crrev.com/af6f49690caf8ba3279f4c207ee27b0cccc36637/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/af6f49690caf8ba3279f4c207ee27b0cccc36637/third_party/blink/renderer/platform/testing/testing_platform_support.h

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5ce7038bfcaa4cdec4fe261f2dc8fc153eb4b59

commit b5ce7038bfcaa4cdec4fe261f2dc8fc153eb4b59
Author: Chase Phillips <cmp@chromium.org>
Date: Sat Jul 28 22:25:45 2018

Remove WebIDBFactoryImpl IOThreadHelper class

Now that the renderer-side factory uses a normal Mojo interface,
there's no longer a need to jump to the IO thread to make the
calls on that interface.  This allows us to clean up the code
by removing the IO thread helper class.

Bug: 717812
Change-Id: Iab04a90677d50ab3a911330ede2333d452b6f829
Reviewed-on: https://chromium-review.googlesource.com/1150724
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578939}
[modify] https://crrev.com/b5ce7038bfcaa4cdec4fe261f2dc8fc153eb4b59/content/renderer/indexed_db/webidbfactory_impl.cc
[modify] https://crrev.com/b5ce7038bfcaa4cdec4fe261f2dc8fc153eb4b59/content/renderer/indexed_db/webidbfactory_impl.h

Comment 13 by c...@chromium.org, Jul 28

Owner: c...@chromium.org
Status: Assigned (was: Available)

Comment 14 by c...@chromium.org, Aug 1

Blockedon: 868995

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/799eac6fdd8a64f1b7fc2fccb66c92d8cf453c28

commit 799eac6fdd8a64f1b7fc2fccb66c92d8cf453c28
Author: Chase Phillips <cmp@chromium.org>
Date: Thu Aug 02 19:28:55 2018

Remove WebIDB{Database,Cursor}Impl IOThreadHelper class

This is the next step in removing IO thread hopping from the
renderer-side non-Blink IDB code.

Bug: 717812
Change-Id: I4f0bfc8d98ad7bd9d041954f74215f75271702f9
Reviewed-on: https://chromium-review.googlesource.com/1155794
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580282}
[modify] https://crrev.com/799eac6fdd8a64f1b7fc2fccb66c92d8cf453c28/content/renderer/indexed_db/webidbcursor_impl.cc
[modify] https://crrev.com/799eac6fdd8a64f1b7fc2fccb66c92d8cf453c28/content/renderer/indexed_db/webidbcursor_impl.h
[modify] https://crrev.com/799eac6fdd8a64f1b7fc2fccb66c92d8cf453c28/content/renderer/indexed_db/webidbdatabase_impl.cc
[modify] https://crrev.com/799eac6fdd8a64f1b7fc2fccb66c92d8cf453c28/content/renderer/indexed_db/webidbdatabase_impl.h
[modify] https://crrev.com/799eac6fdd8a64f1b7fc2fccb66c92d8cf453c28/content/renderer/indexed_db/webidbfactory_impl.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8847d90d52ee3f761dba46ead29613b08022c241

commit 8847d90d52ee3f761dba46ead29613b08022c241
Author: Chase Phillips <cmp@chromium.org>
Date: Thu Aug 02 21:33:04 2018

Stop passing |io_runner| around in IDB render-side code

As a result of the recent IO thread hopping removals,
|io_runner| is no longer needed.

Bug: 717812
Change-Id: I525785fda65a2edfaf86f11bcfcc21d6c74de85b
Reviewed-on: https://chromium-review.googlesource.com/1155830
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580331}
[modify] https://crrev.com/8847d90d52ee3f761dba46ead29613b08022c241/content/renderer/indexed_db/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/8847d90d52ee3f761dba46ead29613b08022c241/content/renderer/indexed_db/indexed_db_callbacks_impl.h
[modify] https://crrev.com/8847d90d52ee3f761dba46ead29613b08022c241/content/renderer/indexed_db/webidbcursor_impl.cc
[modify] https://crrev.com/8847d90d52ee3f761dba46ead29613b08022c241/content/renderer/indexed_db/webidbcursor_impl.h
[modify] https://crrev.com/8847d90d52ee3f761dba46ead29613b08022c241/content/renderer/indexed_db/webidbcursor_impl_unittest.cc
[modify] https://crrev.com/8847d90d52ee3f761dba46ead29613b08022c241/content/renderer/indexed_db/webidbdatabase_impl.cc
[modify] https://crrev.com/8847d90d52ee3f761dba46ead29613b08022c241/content/renderer/indexed_db/webidbdatabase_impl.h
[modify] https://crrev.com/8847d90d52ee3f761dba46ead29613b08022c241/content/renderer/indexed_db/webidbdatabase_impl_unittest.cc
[modify] https://crrev.com/8847d90d52ee3f761dba46ead29613b08022c241/content/renderer/indexed_db/webidbfactory_impl.cc
[modify] https://crrev.com/8847d90d52ee3f761dba46ead29613b08022c241/content/renderer/indexed_db/webidbfactory_impl.h
[modify] https://crrev.com/8847d90d52ee3f761dba46ead29613b08022c241/content/renderer/renderer_blink_platform_impl.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4743af8ed85e692c90c9ab4d784a59760045244c

commit 4743af8ed85e692c90c9ab4d784a59760045244c
Author: Chase Phillips <cmp@chromium.org>
Date: Wed Aug 08 01:55:46 2018

Remove callback thread hopping from callbacks impls

Once the explicit thread hopping is removed, we can remove
the Mojo lifecycle monitoring extensions.  All references
should be held on the same threads and there's not a chance
that they'll go out of scope on one thread and still be
needed on another thread.

Bug: 717812
Change-Id: Ib72fdff1cc19490fcfd24c422c8fbd04e12dc280
Reviewed-on: https://chromium-review.googlesource.com/1162921
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581436}
[modify] https://crrev.com/4743af8ed85e692c90c9ab4d784a59760045244c/content/renderer/indexed_db/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/4743af8ed85e692c90c9ab4d784a59760045244c/content/renderer/indexed_db/indexed_db_callbacks_impl.h
[modify] https://crrev.com/4743af8ed85e692c90c9ab4d784a59760045244c/content/renderer/indexed_db/indexed_db_database_callbacks_impl.cc
[modify] https://crrev.com/4743af8ed85e692c90c9ab4d784a59760045244c/content/renderer/indexed_db/indexed_db_database_callbacks_impl.h
[modify] https://crrev.com/4743af8ed85e692c90c9ab4d784a59760045244c/content/renderer/indexed_db/indexed_db_dispatcher.cc
[modify] https://crrev.com/4743af8ed85e692c90c9ab4d784a59760045244c/content/renderer/indexed_db/indexed_db_dispatcher.h
[modify] https://crrev.com/4743af8ed85e692c90c9ab4d784a59760045244c/content/renderer/indexed_db/webidbfactory_impl.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eabf9ad0429004d92823c7594d0b141f97cdead8

commit eabf9ad0429004d92823c7594d0b141f97cdead8
Author: Chase Phillips <cmp@chromium.org>
Date: Wed Aug 08 22:22:36 2018

Stop passing callback_runner into IndexedDBCallbacksImpl

Bug: 717812
Change-Id: Ief0d69e6b676a8fd7456a16acd221851f70bc13f
Reviewed-on: https://chromium-review.googlesource.com/1164471
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581707}
[modify] https://crrev.com/eabf9ad0429004d92823c7594d0b141f97cdead8/content/renderer/indexed_db/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/eabf9ad0429004d92823c7594d0b141f97cdead8/content/renderer/indexed_db/indexed_db_callbacks_impl.h
[modify] https://crrev.com/eabf9ad0429004d92823c7594d0b141f97cdead8/content/renderer/indexed_db/webidbcursor_impl.cc
[modify] https://crrev.com/eabf9ad0429004d92823c7594d0b141f97cdead8/content/renderer/indexed_db/webidbcursor_impl.h
[modify] https://crrev.com/eabf9ad0429004d92823c7594d0b141f97cdead8/content/renderer/indexed_db/webidbcursor_impl_unittest.cc
[modify] https://crrev.com/eabf9ad0429004d92823c7594d0b141f97cdead8/content/renderer/indexed_db/webidbdatabase_impl.cc
[modify] https://crrev.com/eabf9ad0429004d92823c7594d0b141f97cdead8/content/renderer/indexed_db/webidbdatabase_impl.h
[modify] https://crrev.com/eabf9ad0429004d92823c7594d0b141f97cdead8/content/renderer/indexed_db/webidbdatabase_impl_unittest.cc
[modify] https://crrev.com/eabf9ad0429004d92823c7594d0b141f97cdead8/content/renderer/indexed_db/webidbfactory_impl.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcf58536022e4137b3866a55e0857899a9293da4

commit dcf58536022e4137b3866a55e0857899a9293da4
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Thu Aug 16 01:30:18 2018

Fix dependencies of blink/public/common:headers.

This source_set target should not depend on mojom_core, as that pulls in
the .cc files of the blink mojom bindings in addition to the header files,
which can result in duplicate symbols and weird linking errors. Instead
depend on mojom_core_headers.

Bug: 717812
Change-Id: I4a359cfc1592f2557717b31966bfa8cdda9ed812
Reviewed-on: https://chromium-review.googlesource.com/1176070
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583485}
[modify] https://crrev.com/dcf58536022e4137b3866a55e0857899a9293da4/third_party/blink/common/BUILD.gn
[modify] https://crrev.com/dcf58536022e4137b3866a55e0857899a9293da4/third_party/blink/public/common/BUILD.gn

Project Member

Comment 20 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68ecf551c907aaf654070f7f5f8296fddef3016f

commit 68ecf551c907aaf654070f7f5f8296fddef3016f
Author: Chase Phillips <cmp@chromium.org>
Date: Thu Aug 16 01:59:13 2018

Move IDB Mojo file to Blink (part 1)

Part 1 in moving the IDB Mojo file from content/common/indexed_db/
to third_party/blink/public/mojom/indexeddb/indexeddb.mojom.

This commit:
- adds the indexeddb.mojom file
- puts the new mojom in the blink mojom namespace
- updates all files that include the indexed_db.mojom.h header to
  include the new indexeddb.mojom.h as well
- moves web_idb_types.h to blink/public/common/indexeddb/

This commit converts Chromium to the following Mojom types:
- indexed_db.mojom.BlobInfo -> blink.mojom.IDBBlobInfo
- indexed_db.mojom.FileInfo -> blink.mojom.IDBFileInfo
- indexed_db.mojom.Value -> blink.mojom.IDBValue
- indexed_db.mojom.ObserverTransaction -> blink.mojom.IDBObserverTransaction
- indexed_db.mojom.OperationType -> blink.mojom.IDBOperationType
- indexed_db.mojom.CursorDirection -> blink.mojom.IDBCursorDirection
- indexed_db.mojom.DataLoss -> blink.mojom.IDBDataLoss
- indexed_db.mojom.DatalessKeyType -> blink.mojom.IDBDatalessKeyType
- indexed_db.mojom.KeyData -> blink.mojom.IDBKeyData
- indexed_db.mojom.Key -> blink.mojom.IDBKey

Bug: 717812
Change-Id: I8255e69a24c59a11fa68d173ce5bb31c2b7f51a0
Reviewed-on: https://chromium-review.googlesource.com/1173713
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583494}
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/DEPS
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/cursor_impl.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/cursor_impl.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/database_impl.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/database_impl.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_backing_store.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_callbacks.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_callbacks.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_class_factory.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_cursor.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_cursor.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_data_loss_info.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_database.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_database_callbacks.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_database_unittest.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_dispatcher_host.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_factory_unittest.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_fake_backing_store.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_fake_backing_store.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_index_writer.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_index_writer.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_leveldb_coding.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_leveldb_coding.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_observer.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_return_value.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_tombstone_sweeper.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_tombstone_sweeper_unittest.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_transaction.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/indexed_db_transaction_coordinator.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/mock_indexed_db_callbacks.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/mock_indexed_db_callbacks.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/mock_mojo_indexed_db_callbacks.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/indexed_db/mock_mojo_indexed_db_database_callbacks.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/common/BUILD.gn
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/common/DEPS
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/common/indexed_db/indexed_db.mojom
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/common/indexed_db/indexed_db.typemap
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/common/indexed_db/indexed_db_key_path.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/common/indexed_db/indexed_db_key_range.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/common/indexed_db/indexed_db_key_range.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/common/indexed_db/indexed_db_struct_traits.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/common/indexed_db/indexed_db_struct_traits.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/renderer/indexed_db/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/renderer/indexed_db/indexed_db_callbacks_impl.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/renderer/indexed_db/indexed_db_database_callbacks_impl.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/renderer/indexed_db/indexed_db_dispatcher.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/renderer/indexed_db/indexed_db_key_builders.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/renderer/indexed_db/indexed_db_key_builders.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/renderer/indexed_db/webidbcursor_impl.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/renderer/indexed_db/webidbcursor_impl_unittest.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/renderer/indexed_db/webidbdatabase_impl.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/renderer/indexed_db/webidbdatabase_impl.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/renderer/indexed_db/webidbdatabase_impl_unittest.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/renderer/indexed_db/webidbfactory_impl.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/content/test/BUILD.gn
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/common/BUILD.gn
[add] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/common/indexeddb/OWNERS
[rename] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/common/indexeddb/indexeddb_key.cc
[rename] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/common/indexeddb/indexeddb_key_unittest.cc
[add] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/common/indexeddb/indexeddb_struct_traits.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/public/common/BUILD.gn
[add] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/public/common/indexeddb/OWNERS
[add] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/public/common/indexeddb/indexeddb.typemap
[rename] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/public/common/indexeddb/indexeddb_key.h
[add] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/public/common/indexeddb/indexeddb_struct_traits.h
[rename] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/public/common/indexeddb/web_idb_types.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/public/mojom/indexeddb/OWNERS
[add] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/public/mojom/indexeddb/indexeddb.mojom
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/public/platform/modules/indexeddb/web_idb_cursor.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/public/platform/modules/indexeddb/web_idb_database.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/public/platform/modules/indexeddb/web_idb_key.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/public/platform/modules/indexeddb/web_idb_key_path.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/public/platform/modules/indexeddb/web_idb_observation.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/public/public_typemaps.gni
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/renderer/modules/indexeddb/idb_cursor.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/renderer/modules/indexeddb/idb_cursor_with_value.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/renderer/modules/indexeddb/idb_index.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/renderer/modules/indexeddb/idb_key.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/renderer/modules/indexeddb/idb_key_path.cc
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/renderer/modules/indexeddb/idb_object_store.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/renderer/modules/indexeddb/idb_observation.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/renderer/modules/indexeddb/idb_observer.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/renderer/modules/indexeddb/idb_request.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/renderer/modules/indexeddb/idb_transaction.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/renderer/modules/indexeddb/idb_version_change_event.h
[modify] https://crrev.com/68ecf551c907aaf654070f7f5f8296fddef3016f/third_party/blink/renderer/modules/indexeddb/inspector_indexed_db_agent.cc

Comment 21 by c...@chromium.org, Aug 23

IndexedDB Onion Soup design doc at:
https://docs.google.com/document/d/12nwW3mLxVBximpIt9IS0h7hoaB5fcIAl4zHdhuOVKLg/edit

Project Member

Comment 22 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/850b96f780834ba4baa969d48c378beac6251089

commit 850b96f780834ba4baa969d48c378beac6251089
Author: Chase Phillips <cmp@chromium.org>
Date: Fri Aug 24 19:44:16 2018

IndexedDB: Move Mojo file to Blink (part 2)

Part 2 in moving the IDB Mojo file from content/common/indexed_db/
to third_party/blink/public/mojom/indexeddb/indexeddb.mojom.

This commit:
- moves IndexedDBKeyPath from content to blink

This commit converts Chromium to the following Mojom types:
- indexed_db.mojom.KeyPath -> blink.mojom.IDBKeyPath

Bug: 717812
Change-Id: I286081555c62c18c5f423813a41035ce8316d494
Reviewed-on: https://chromium-review.googlesource.com/1185790
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585946}
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/database_impl.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/database_impl.h
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/fake_indexed_db_metadata_coding.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/fake_indexed_db_metadata_coding.h
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_backing_store.h
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_callbacks.h
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_database.h
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_database_unittest.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_index_writer.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_index_writer.h
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_leveldb_coding.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_leveldb_coding.h
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_leveldb_operations.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_leveldb_operations.h
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_metadata_coding.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_metadata_coding.h
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_return_value.h
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/browser/indexed_db/indexed_db_tombstone_sweeper_unittest.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/common/BUILD.gn
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/common/indexed_db/indexed_db.mojom
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/common/indexed_db/indexed_db.typemap
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/common/indexed_db/indexed_db_metadata.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/common/indexed_db/indexed_db_metadata.h
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/common/indexed_db/indexed_db_struct_traits.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/common/indexed_db/indexed_db_struct_traits.h
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/renderer/indexed_db/indexed_db_key_builders.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/content/renderer/indexed_db/indexed_db_key_builders.h
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/third_party/blink/common/BUILD.gn
[rename] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/third_party/blink/common/indexeddb/indexeddb_key_path.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/third_party/blink/common/indexeddb/indexeddb_struct_traits.cc
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/third_party/blink/public/common/BUILD.gn
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/third_party/blink/public/common/indexeddb/indexeddb.typemap
[rename] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/third_party/blink/public/common/indexeddb/indexeddb_key_path.h
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/third_party/blink/public/common/indexeddb/indexeddb_struct_traits.h
[modify] https://crrev.com/850b96f780834ba4baa969d48c378beac6251089/third_party/blink/public/mojom/indexeddb/indexeddb.mojom

Project Member

Comment 23 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33d161d625a8f1760e07b235070f1a375683a88b

commit 33d161d625a8f1760e07b235070f1a375683a88b
Author: Chase Phillips <cmp@chromium.org>
Date: Tue Aug 28 19:44:12 2018

IndexedDB: Move IDB Mojo file to Blink (part 3)

Part 3 in moving the IDB Mojo file from content/common/indexed_db/
to third_party/blink/public/mojom/indexeddb/indexeddb.mojom.  This is
the final IDB Mojo move CL in this series.

Since this moves all of the remaining Mojo types to the Blink IDB Mojo
file, this CL also removes the previous content/common/indexed_db/ Mojo
file and its typemap infrastructure.

This commit:
- Move all classes and structs in content/common/indexed_db/ to Blink
- Random cleanup: remove a "using" call in indexed_db_database.h

This commit converts Chromium to the following Mojom types:
- indexed_db.mojom.Callback -> blink.mojom.IDBCallback
- indexed_db.mojom.Cursor -> blink.mojom.IDBCursor
- indexed_db.mojom.Database -> blink.mojom.IDBDatabase
- indexed_db.mojom.DatabaseCallback -> blink.mojom.IDBDatabaseCallback
- indexed_db.mojom.DatabaseMetadata -> blink.mojom.IDBDatabaseMetadata
- indexed_db.mojom.Factory -> blink.mojom.IDBFactory
- indexed_db.mojom.IndexKeys -> blink.mojom.IDBIndexKeys
- indexed_db.mojom.IndexMetadata -> blink.mojom.IDBIndexMetadata
- indexed_db.mojom.KeyRange -> blink.mojom.IDBKeyRange
- indexed_db.mojom.ObjectStoreMetadata -> blink.mojom.IDBObjectStoreMetadata
- indexed_db.mojom.Observation -> blink.mojom.IDBObserveration
- indexed_db.mojom.ObserverChanges -> blink.mojom.IDBObserverChanges
- indexed_db.mojom.PutMode -> blink.mojom.IDBPutMode
- indexed_db.mojom.ReturnValue -> blink.mojom.IDBReturnValue
- indexed_db.mojom.Status -> blink.mojom.IDBStatus
- indexed_db.mojom.TaskType -> blink.mojom.IDBTaskType
- indexed_db.mojom.TransactionMode -> blink.mojom.IDBTransactionMode

Bug: 717812
Change-Id: Ic1fcfce6efe89c043ca5f5cf06a32477d48419d6
Reviewed-on: https://chromium-review.googlesource.com/1189134
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586817}
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/cursor_impl.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/cursor_impl.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/database_impl.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/database_impl.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/fake_indexed_db_metadata_coding.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/fake_indexed_db_metadata_coding.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_backing_store.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_callbacks.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_callbacks.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_cursor.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_database.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_database_callbacks.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_database_callbacks.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_database_unittest.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_dispatcher_host.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_dispatcher_host.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_factory_unittest.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_fake_backing_store.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_fake_backing_store.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_index_writer.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_index_writer.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_metadata_coding.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_metadata_coding.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_pre_close_task_queue.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_pre_close_task_queue.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_pre_close_task_queue_unittest.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_tombstone_sweeper.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_tombstone_sweeper.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_tombstone_sweeper_unittest.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_transaction.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_transaction.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/indexed_db_unittest.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/mock_indexed_db_callbacks.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/mock_indexed_db_callbacks.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/mock_mojo_indexed_db_callbacks.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/mock_mojo_indexed_db_callbacks.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/mock_mojo_indexed_db_database_callbacks.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/indexed_db/mock_mojo_indexed_db_database_callbacks.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/common/BUILD.gn
[delete] https://crrev.com/6c2527114e7363fe0656c4aaca8e580ae26b1a5b/content/common/indexed_db/indexed_db.mojom
[delete] https://crrev.com/6c2527114e7363fe0656c4aaca8e580ae26b1a5b/content/common/indexed_db/indexed_db.typemap
[delete] https://crrev.com/6c2527114e7363fe0656c4aaca8e580ae26b1a5b/content/common/indexed_db/indexed_db_struct_traits.cc
[delete] https://crrev.com/6c2527114e7363fe0656c4aaca8e580ae26b1a5b/content/common/indexed_db/indexed_db_struct_traits.h
[delete] https://crrev.com/6c2527114e7363fe0656c4aaca8e580ae26b1a5b/content/common/indexed_db/typemaps.gni
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/renderer/indexed_db/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/renderer/indexed_db/indexed_db_callbacks_impl.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/renderer/indexed_db/indexed_db_database_callbacks_impl.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/renderer/indexed_db/indexed_db_database_callbacks_impl.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/renderer/indexed_db/indexed_db_key_builders.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/renderer/indexed_db/indexed_db_key_builders.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/renderer/indexed_db/webidbcursor_impl.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/renderer/indexed_db/webidbcursor_impl.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/renderer/indexed_db/webidbcursor_impl_unittest.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/renderer/indexed_db/webidbdatabase_impl.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/renderer/indexed_db/webidbdatabase_impl.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/renderer/indexed_db/webidbfactory_impl.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/renderer/indexed_db/webidbfactory_impl.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/third_party/blink/common/BUILD.gn
[rename] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/third_party/blink/common/indexeddb/indexeddb_key_range.cc
[rename] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/third_party/blink/common/indexeddb/indexeddb_metadata.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/third_party/blink/common/indexeddb/indexeddb_struct_traits.cc
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/third_party/blink/public/common/BUILD.gn
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/third_party/blink/public/common/indexeddb/indexeddb.typemap
[rename] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/third_party/blink/public/common/indexeddb/indexeddb_key_range.h
[rename] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/third_party/blink/public/common/indexeddb/indexeddb_metadata.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/third_party/blink/public/common/indexeddb/indexeddb_struct_traits.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/third_party/blink/public/mojom/indexeddb/indexeddb.mojom
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/third_party/blink/public/platform/modules/indexeddb/web_idb_cursor.h
[modify] https://crrev.com/33d161d625a8f1760e07b235070f1a375683a88b/third_party/blink/renderer/modules/indexeddb/idb_cursor.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7027bd589dd1e8e891b054324453c1e342f205cc

commit 7027bd589dd1e8e891b054324453c1e342f205cc
Author: Chase Phillips <cmp@chromium.org>
Date: Thu Aug 30 17:31:55 2018

IndexedDB: Remove content/common/indexed_db/

- Remove unused var kNoDatabaseId
- Port constants to Mojo file
- Update WATCHLISTS to remove old paths / add new paths

Bug: 717812
Change-Id: I706d4df3c38cbc95b68d59fefa3632d9e1438f13
Reviewed-on: https://chromium-review.googlesource.com/1194877
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587643}
[modify] https://crrev.com/7027bd589dd1e8e891b054324453c1e342f205cc/WATCHLISTS
[modify] https://crrev.com/7027bd589dd1e8e891b054324453c1e342f205cc/content/browser/indexed_db/indexed_db_callbacks.cc
[modify] https://crrev.com/7027bd589dd1e8e891b054324453c1e342f205cc/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/7027bd589dd1e8e891b054324453c1e342f205cc/content/browser/indexed_db/indexed_db_database.h
[modify] https://crrev.com/7027bd589dd1e8e891b054324453c1e342f205cc/content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.cc
[modify] https://crrev.com/7027bd589dd1e8e891b054324453c1e342f205cc/content/common/BUILD.gn
[delete] https://crrev.com/53e63388501b107ea5c7a2f60518300d91358541/content/common/indexed_db/OWNERS
[delete] https://crrev.com/53e63388501b107ea5c7a2f60518300d91358541/content/common/indexed_db/indexed_db_constants.h
[modify] https://crrev.com/7027bd589dd1e8e891b054324453c1e342f205cc/content/renderer/indexed_db/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/7027bd589dd1e8e891b054324453c1e342f205cc/content/renderer/indexed_db/indexed_db_dispatcher.h
[modify] https://crrev.com/7027bd589dd1e8e891b054324453c1e342f205cc/content/renderer/indexed_db/webidbdatabase_impl.h
[modify] https://crrev.com/7027bd589dd1e8e891b054324453c1e342f205cc/third_party/blink/public/mojom/indexeddb/indexeddb.mojom

Comment 25 by jsb...@chromium.org, Sep 20

Status: Started (was: Assigned)

Project Member

Comment 26 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a71f83c7678e07298f07e1aa8227a1cc875e2d51

commit a71f83c7678e07298f07e1aa8227a1cc875e2d51
Author: Chase Phillips <cmp@chromium.org>
Date: Thu Oct 11 02:55:21 2018

IndexedDB: Upgrade WebIndexKeys type to WebIDBIndexKeys

In preparation for moving content/renderer/ code to Blink,
make WebIndexKeys mirror IndexedDBIndexKeys:
- rename to WebIDBIndexKeys to mirror WebIDB*
- move to web_idb_key.h to mirror indexed_db_key.h
- make this type a std::pair
- update code that used a variable of this type but not this type
  directly to now use this type, too

Bug: 717812
Change-Id: I132052654715201adbbec54a4b6877241db176a1
Reviewed-on: https://chromium-review.googlesource.com/c/1252912
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598647}
[modify] https://crrev.com/a71f83c7678e07298f07e1aa8227a1cc875e2d51/content/renderer/indexed_db/webidbdatabase_impl.cc
[modify] https://crrev.com/a71f83c7678e07298f07e1aa8227a1cc875e2d51/content/renderer/indexed_db/webidbdatabase_impl.h
[modify] https://crrev.com/a71f83c7678e07298f07e1aa8227a1cc875e2d51/content/renderer/indexed_db/webidbdatabase_impl_unittest.cc
[modify] https://crrev.com/a71f83c7678e07298f07e1aa8227a1cc875e2d51/third_party/blink/public/platform/modules/indexeddb/web_idb_database.h
[modify] https://crrev.com/a71f83c7678e07298f07e1aa8227a1cc875e2d51/third_party/blink/public/platform/modules/indexeddb/web_idb_key.h
[modify] https://crrev.com/a71f83c7678e07298f07e1aa8227a1cc875e2d51/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/a71f83c7678e07298f07e1aa8227a1cc875e2d51/third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.h

Project Member

Comment 27 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2419220cabcddb528fbb8777df70860bf0e4df3b

commit 2419220cabcddb528fbb8777df70860bf0e4df3b
Author: Chase Phillips <cmp@chromium.org>
Date: Tue Oct 16 18:05:15 2018

Mojo: Fix Blink-specific export_define_blink directive

Previously, defines in Blink variants would be set to both the
Chromium and the Blink variants export_define* values.  This isn't
correct since Blink variants must export their own defines.

This CL causes Blink variants to only define what's set with
export_define_blink.

Bug: 717812
Change-Id: Ie554cef3044eba6e4ee093098b9c4afedaecd89e
Reviewed-on: https://chromium-review.googlesource.com/c/1282209
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600044}
[modify] https://crrev.com/2419220cabcddb528fbb8777df70860bf0e4df3b/mojo/public/tools/bindings/mojom.gni

Project Member

Comment 28 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b2021433da748e25745cbc9d01ee2407cc1b71a

commit 8b2021433da748e25745cbc9d01ee2407cc1b71a
Author: Chase Phillips <cmp@chromium.org>
Date: Tue Oct 16 19:10:04 2018

Mojo: Add ArrayTraitsWebVector helpers

A planned change will use this from a Blink variant's mojom traits
to natively interact with variables of type WebVector.

Bug: 717812
Change-Id: I844d189c601d3a6310034abeebe51b66a36b3bc5
Reviewed-on: https://chromium-review.googlesource.com/c/1282211
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600068}
[modify] https://crrev.com/8b2021433da748e25745cbc9d01ee2407cc1b71a/mojo/public/cpp/bindings/BUILD.gn
[modify] https://crrev.com/8b2021433da748e25745cbc9d01ee2407cc1b71a/mojo/public/cpp/bindings/DEPS
[add] https://crrev.com/8b2021433da748e25745cbc9d01ee2407cc1b71a/mojo/public/cpp/bindings/array_traits_web_vector.h

Project Member

Comment 29 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd9350a223acfd9f5e540303d51517a2f0d848ca

commit bd9350a223acfd9f5e540303d51517a2f0d848ca
Author: Chase Phillips <cmp@chromium.org>
Date: Tue Oct 23 18:16:02 2018

IndexedDB: Use UnionTraits for IDBKeyData

Coming out of a review for an onion soup CL
(https://crrev.com/c/1265900), mek@ suggested I use a UnionTraits
declaration to handle IDBKey.data and its union type IDBKeyData.

This CL implements that for the current Chromium variant of the
IndexedDB struct traits.

Bug: 717812
Change-Id: I8b599be0218f3542bbfa0fd59efeef1e319df6f6
Reviewed-on: https://chromium-review.googlesource.com/c/1284390
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602024}
[modify] https://crrev.com/bd9350a223acfd9f5e540303d51517a2f0d848ca/third_party/blink/common/indexeddb/indexeddb_struct_traits.cc
[modify] https://crrev.com/bd9350a223acfd9f5e540303d51517a2f0d848ca/third_party/blink/public/common/indexeddb/indexeddb.typemap
[modify] https://crrev.com/bd9350a223acfd9f5e540303d51517a2f0d848ca/third_party/blink/public/common/indexeddb/indexeddb_struct_traits.h

Project Member

Comment 30 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03

commit d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03
Author: Chase Phillips <cmp@chromium.org>
Date: Thu Oct 25 22:49:32 2018

IndexedDB: Move content/renderer/indexed_db/ to Blink

Also in this CL:
- Add a :mojom_modules target to allow mojom files in this group
  to link against symbols that only exist in the modules layer.
- Rename indexed*db_struct_traits* to _mojom_traits*.

Bug: 717812
Change-Id: I85fa493b345bb6ab955316fe1725e4794ed4c99b
Reviewed-on: https://chromium-review.googlesource.com/c/1265900
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602911}
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/content/renderer/BUILD.gn
[delete] https://crrev.com/d3bc867f805378d954075ece8413f8fb0e87b8b0/content/renderer/indexed_db/OWNERS
[delete] https://crrev.com/d3bc867f805378d954075ece8413f8fb0e87b8b0/content/renderer/indexed_db/indexed_db_callbacks_impl.cc
[delete] https://crrev.com/d3bc867f805378d954075ece8413f8fb0e87b8b0/content/renderer/indexed_db/indexed_db_callbacks_impl.h
[delete] https://crrev.com/d3bc867f805378d954075ece8413f8fb0e87b8b0/content/renderer/indexed_db/indexed_db_database_callbacks_impl.h
[delete] https://crrev.com/d3bc867f805378d954075ece8413f8fb0e87b8b0/content/renderer/indexed_db/indexed_db_dispatcher.cc
[delete] https://crrev.com/d3bc867f805378d954075ece8413f8fb0e87b8b0/content/renderer/indexed_db/indexed_db_dispatcher.h
[delete] https://crrev.com/d3bc867f805378d954075ece8413f8fb0e87b8b0/content/renderer/indexed_db/indexed_db_key_builders.h
[delete] https://crrev.com/d3bc867f805378d954075ece8413f8fb0e87b8b0/content/renderer/indexed_db/webidbcursor_impl.h
[delete] https://crrev.com/d3bc867f805378d954075ece8413f8fb0e87b8b0/content/renderer/indexed_db/webidbdatabase_impl.cc
[delete] https://crrev.com/d3bc867f805378d954075ece8413f8fb0e87b8b0/content/renderer/indexed_db/webidbdatabase_impl_unittest.cc
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/content/renderer/render_thread_impl.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/content/test/BUILD.gn
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/content/test/data/indexeddb/cursor_prefetch.js
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/common/BUILD.gn
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/common/indexeddb/OWNERS
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/common/indexeddb/indexeddb_key.cc
[rename] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/common/indexeddb/indexeddb_mojom_traits.cc
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/public/common/BUILD.gn
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/public/common/indexeddb/OWNERS
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/public/common/indexeddb/indexeddb.typemap
[rename] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/public/common/indexeddb/indexeddb_mojom_traits.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/public/platform/modules/indexeddb/indexed_db_key_builder.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/public/platform/modules/indexeddb/web_idb_database_callbacks.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/public/platform/modules/indexeddb/web_idb_key.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/exported/BUILD.gn
[rename] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/exported/indexed_db_key_builder.cc
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/exported/web_idb_key.cc
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/BUILD.gn
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/OWNERS
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/idb_cursor.cc
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/idb_cursor.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/idb_cursor_with_value.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/idb_database.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/idb_factory.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/idb_index.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/idb_key.cc
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/idb_key.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/idb_object_store.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/idb_open_db_request.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/idb_request.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.cc
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/idb_transaction.h
[add] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/indexed_db.typemap
[add] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[add] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.h
[rename] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/indexed_db_database_callbacks_impl.cc
[add] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/indexed_db_database_callbacks_impl.h
[add] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/indexed_db_dispatcher.cc
[add] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/indexed_db_dispatcher.h
[add] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/indexed_db_mojom_traits.cc
[add] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/indexed_db_mojom_traits.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/inspector_indexed_db_agent.cc
[rename] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.cc
[rename] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/mock_web_idb_factory.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[rename] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/web_idb_cursor.h
[rename] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
[add] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.h
[rename] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc
[rename] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/web_idb_database.h
[add] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[rename] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.h
[add] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl_unittest.cc
[rename] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/web_idb_factory.h
[rename] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.cc
[rename] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.h
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/platform/mojo/blink_typemaps.gni
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03/third_party/blink/renderer/platform/testing/testing_platform_support.h

Project Member

Comment 31 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e76b26c998094a9577431f56abeb848bb0255825

commit e76b26c998094a9577431f56abeb848bb0255825
Author: Fredrik Söderquist <fs@opera.com>
Date: Fri Oct 26 09:14:10 2018

[jumbo] Remove 'using' declaration for mojom::blink::IDBCursor

The lone 'IDBCursor' can collide with the blink::IDBCursor. Remove the
'using' and specify the namespace instead.

TBR=pwnall@chromium.org

Bug: 717812
Change-Id: I092b6d3c30931f45d13fd5c35af24539884fa686
Reviewed-on: https://chromium-review.googlesource.com/c/1301434
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#603039}
[modify] https://crrev.com/e76b26c998094a9577431f56abeb848bb0255825/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc

Project Member

Comment 32 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63debc6587a8e13227953c8a25f3ae7c547711c1

commit 63debc6587a8e13227953c8a25f3ae7c547711c1
Author: Chase Phillips <cmp@chromium.org>
Date: Mon Oct 29 19:51:51 2018

Revert "[jumbo] Remove 'using' declaration for mojom::blink::IDBCursor"

This reverts commit e76b26c998094a9577431f56abeb848bb0255825.

Reason for revert:
Reverting the "move content/renderer/indexed_db/ to Blink" CL.  This
commit touches a file that was created by that CL, so reverting it.
See these bugs for more info:
https://crbug.com/899446
https://crbug.com/717812

Original change's description:
> [jumbo] Remove 'using' declaration for mojom::blink::IDBCursor
> 
> The lone 'IDBCursor' can collide with the blink::IDBCursor. Remove the
> 'using' and specify the namespace instead.
> 
> TBR=pwnall@chromium.org
> 
> Bug: 717812
> Change-Id: I092b6d3c30931f45d13fd5c35af24539884fa686
> Reviewed-on: https://chromium-review.googlesource.com/c/1301434
> Commit-Queue: Fredrik Söderquist <fs@opera.com>
> Reviewed-by: Daniel Bratell <bratell@opera.com>
> Cr-Commit-Position: refs/heads/master@{#603039}

TBR=cmp@chromium.org,bratell@opera.com,fs@opera.com,pwnall@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 717812
Change-Id: I29d7de9ef16258d9cc2c6b68d5fb4ac2ad449cca
Reviewed-on: https://chromium-review.googlesource.com/c/1305245
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#603593}
[modify] https://crrev.com/63debc6587a8e13227953c8a25f3ae7c547711c1/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc

Project Member

Comment 33 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/236db7092f734f4323be60a94f553a9b0102da1b

commit 236db7092f734f4323be60a94f553a9b0102da1b
Author: Chase Phillips <cmp@chromium.org>
Date: Tue Oct 30 02:59:40 2018

Revert "IndexedDB: Move content/renderer/indexed_db/ to Blink"

This reverts commit d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03.

Reason for revert:
The "content/renderer/indexed_db move to Blink" change originally
landed as commit d42a4b6fc73f5de8851ee0ee6f64876a5e3efb03.

We received a confirmed report in https://crbug.com/899446 that
in one instance an IndexedDB database had its values replaced with
incorrect values which bisect showed was caused by that change.

We also found a possibly-related issue due to persistence when using
Gmail with offline-enabled.

This change reverts commit d42a4b6fc so the pre-move functionality
is restored while we investigate the cause and come up with a fix.

This also reverts commit a5b50bfe that removed a using declaration.

Original change's description:
> IndexedDB: Move content/renderer/indexed_db/ to Blink
>
> Also in this CL:
> - Add a :mojom_modules target to allow mojom files in this group
>   to link against symbols that only exist in the modules layer.
> - Rename indexed*db_struct_traits* to _mojom_traits*.
>
> Bug: 717812
> Change-Id: I85fa493b345bb6ab955316fe1725e4794ed4c99b
> Reviewed-on: https://chromium-review.googlesource.com/c/1265900
> Commit-Queue: Chase Phillips <cmp@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Joshua Bell <jsbell@chromium.org>
> Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602911}

TBR=cmp@chromium.org,dcheng@chromium.org,jsbell@chromium.org,kinuko@chromium.org,dmurph@chromium.org,mek@chromium.org,reillyg@chromium.org,clamy@chromium.org,haraken@chromium.org,pwnall@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 717812
Bug: 899446
Change-Id: I89ba3b64e3b14158d520ed513355b2ac07a09ad4
Reviewed-on: https://chromium-review.googlesource.com/c/1305243
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603749}
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/BUILD.gn
[add] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/OWNERS
[add] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/indexed_db_callbacks_impl.cc
[add] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/indexed_db_callbacks_impl.h
[rename] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/indexed_db_database_callbacks_impl.cc
[add] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/indexed_db_database_callbacks_impl.h
[add] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/indexed_db_dispatcher.cc
[add] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/indexed_db_dispatcher.h
[rename] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/indexed_db_key_builders.cc
[add] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/indexed_db_key_builders.h
[rename] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/mock_webidbcallbacks.cc
[rename] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/mock_webidbcallbacks.h
[rename] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/webidbcursor_impl.cc
[add] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/webidbcursor_impl.h
[rename] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/webidbcursor_impl_unittest.cc
[add] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/webidbdatabase_impl.cc
[rename] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/webidbdatabase_impl.h
[add] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/webidbdatabase_impl_unittest.cc
[rename] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/webidbfactory_impl.cc
[rename] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/indexed_db/webidbfactory_impl.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/render_thread_impl.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/test/BUILD.gn
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/test/data/indexeddb/cursor_prefetch.js
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/common/BUILD.gn
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/common/indexeddb/OWNERS
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/common/indexeddb/indexeddb_key.cc
[rename] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/common/indexeddb/indexeddb_struct_traits.cc
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/public/common/BUILD.gn
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/public/common/indexeddb/OWNERS
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/public/common/indexeddb/indexeddb.typemap
[rename] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/public/common/indexeddb/indexeddb_struct_traits.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/public/mojom/BUILD.gn
[delete] https://crrev.com/57cea39f336a9465aafdec373867b9c36de9394c/third_party/blink/public/platform/modules/indexeddb/indexed_db_key_builder.h
[rename] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/public/platform/modules/indexeddb/web_idb_cursor.h
[rename] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/public/platform/modules/indexeddb/web_idb_database.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/public/platform/modules/indexeddb/web_idb_database_callbacks.h
[rename] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/public/platform/modules/indexeddb/web_idb_factory.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/public/platform/modules/indexeddb/web_idb_key.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/exported/BUILD.gn
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/exported/web_idb_key.cc
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/BUILD.gn
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/OWNERS
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/idb_cursor.cc
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/idb_cursor.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/idb_cursor_with_value.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/idb_database.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/idb_factory.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/idb_index.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/idb_key.cc
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/idb_key.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/idb_object_store.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/idb_open_db_request.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/idb_request.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.cc
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/idb_transaction.h
[delete] https://crrev.com/57cea39f336a9465aafdec373867b9c36de9394c/third_party/blink/renderer/modules/indexeddb/indexed_db.typemap
[delete] https://crrev.com/57cea39f336a9465aafdec373867b9c36de9394c/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[delete] https://crrev.com/57cea39f336a9465aafdec373867b9c36de9394c/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.h
[delete] https://crrev.com/57cea39f336a9465aafdec373867b9c36de9394c/third_party/blink/renderer/modules/indexeddb/indexed_db_database_callbacks_impl.h
[delete] https://crrev.com/57cea39f336a9465aafdec373867b9c36de9394c/third_party/blink/renderer/modules/indexeddb/indexed_db_dispatcher.cc
[delete] https://crrev.com/57cea39f336a9465aafdec373867b9c36de9394c/third_party/blink/renderer/modules/indexeddb/indexed_db_dispatcher.h
[delete] https://crrev.com/57cea39f336a9465aafdec373867b9c36de9394c/third_party/blink/renderer/modules/indexeddb/indexed_db_mojom_traits.cc
[delete] https://crrev.com/57cea39f336a9465aafdec373867b9c36de9394c/third_party/blink/renderer/modules/indexeddb/indexed_db_mojom_traits.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/inspector_indexed_db_agent.cc
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/mock_web_idb_factory.h
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[delete] https://crrev.com/57cea39f336a9465aafdec373867b9c36de9394c/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.h
[delete] https://crrev.com/57cea39f336a9465aafdec373867b9c36de9394c/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[delete] https://crrev.com/57cea39f336a9465aafdec373867b9c36de9394c/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl_unittest.cc
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/platform/mojo/blink_typemaps.gni
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/236db7092f734f4323be60a94f553a9b0102da1b/third_party/blink/renderer/platform/testing/testing_platform_support.h

Comment 34 by c...@chromium.org, Nov 2

In issue 899446, IndexedDB onion souping led to a new bug where Chrome canary+dev users could not read/write compatible IndexedDB instances with Chrome stable/beta.  That issue is marked fix since master has a revert of the breaking change.

This issue will track a fix to the Mojo IDBValue.bits type to avoid that error going forward.

Project Member

Comment 35 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f62c058237ff43e8b887b883204dfcca05c3fc9

commit 4f62c058237ff43e8b887b883204dfcca05c3fc9
Author: Chase Phillips <cmp@chromium.org>
Date: Tue Nov 06 01:43:51 2018

IndexedDB: Mojom updates: rename files, update return types, move target

- Rename Mojom traits to indexeddb_mojom_traits.{cc,h}, from
  https://crrev.com/c/1265900/9/third_party/blink/renderer/modules/indexeddb/indexed_db_struct_traits.h.

- Update some non-built-in type return values to const-ref, from
  https://crrev.com/c/1265900/26/third_party/blink/renderer/modules/indexeddb/indexed_db_mojom_traits.h@30.

- Add a mojom_modules build target to allow a future Blink variant
  of the IndexedDB Mojo types to access symbols in the modules layer,
  from https://crrev.com/c/1265900.

Bug: 717812
Change-Id: I40f123cdee5bc7ac3102316d6cf20a191b8252a4
Reviewed-on: https://chromium-review.googlesource.com/c/1318374
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605562}
[modify] https://crrev.com/4f62c058237ff43e8b887b883204dfcca05c3fc9/third_party/blink/common/BUILD.gn
[modify] https://crrev.com/4f62c058237ff43e8b887b883204dfcca05c3fc9/third_party/blink/common/indexeddb/OWNERS
[rename] https://crrev.com/4f62c058237ff43e8b887b883204dfcca05c3fc9/third_party/blink/common/indexeddb/indexeddb_mojom_traits.cc
[modify] https://crrev.com/4f62c058237ff43e8b887b883204dfcca05c3fc9/third_party/blink/public/common/BUILD.gn
[modify] https://crrev.com/4f62c058237ff43e8b887b883204dfcca05c3fc9/third_party/blink/public/common/indexeddb/OWNERS
[modify] https://crrev.com/4f62c058237ff43e8b887b883204dfcca05c3fc9/third_party/blink/public/common/indexeddb/indexeddb.typemap
[rename] https://crrev.com/4f62c058237ff43e8b887b883204dfcca05c3fc9/third_party/blink/public/common/indexeddb/indexeddb_mojom_traits.h
[modify] https://crrev.com/4f62c058237ff43e8b887b883204dfcca05c3fc9/third_party/blink/public/mojom/BUILD.gn

Project Member

Comment 36 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/884a9b662680278cc4c75e792fd038f155e3cce2

commit 884a9b662680278cc4c75e792fd038f155e3cce2
Author: Chase Phillips <cmp@chromium.org>
Date: Wed Nov 07 01:09:29 2018

IndexedDB: Add stable DB compatibility tests

Verify that the current version of IndexedDB can read an IndexedDB
instance created by a previous version of Chrome stable.

These DBs were created with Chrome stable version 70.0.3538.77
(Official Build) (64-bit) on Linux.  The webapp used to create the
instances was provided in https://crbug.com/899446 by Victor Costan
<pwnall@chromium.org>.  The noai version is modified from that case
to disable autoincrement.

Bug: 717812
Bug: 899446
Change-Id: I0b293f68cde4d637c53faaabd52b3b27a0ac147c
Reviewed-on: https://chromium-review.googlesource.com/c/1320693
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605908}
[modify] https://crrev.com/884a9b662680278cc4c75e792fd038f155e3cce2/content/browser/indexed_db/indexed_db_browsertest.cc
[add] https://crrev.com/884a9b662680278cc4c75e792fd038f155e3cce2/content/test/data/indexeddb/crbug899446.html
[add] https://crrev.com/884a9b662680278cc4c75e792fd038f155e3cce2/content/test/data/indexeddb/crbug899446.js
[add] https://crrev.com/884a9b662680278cc4c75e792fd038f155e3cce2/content/test/data/indexeddb/crbug899446/file__0.indexeddb.leveldb/000003.log
[add] https://crrev.com/884a9b662680278cc4c75e792fd038f155e3cce2/content/test/data/indexeddb/crbug899446/file__0.indexeddb.leveldb/CURRENT
[add] https://crrev.com/884a9b662680278cc4c75e792fd038f155e3cce2/content/test/data/indexeddb/crbug899446/file__0.indexeddb.leveldb/LOCK
[add] https://crrev.com/884a9b662680278cc4c75e792fd038f155e3cce2/content/test/data/indexeddb/crbug899446/file__0.indexeddb.leveldb/LOG
[add] https://crrev.com/884a9b662680278cc4c75e792fd038f155e3cce2/content/test/data/indexeddb/crbug899446/file__0.indexeddb.leveldb/MANIFEST-000001
[add] https://crrev.com/884a9b662680278cc4c75e792fd038f155e3cce2/content/test/data/indexeddb/crbug899446_noai.html
[add] https://crrev.com/884a9b662680278cc4c75e792fd038f155e3cce2/content/test/data/indexeddb/crbug899446_noai/file__0.indexeddb.leveldb/000003.log
[add] https://crrev.com/884a9b662680278cc4c75e792fd038f155e3cce2/content/test/data/indexeddb/crbug899446_noai/file__0.indexeddb.leveldb/CURRENT
[add] https://crrev.com/884a9b662680278cc4c75e792fd038f155e3cce2/content/test/data/indexeddb/crbug899446_noai/file__0.indexeddb.leveldb/LOCK
[add] https://crrev.com/884a9b662680278cc4c75e792fd038f155e3cce2/content/test/data/indexeddb/crbug899446_noai/file__0.indexeddb.leveldb/LOG
[add] https://crrev.com/884a9b662680278cc4c75e792fd038f155e3cce2/content/test/data/indexeddb/crbug899446_noai/file__0.indexeddb.leveldb/MANIFEST-000001

Project Member

Comment 37 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48bcb8e3f5b21bba8806dfa083aa0e1fa395f061

commit 48bcb8e3f5b21bba8806dfa083aa0e1fa395f061
Author: Chase Phillips <cmp@chromium.org>
Date: Wed Nov 07 01:32:43 2018

IndexedDB: Change Mojo IDBValue.bits type from string to array<uint8>

TL;DR IDBValue.bits was type string which worked until we added a
Mojo Blink variant that introduced a new conversion requirement.
IDBValue.bits is actually a sequence of octets, so use array<uint8>,
instead.

More details:

Chrome's IndexedDB implementation uses a Mojo definition that
specifies the IDBValue struct contains a field |bits|.  The field is
used to represent the data that's written to and read off of disk by
IndexedDB's LevelDB instance.

Previously, the |bits| field was of type string and there were only
content variants of the Mojo C++ bindings for IndexedDB.  This led to
the field only ever being translated to/from std::string.
std::string can contain these raw byte sequences since there are no
constraints placed on the string holding data following any
particular format or validation.

As part of bug 717812 and https://crrev.com/1265900, a new Blink
variant for the IndexedDB Mojo interfaces was added.  The Blink
variant relies on WTF::String instead of std::string, and so the
IDBValue.bits field was translated for that variant to/from
WTF::String.

Mojo's WTF::String traits uses WTF::String::FromUTF8().  As part of
FromUTF8()'s implementation, if the given set of characters contains
invalid UTF-8 data, FromUTF8() will return a null String instance.
The IDBValue.bits field is not restricted just to UTF-8 characters,
and so it always ended up being set to the null String in the traits.

The net result of this bug was that our carriage format changed:

- Chrome with https://crrev.com/1265900 could not read Chrome
  stable's IDB instances

- Chrome without https://crrev.com/1265900 could not read Chrome with
  http://crrev.com/1265900's IDB instances

More about the impact of that bug can be read at
https://crbug.com/899446.

We must observe FromUTF8()'s requirement that we pass only UTF-8
valid data in string types.  We also need to observe that we are in
fact passing raw byte data in the IDBValue.bits field instead of what
both variants would consider as valid strings.

The fix is to change IDBValue.bits from a string type to a type of
array<uint8>.  LevelDB's API requires strings, so in content to/from
the LevelDB instance we must pass in and receive strings.  In Blink,
the data is represented as a WebData instance, which also takes raw
character data.  To support both sides, I've added in-place
conversions to/from std::string and to/from WebData.

Bug: 717812
Change-Id: Iadfbd21be52fc50abc60a2695b95691bc07028e4
Reviewed-on: https://chromium-review.googlesource.com/c/1316444
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605918}
[modify] https://crrev.com/48bcb8e3f5b21bba8806dfa083aa0e1fa395f061/content/browser/indexed_db/database_impl.cc
[modify] https://crrev.com/48bcb8e3f5b21bba8806dfa083aa0e1fa395f061/content/browser/indexed_db/indexed_db_callbacks.cc
[modify] https://crrev.com/48bcb8e3f5b21bba8806dfa083aa0e1fa395f061/content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc
[modify] https://crrev.com/48bcb8e3f5b21bba8806dfa083aa0e1fa395f061/content/renderer/indexed_db/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/48bcb8e3f5b21bba8806dfa083aa0e1fa395f061/content/renderer/indexed_db/webidbdatabase_impl.cc
[modify] https://crrev.com/48bcb8e3f5b21bba8806dfa083aa0e1fa395f061/third_party/blink/public/mojom/indexeddb/indexeddb.mojom
[modify] https://crrev.com/48bcb8e3f5b21bba8806dfa083aa0e1fa395f061/third_party/blink/renderer/bindings/modules/v8/v8_binding_for_modules.cc
[modify] https://crrev.com/48bcb8e3f5b21bba8806dfa083aa0e1fa395f061/third_party/blink/renderer/modules/indexeddb/idb_value_wrapping.h

Project Member

Comment 38 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75935f9b72ce90de4742535a0cea1a96f3f8b789

commit 75935f9b72ce90de4742535a0cea1a96f3f8b789
Author: Chase Phillips <cmp@chromium.org>
Date: Wed Nov 07 21:08:47 2018

Mojo: Change CHECK() on message length to CHECK_LT()

Crash reports from users indicate we sometimes try to send messages
that are too large.  We have code to keep this from happening, but
the code is brittle and apparently some cases can get through.

It would help to know what the relative values are to understand how
our estimates are failing, so change this from CHECK() to CHECK_LT().

Bug: 717812
Bug: 901269
Change-Id: Ic511dae1ea5d96dcb9937fff1207976a40a903f2
Reviewed-on: https://chromium-review.googlesource.com/c/1324091
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606158}
[modify] https://crrev.com/75935f9b72ce90de4742535a0cea1a96f3f8b789/mojo/core/node_channel.cc

Project Member

Comment 39 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9207bf9a8c1f0266bad4050586e63ab34364988

commit d9207bf9a8c1f0266bad4050586e63ab34364988
Author: Chase Phillips <cmp@chromium.org>
Date: Thu Nov 08 02:46:05 2018

IndexedDB: Stricter put size checks

IndexedDB's Put() call from the renderer runs across a Mojo
interface.  The args to the interface call are serialized by Mojo
and then received by the browser process.

Users can submit args to the call that are arbitrary in size.  If the
args are too large, Mojo will detect the message is too large to
send to the browser process and will crash the renderer.

To avoid the crash, we first check the size of the args before
calling the interface method.  Previously, this check only looked
at the value and key args.  Extend the check to also look at the
index_keys arg, which could also be arbitrarily large.

Bug: 901269
Bug: 717812
Change-Id: Ifb67c8c72f2db37a412c6583d8418454dbc85713
Reviewed-on: https://chromium-review.googlesource.com/c/1325078
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606301}
[modify] https://crrev.com/d9207bf9a8c1f0266bad4050586e63ab34364988/content/renderer/indexed_db/webidbdatabase_impl.cc

Project Member

Comment 40 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c07c4f39ed016e7b30d1e707486acd4985eb9c7a

commit c07c4f39ed016e7b30d1e707486acd4985eb9c7a
Author: Chase Phillips <cmp@chromium.org>
Date: Mon Nov 12 22:05:55 2018

IndexedDB: Use ArrayDataView to convert IDBKey binary to std::string

As part of this change, also update the IndexedDBKey
constructors to support std::move().

Bug: 902498
Bug: 717812
Change-Id: Ifd94d01a525850c6293fbfaf28624d3614a419a6
Reviewed-on: https://chromium-review.googlesource.com/c/1321164
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607347}
[modify] https://crrev.com/c07c4f39ed016e7b30d1e707486acd4985eb9c7a/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/c07c4f39ed016e7b30d1e707486acd4985eb9c7a/content/browser/indexed_db/indexed_db_leveldb_coding.cc
[modify] https://crrev.com/c07c4f39ed016e7b30d1e707486acd4985eb9c7a/content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc
[modify] https://crrev.com/c07c4f39ed016e7b30d1e707486acd4985eb9c7a/content/renderer/indexed_db/indexed_db_key_builders.cc
[modify] https://crrev.com/c07c4f39ed016e7b30d1e707486acd4985eb9c7a/third_party/blink/common/indexeddb/indexeddb_key.cc
[modify] https://crrev.com/c07c4f39ed016e7b30d1e707486acd4985eb9c7a/third_party/blink/common/indexeddb/indexeddb_key_unittest.cc
[modify] https://crrev.com/c07c4f39ed016e7b30d1e707486acd4985eb9c7a/third_party/blink/common/indexeddb/indexeddb_mojom_traits.cc
[modify] https://crrev.com/c07c4f39ed016e7b30d1e707486acd4985eb9c7a/third_party/blink/public/common/indexeddb/indexeddb_key.h

Project Member

Comment 41 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd

commit 86293fcec9aa3fc6934d9b51ebcf3faa53da94bd
Author: Chase Phillips <cmp@chromium.org>
Date: Tue Nov 13 21:50:03 2018

IndexedDB: Move content/renderer/indexed_db/ to Blink, take 2

The original CL was reverted due to an IndexedDB
stability issue reported in https://crbug.com/899446.

The stability issue was fixed as part of
commit 48bcb8e3f5b21bba8806dfa083aa0e1fa395f061.  A test
to verify the issue doesn't regress was landed as part of
commit 884a9b662680278cc4c75e792fd038f155e3cce2.

This change was originally a revert of the following commits:
- commit 236db7092f734f4323be60a94f553a9b0102da1b
- commit 63debc6587a8e13227953c8a25f3ae7c547711c1
- commit e14fc0eec15c68760ac5211e6fc15a08d5ce4635

Bug: 717812
Change-Id: I2e1d7a12fa30ccb8cdd5d792f8e7c72b40dc30c8
Reviewed-on: https://chromium-review.googlesource.com/c/1316830
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607753}
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/content/renderer/BUILD.gn
[delete] https://crrev.com/3070fce938f26368aa80073705a2c929de4b84c8/content/renderer/indexed_db/OWNERS
[delete] https://crrev.com/3070fce938f26368aa80073705a2c929de4b84c8/content/renderer/indexed_db/indexed_db_callbacks_impl.cc
[delete] https://crrev.com/3070fce938f26368aa80073705a2c929de4b84c8/content/renderer/indexed_db/indexed_db_callbacks_impl.h
[delete] https://crrev.com/3070fce938f26368aa80073705a2c929de4b84c8/content/renderer/indexed_db/indexed_db_database_callbacks_impl.h
[delete] https://crrev.com/3070fce938f26368aa80073705a2c929de4b84c8/content/renderer/indexed_db/indexed_db_dispatcher.cc
[delete] https://crrev.com/3070fce938f26368aa80073705a2c929de4b84c8/content/renderer/indexed_db/indexed_db_dispatcher.h
[delete] https://crrev.com/3070fce938f26368aa80073705a2c929de4b84c8/content/renderer/indexed_db/indexed_db_key_builders.h
[delete] https://crrev.com/3070fce938f26368aa80073705a2c929de4b84c8/content/renderer/indexed_db/webidbcursor_impl.h
[delete] https://crrev.com/3070fce938f26368aa80073705a2c929de4b84c8/content/renderer/indexed_db/webidbdatabase_impl.cc
[delete] https://crrev.com/3070fce938f26368aa80073705a2c929de4b84c8/content/renderer/indexed_db/webidbdatabase_impl_unittest.cc
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/content/renderer/render_thread_impl.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/content/test/BUILD.gn
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/content/test/data/indexeddb/cursor_prefetch.js
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/common/BUILD.gn
[rename] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/common/indexeddb/indexed_db_default_mojom_traits.cc
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/common/indexeddb/indexeddb_key.cc
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/public/common/BUILD.gn
[add] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/public/common/indexeddb/indexed_db_default.typemap
[rename] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/public/common/indexeddb/indexed_db_default_mojom_traits.h
[delete] https://crrev.com/3070fce938f26368aa80073705a2c929de4b84c8/third_party/blink/public/common/indexeddb/indexeddb.typemap
[add] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/public/platform/modules/indexeddb/indexed_db_key_builder.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/public/platform/modules/indexeddb/web_idb_database_callbacks.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/public/platform/modules/indexeddb/web_idb_key.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/public/public_typemaps.gni
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/exported/BUILD.gn
[rename] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/exported/indexed_db_key_builder.cc
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/exported/web_idb_key.cc
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/BUILD.gn
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/OWNERS
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/idb_cursor.cc
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/idb_cursor.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/idb_cursor_with_value.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/idb_database.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/idb_factory.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/idb_index.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/idb_key.cc
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/idb_key.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/idb_object_store.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/idb_open_db_request.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/idb_request.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.cc
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/idb_transaction.h
[add] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/indexed_db_blink.typemap
[add] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.cc
[add] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.h
[add] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[add] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.h
[rename] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/indexed_db_database_callbacks_impl.cc
[add] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/indexed_db_database_callbacks_impl.h
[add] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/indexed_db_dispatcher.cc
[add] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/indexed_db_dispatcher.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/inspector_indexed_db_agent.cc
[rename] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.cc
[rename] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/mock_web_idb_factory.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[rename] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/web_idb_cursor.h
[rename] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
[add] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.h
[rename] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc
[rename] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/web_idb_database.h
[add] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[rename] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.h
[add] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl_unittest.cc
[rename] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/web_idb_factory.h
[rename] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.cc
[rename] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.h
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/platform/mojo/blink_typemaps.gni
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/86293fcec9aa3fc6934d9b51ebcf3faa53da94bd/third_party/blink/renderer/platform/testing/testing_platform_support.h

Project Member

Comment 42 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ed5b3f456728d0474d563c08561caa34b7faa21

commit 5ed5b3f456728d0474d563c08561caa34b7faa21
Author: Chase Phillips <cmp@chromium.org>
Date: Wed Nov 14 00:05:45 2018

IndexedDB: Remove redundant Web* enums

The following structs were redundant with structs that Mojo
auto-generates:
- WebIDBCursorDirection
- WebIDBDataLoss
- WebIDBOperationType
- WebIDBPutMode
- WebIDBTaskType
- WebIDBTransactionMode

This CL updates those references to refer to the equivalent
blink::mojom:: type, instead.

References to kWebIDB* values are updated to point to the
equivalent value in the associated Mojo enum type.

Bug: 717812
Change-Id: Ie4bf482e4437ec9e5fa61c78086256bc84f8c6df
Reviewed-on: https://chromium-review.googlesource.com/c/1303634
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607823}
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/database_impl.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/database_impl.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_backing_store.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_callbacks.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_callbacks.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_class_factory.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_class_factory.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_connection.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_connection.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_cursor.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_cursor.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_data_loss_info.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_database.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_database_unittest.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_factory_unittest.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_fake_backing_store.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_fake_backing_store.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_observer.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_observer.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_transaction.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_transaction.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_transaction_coordinator.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/indexed_db_transaction_unittest.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/content/browser/indexed_db/mock_mojo_indexed_db_callbacks.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/common/indexeddb/indexed_db_default_mojom_traits.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/public/common/indexeddb/indexed_db_default.typemap
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/public/common/indexeddb/indexed_db_default_mojom_traits.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/public/common/indexeddb/web_idb_types.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/public/mojom/indexeddb/indexeddb.mojom
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/public/platform/modules/indexeddb/web_idb_callbacks.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/public/platform/modules/indexeddb/web_idb_observation.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_cursor.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_cursor.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_cursor_with_value.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_cursor_with_value.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_database.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_index.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_index.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_object_store.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_observation.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_observation.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_observer.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_open_db_request.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_open_db_request.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_request.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_request.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_request_test.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_transaction.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_transaction.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_transaction_test.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_version_change_event.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/idb_version_change_event.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/indexed_db_blink.typemap
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/inspector_indexed_db_agent.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/web_idb_database.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.h
[modify] https://crrev.com/5ed5b3f456728d0474d563c08561caa34b7faa21/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl_unittest.cc

Project Member

Comment 43 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22595ffd9d814b924f5c1dc6a2487090c979ec87

commit 22595ffd9d814b924f5c1dc6a2487090c979ec87
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Thu Nov 15 10:57:50 2018

Revert "IndexedDB: Remove redundant Web* enums"

This reverts commit 5ed5b3f456728d0474d563c08561caa34b7faa21.

Reason for revert: <Fails build "Deterministic Linux" ( https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux/17798)>

Original change's description:
> IndexedDB: Remove redundant Web* enums
> 
> The following structs were redundant with structs that Mojo
> auto-generates:
> - WebIDBCursorDirection
> - WebIDBDataLoss
> - WebIDBOperationType
> - WebIDBPutMode
> - WebIDBTaskType
> - WebIDBTransactionMode
> 
> This CL updates those references to refer to the equivalent
> blink::mojom:: type, instead.
> 
> References to kWebIDB* values are updated to point to the
> equivalent value in the associated Mojo enum type.
> 
> Bug: 717812
> Change-Id: Ie4bf482e4437ec9e5fa61c78086256bc84f8c6df
> Reviewed-on: https://chromium-review.googlesource.com/c/1303634
> Commit-Queue: Chase Phillips <cmp@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607823}

TBR=cmp@chromium.org,dmurph@chromium.org,reillyg@chromium.org,pwnall@chromium.org,dominickn@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 717812
Change-Id: I0a0abf71de45643dba0328ff8fe4b94c26aae750
Reviewed-on: https://chromium-review.googlesource.com/c/1337609
Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608313}
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/database_impl.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/database_impl.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_backing_store.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_callbacks.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_callbacks.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_class_factory.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_class_factory.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_connection.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_connection.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_cursor.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_cursor.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_data_loss_info.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_database.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_database_unittest.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_factory_unittest.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_fake_backing_store.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_fake_backing_store.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_observer.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_observer.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_transaction.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_transaction.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_transaction_coordinator.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/indexed_db_transaction_unittest.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/content/browser/indexed_db/mock_mojo_indexed_db_callbacks.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/common/indexeddb/indexed_db_default_mojom_traits.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/public/common/indexeddb/indexed_db_default.typemap
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/public/common/indexeddb/indexed_db_default_mojom_traits.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/public/common/indexeddb/web_idb_types.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/public/mojom/indexeddb/indexeddb.mojom
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/public/platform/modules/indexeddb/web_idb_callbacks.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/public/platform/modules/indexeddb/web_idb_observation.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_cursor.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_cursor.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_cursor_with_value.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_cursor_with_value.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_database.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_index.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_index.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_object_store.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_observation.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_observation.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_observer.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_open_db_request.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_open_db_request.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_request.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_request.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_request_test.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_transaction.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_transaction.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_transaction_test.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_version_change_event.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/idb_version_change_event.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/indexed_db_blink.typemap
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/inspector_indexed_db_agent.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/web_idb_database.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.h
[modify] https://crrev.com/22595ffd9d814b924f5c1dc6a2487090c979ec87/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl_unittest.cc

Project Member

Comment 44 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88646e780392d991911913b494be9389a172508f

commit 88646e780392d991911913b494be9389a172508f
Author: Chase Phillips <cmp@chromium.org>
Date: Thu Nov 15 23:56:17 2018

Blink generated bindings: Add missing build dependencies

This CL fixes building the following files directly:
- obj/third_party/blink/renderer/bindings/modules/generated/event_modules_factory.o
- obj/third_party/blink/renderer/bindings/modules/v8/bindings_modules_impl/v8_window_partial.o

Marijn Kruisselbrink <mek@chromium.org> did the first version of
this change over IM.

Bug: 717812
Change-Id: I858af8d3be21aad31e6f00b4dcbfd3c3fd6ac010
Reviewed-on: https://chromium-review.googlesource.com/c/1338201
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608585}
[modify] https://crrev.com/88646e780392d991911913b494be9389a172508f/third_party/blink/renderer/bindings/modules/BUILD.gn
[modify] https://crrev.com/88646e780392d991911913b494be9389a172508f/third_party/blink/renderer/bindings/modules/v8/BUILD.gn

Project Member

Comment 45 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2851f32a9955a10f657060c373f7911de46bcd9

commit b2851f32a9955a10f657060c373f7911de46bcd9
Author: Chase Phillips <cmp@chromium.org>
Date: Fri Nov 16 00:27:48 2018

IndexedDB: Remove redundant Web* enums, take 2

This is a reland of a CL that landed here: https://crrev.com/c/1303634
The CL was reverted here: https://crrev.com/c/1337609

The revert was due to a failure in the Deterministic Linux build:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux/17798

That build failed because the Blink modules bindings targets were
missing the IndexedDB Blink variant mojom headers files dependencies.
This reland includes a fix for that issue.

Here's the original commit message, which is still valid:

The following structs were redundant with structs that Mojo
auto-generates:
- WebIDBCursorDirection
- WebIDBDataLoss
- WebIDBOperationType
- WebIDBPutMode
- WebIDBTaskType
- WebIDBTransactionMode

This CL updates those references to refer to the equivalent
blink::mojom:: type, instead.

References to kWebIDB* values are updated to point to the
equivalent value in the associated Mojo enum type.

Bug: 717812
Change-Id: Ic076c67a9a0292fc23cc23667fdd68892e5b0ef9
Reviewed-on: https://chromium-review.googlesource.com/c/1338379
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608597}
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/database_impl.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/database_impl.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_backing_store.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_callbacks.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_callbacks.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_class_factory.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_class_factory.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_connection.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_connection.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_cursor.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_cursor.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_data_loss_info.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_database.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_database_unittest.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_factory_unittest.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_fake_backing_store.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_fake_backing_store.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_observer.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_observer.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_transaction.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_transaction.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_transaction_coordinator.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/indexed_db_transaction_unittest.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/content/browser/indexed_db/mock_mojo_indexed_db_callbacks.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/common/indexeddb/indexed_db_default_mojom_traits.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/public/common/indexeddb/indexed_db_default.typemap
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/public/common/indexeddb/indexed_db_default_mojom_traits.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/public/common/indexeddb/web_idb_types.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/public/mojom/indexeddb/indexeddb.mojom
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/public/platform/modules/indexeddb/web_idb_callbacks.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/public/platform/modules/indexeddb/web_idb_observation.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/bindings/modules/BUILD.gn
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/bindings/modules/v8/BUILD.gn
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_cursor.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_cursor.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_cursor_with_value.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_cursor_with_value.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_database.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_index.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_index.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_object_store.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_observation.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_observation.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_observer.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_open_db_request.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_open_db_request.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_request.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_request.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_request_test.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_transaction.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_transaction.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_transaction_test.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_version_change_event.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/idb_version_change_event.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/indexed_db_blink.typemap
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/inspector_indexed_db_agent.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/web_idb_database.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.h
[modify] https://crrev.com/b2851f32a9955a10f657060c373f7911de46bcd9/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl_unittest.cc

Project Member

Comment 46 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/475eac417c2a433c233e7a19a98291eaf20ac6ad

commit 475eac417c2a433c233e7a19a98291eaf20ac6ad
Author: Chase Phillips <cmp@chromium.org>
Date: Fri Nov 16 01:14:42 2018

IndexedDB: Remove UMA collection for total database open time

These metrics were added here: https://crrev.com/470373002

From a review of whether we use this today, these are no longer
used/needed.

Bug: 717812, 397552, 395799
Change-Id: I1b296832a7ed87fb9653be9eb83cc2b3eb8ef6b1
Reviewed-on: https://chromium-review.googlesource.com/c/1336429
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608613}
[modify] https://crrev.com/475eac417c2a433c233e7a19a98291eaf20ac6ad/content/browser/indexed_db/indexed_db_callbacks.cc
[modify] https://crrev.com/475eac417c2a433c233e7a19a98291eaf20ac6ad/content/browser/indexed_db/indexed_db_callbacks.h
[modify] https://crrev.com/475eac417c2a433c233e7a19a98291eaf20ac6ad/content/browser/indexed_db/indexed_db_dispatcher_host.cc
[modify] https://crrev.com/475eac417c2a433c233e7a19a98291eaf20ac6ad/tools/metrics/histograms/histograms.xml

Project Member

Comment 47 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9d394a6c8e78cc30215cd3a4e7dccf725659363

commit d9d394a6c8e78cc30215cd3a4e7dccf725659363
Author: Chase Phillips <cmp@chromium.org>
Date: Mon Nov 19 20:42:38 2018

IndexedDB: Move helpers out of IndexedDBCallbacks so they're accessible

This CL:
- Moves ConvertReturnValue to IndexedDBReturnValue
- Moves ConvertBlobInfo to IndexedDBBlobInfo
- Moves ConvertAndEraseValue to IndexedDBValue

These are needed by a later change to move code out of
IndexedDBCallbacks and use Mojo's native async return calls, instead.

Bug: 717812
Change-Id: I9f02a26eb024a3e790eddc16185d426cf530108e
Reviewed-on: https://chromium-review.googlesource.com/c/1336660
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609420}
[modify] https://crrev.com/d9d394a6c8e78cc30215cd3a4e7dccf725659363/content/browser/BUILD.gn
[modify] https://crrev.com/d9d394a6c8e78cc30215cd3a4e7dccf725659363/content/browser/indexed_db/indexed_db_blob_info.cc
[modify] https://crrev.com/d9d394a6c8e78cc30215cd3a4e7dccf725659363/content/browser/indexed_db/indexed_db_blob_info.h
[modify] https://crrev.com/d9d394a6c8e78cc30215cd3a4e7dccf725659363/content/browser/indexed_db/indexed_db_callbacks.cc
[modify] https://crrev.com/d9d394a6c8e78cc30215cd3a4e7dccf725659363/content/browser/indexed_db/indexed_db_callbacks.h
[modify] https://crrev.com/d9d394a6c8e78cc30215cd3a4e7dccf725659363/content/browser/indexed_db/indexed_db_database.cc
[add] https://crrev.com/d9d394a6c8e78cc30215cd3a4e7dccf725659363/content/browser/indexed_db/indexed_db_return_value.cc
[modify] https://crrev.com/d9d394a6c8e78cc30215cd3a4e7dccf725659363/content/browser/indexed_db/indexed_db_return_value.h
[modify] https://crrev.com/d9d394a6c8e78cc30215cd3a4e7dccf725659363/content/browser/indexed_db/indexed_db_value.cc
[modify] https://crrev.com/d9d394a6c8e78cc30215cd3a4e7dccf725659363/content/browser/indexed_db/indexed_db_value.h

Project Member

Comment 48 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1

commit c64131bb15ab11a50dc31e1b0ec94392ff1e0de1
Author: Chase Phillips <cmp@chromium.org>
Date: Mon Dec 03 19:30:23 2018

IndexedDB: Remap Blink variant metadata typemaps to modules types

Bug: 717812
Change-Id: I6d53865348171ba2fe777a8730b08248d05e7f26
Reviewed-on: https://chromium-review.googlesource.com/c/1344222
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613193}
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/common/indexeddb/indexed_db_default_mojom_traits.cc
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/public/common/indexeddb/indexed_db_default_mojom_traits.h
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/public/mojom/indexeddb/indexeddb.mojom
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/public/platform/modules/indexeddb/web_idb_callbacks.h
[delete] https://crrev.com/0f4225cf68370bf4020aaead4dca2a85cc5d04ca/third_party/blink/public/platform/modules/indexeddb/web_idb_metadata.h
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/renderer/modules/indexeddb/idb_metadata.cc
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/renderer/modules/indexeddb/idb_metadata.h
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/renderer/modules/indexeddb/idb_request_test.cc
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/renderer/modules/indexeddb/indexed_db_blink.typemap
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.cc
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.h
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.h
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/renderer/modules/indexeddb/web_idb_database.h
[modify] https://crrev.com/c64131bb15ab11a50dc31e1b0ec94392ff1e0de1/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc

Project Member

Comment 49 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/516f60ea1ee50263917d95cca718956deefa0160

commit 516f60ea1ee50263917d95cca718956deefa0160
Author: Chase Phillips <cmp@chromium.org>
Date: Tue Dec 04 17:39:36 2018

IndexedDB: Remove IDBDatalessKeyType

Bug: 717812
Change-Id: I3c1d02d94c694c5fa1149066e7b5edd8b10d5ab7
Reviewed-on: https://chromium-review.googlesource.com/c/1352585
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613586}
[modify] https://crrev.com/516f60ea1ee50263917d95cca718956deefa0160/third_party/blink/common/indexeddb/indexed_db_default_mojom_traits.cc
[modify] https://crrev.com/516f60ea1ee50263917d95cca718956deefa0160/third_party/blink/public/common/indexeddb/indexed_db_default_mojom_traits.h
[modify] https://crrev.com/516f60ea1ee50263917d95cca718956deefa0160/third_party/blink/public/mojom/indexeddb/indexeddb.mojom
[modify] https://crrev.com/516f60ea1ee50263917d95cca718956deefa0160/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.cc
[modify] https://crrev.com/516f60ea1ee50263917d95cca718956deefa0160/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.h

Project Member

Comment 50 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4

commit d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4
Author: Chase Phillips <cmp@chromium.org>
Date: Tue Dec 04 18:38:38 2018

IndexedDB: Convert key types to mojom enum

Bug: 717812
Change-Id: Iaef4a1c54a0bbc5247df668f5ab5f33d5c7d5e1b
Reviewed-on: https://chromium-review.googlesource.com/c/1352622
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613613}
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/content/browser/indexed_db/indexed_db_leveldb_coding.cc
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/content/browser/indexed_db/indexed_db_tombstone_sweeper_unittest.cc
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/common/indexeddb/indexed_db_default_mojom_traits.cc
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/common/indexeddb/indexeddb_key.cc
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/common/indexeddb/indexeddb_key_unittest.cc
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/public/common/indexeddb/indexed_db_default_mojom_traits.h
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/public/common/indexeddb/indexeddb_key.h
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/public/common/indexeddb/indexeddb_key_range.h
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/public/common/indexeddb/web_idb_types.h
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/public/mojom/indexeddb/indexeddb.mojom
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/public/platform/modules/indexeddb/web_idb_key.h
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/renderer/bindings/modules/v8/v8_binding_for_modules.cc
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/renderer/bindings/modules/v8/v8_binding_for_modules_test.cc
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/renderer/modules/exported/indexed_db_key_builder.cc
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/renderer/modules/exported/web_idb_key.cc
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/renderer/modules/indexeddb/idb_key.cc
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/renderer/modules/indexeddb/idb_key.h
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.cc
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.h
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
[modify] https://crrev.com/d5e40f4979fcf0b932d20aa29f5e6b9275ef09d4/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc

Project Member

Comment 51 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/918021be777af93959f06bae5f33245e581459b5

commit 918021be777af93959f06bae5f33245e581459b5
Author: Chase Phillips <cmp@chromium.org>
Date: Wed Dec 05 19:45:55 2018

IndexedDB: Convert key path types to mojom enum

Bug: 717812
Change-Id: I50a9e758275ff55b927cdd2290f3ec4325194046
Reviewed-on: https://chromium-review.googlesource.com/c/1352623
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614066}
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/content/browser/indexed_db/indexed_db_leveldb_coding.cc
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/content/browser/indexed_db/indexed_db_metadata_coding.cc
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/third_party/blink/common/indexeddb/indexed_db_default_mojom_traits.cc
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/third_party/blink/common/indexeddb/indexeddb_key_path.cc
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/third_party/blink/public/common/indexeddb/indexeddb_key_path.h
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/third_party/blink/public/common/indexeddb/web_idb_types.h
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/third_party/blink/public/mojom/indexeddb/indexeddb.mojom
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/third_party/blink/public/platform/modules/indexeddb/web_idb_key_path.h
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/third_party/blink/renderer/bindings/modules/v8/v8_binding_for_modules.cc
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/third_party/blink/renderer/modules/exported/indexed_db_key_builder.cc
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/third_party/blink/renderer/modules/indexeddb/idb_key_path.cc
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/third_party/blink/renderer/modules/indexeddb/idb_key_path.h
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/third_party/blink/renderer/modules/indexeddb/idb_key_path_test.cc
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.cc
[modify] https://crrev.com/918021be777af93959f06bae5f33245e581459b5/third_party/blink/renderer/modules/indexeddb/inspector_indexed_db_agent.cc

Project Member

Comment 52 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08d8dc542dcca9bcd2fb1057ed42893f17da8d08

commit 08d8dc542dcca9bcd2fb1057ed42893f17da8d08
Author: Chase Phillips <cmp@chromium.org>
Date: Thu Dec 06 02:30:36 2018

IndexedDB: No-op move of files to renderer/modules/indexeddb/

This change is a no-op move of files from:
- public/platform/modules/indexeddb/
- renderer/modules/exported/

to renderer/modules/indexeddb/.  Moving these all at once will allow
later CLs to be smaller and clearer.

Bug: 717812
Change-Id: I9952ca8a5d2e220f936662ab4640d26337daa56d
Reviewed-on: https://chromium-review.googlesource.com/c/1352624
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614241}
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/public/BUILD.gn
[delete] https://crrev.com/c186829bed25f00c5e207cb2344946ea59c2137e/third_party/blink/public/platform/modules/indexeddb/web_idb_name_and_version.h
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/bindings/modules/v8/v8_binding_for_modules_test.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/exported/BUILD.gn
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/BUILD.gn
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/idb_cursor.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/idb_database.h
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/idb_database_callbacks.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/idb_database_callbacks.h
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/idb_factory_test.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/idb_index.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/idb_key.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/idb_key.h
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/idb_key_path.h
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/idb_observation.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/idb_observer_changes.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/idb_request_test.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/idb_value.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/indexed_db_blink.typemap
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.h
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/indexed_db_database_callbacks_impl.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/indexed_db_dispatcher.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/indexed_db_dispatcher.h
[rename] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/indexed_db_key_builder.cc
[rename] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/indexed_db_key_builder.h
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.h
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/mock_web_idb_factory.h
[rename] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks.h
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_cursor.h
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.h
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc
[rename] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_database_callbacks.h
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_database_callbacks_impl.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_database_callbacks_impl.h
[rename] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_database_error.h
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[modify] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.h
[rename] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_key.cc
[rename] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_key.h
[rename] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_key_path.h
[rename] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_key_range.cc
[rename] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_key_range.h
[add] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_name_and_version.h
[rename] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_observation.h
[rename] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_value.cc
[rename] https://crrev.com/08d8dc542dcca9bcd2fb1057ed42893f17da8d08/third_party/blink/renderer/modules/indexeddb/web_idb_value.h

Project Member

Comment 53 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f56c0db093f876ac4dc8326b4ef396f458053ce4

commit f56c0db093f876ac4dc8326b4ef396f458053ce4
Author: Chase Phillips <cmp@chromium.org>
Date: Thu Dec 06 19:11:10 2018

IndexedDB: Map mojom key to blink IDBKey

Bug: 717812
Change-Id: I59d74bd808e2a7e30264ec3a8dafd30964552f0a
Reviewed-on: https://chromium-review.googlesource.com/c/1354334
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614438}
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/bindings/modules/v8/v8_binding_for_modules_test.cc
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/BUILD.gn
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/idb_cursor.cc
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/idb_key.cc
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/idb_key.h
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/idb_value.cc
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/idb_value.h
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/indexed_db_blink.typemap
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.cc
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.h
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.h
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/indexed_db_key_builder.cc
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/indexed_db_key_builder.h
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.cc
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.cc
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.h
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks.h
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/web_idb_cursor.h
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.h
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/web_idb_database.h
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.h
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl_unittest.cc
[delete] https://crrev.com/d810f68079066a4a8f9e9a3c3730fc1bcdf72f7a/third_party/blink/renderer/modules/indexeddb/web_idb_key.cc
[delete] https://crrev.com/d810f68079066a4a8f9e9a3c3730fc1bcdf72f7a/third_party/blink/renderer/modules/indexeddb/web_idb_key.h
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/web_idb_key_range.cc
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/web_idb_key_range.h
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/web_idb_value.cc
[modify] https://crrev.com/f56c0db093f876ac4dc8326b4ef396f458053ce4/third_party/blink/renderer/modules/indexeddb/web_idb_value.h

Project Member

Comment 54 by bugdroid1@chromium.org, Dec 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08

commit c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08
Author: Chase Phillips <cmp@chromium.org>
Date: Sat Dec 08 00:54:16 2018

IndexedDB: map key range mojom to blink IDBKeyRange

Bug: 717812
Change-Id: I0cacbf8a384af330978ccc4ea72e755427b84d1b
Reviewed-on: https://chromium-review.googlesource.com/c/1357535
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614890}
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/BUILD.gn
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/idb_cursor.cc
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/idb_index.cc
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/idb_key.cc
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/idb_key_range.h
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/indexed_db_blink.typemap
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.cc
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.h
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/indexed_db_database_callbacks_impl.cc
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/indexed_db_key_builder.cc
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/indexed_db_key_builder.h
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.h
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/web_idb_database.h
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.h
[delete] https://crrev.com/a54d576cb356b3e7e8d07e503800d07fb6dec20b/third_party/blink/renderer/modules/indexeddb/web_idb_key_range.cc
[delete] https://crrev.com/a54d576cb356b3e7e8d07e503800d07fb6dec20b/third_party/blink/renderer/modules/indexeddb/web_idb_key_range.h
[modify] https://crrev.com/c3dbe1089c4ab38f4fc7ab65dbbaa84c24d57c08/third_party/blink/renderer/modules/indexeddb/web_idb_observation.h

Project Member

Comment 55 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd

commit 62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd
Author: Chase Phillips <cmp@chromium.org>
Date: Tue Dec 11 18:31:50 2018

IndexedDB: Convert WebIDBValue usage to blink IDBValue

Bug: 717812
Change-Id: I90c36249357705d3a1bc215b8c02278f59993622
Reviewed-on: https://chromium-review.googlesource.com/c/1359862
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615600}
[modify] https://crrev.com/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd/third_party/blink/renderer/bindings/modules/v8/v8_binding_for_modules_test.cc
[modify] https://crrev.com/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd/third_party/blink/renderer/modules/indexeddb/BUILD.gn
[modify] https://crrev.com/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd/third_party/blink/renderer/modules/indexeddb/idb_observation.cc
[modify] https://crrev.com/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd/third_party/blink/renderer/modules/indexeddb/idb_value.cc
[modify] https://crrev.com/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd/third_party/blink/renderer/modules/indexeddb/idb_value.h
[modify] https://crrev.com/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.h
[modify] https://crrev.com/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.cc
[modify] https://crrev.com/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
[modify] https://crrev.com/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks.h
[modify] https://crrev.com/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[modify] https://crrev.com/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
[modify] https://crrev.com/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
[modify] https://crrev.com/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.h
[modify] https://crrev.com/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc
[modify] https://crrev.com/62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd/third_party/blink/renderer/modules/indexeddb/web_idb_observation.h
[delete] https://crrev.com/124b041802d8db51ff1614ff429a3389acd5cdfc/third_party/blink/renderer/modules/indexeddb/web_idb_value.cc
[delete] https://crrev.com/124b041802d8db51ff1614ff429a3389acd5cdfc/third_party/blink/renderer/modules/indexeddb/web_idb_value.h

Project Member

Comment 56 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca2cd26239cf17353469479c6b9461daef775e71

commit ca2cd26239cf17353469479c6b9461daef775e71
Author: Chase Phillips <cmp@chromium.org>
Date: Wed Dec 12 19:17:06 2018

IndexedDB: Remove WebData usage from frontend

Bug: 717812
Change-Id: I4d69b9b5093df319f7c47df3c93794108a0bb451
Reviewed-on: https://chromium-review.googlesource.com/c/1364301
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615989}
[modify] https://crrev.com/ca2cd26239cf17353469479c6b9461daef775e71/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/ca2cd26239cf17353469479c6b9461daef775e71/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/ca2cd26239cf17353469479c6b9461daef775e71/third_party/blink/renderer/modules/indexeddb/idb_value.cc
[modify] https://crrev.com/ca2cd26239cf17353469479c6b9461daef775e71/third_party/blink/renderer/modules/indexeddb/idb_value.h
[modify] https://crrev.com/ca2cd26239cf17353469479c6b9461daef775e71/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.cc
[add] https://crrev.com/ca2cd26239cf17353469479c6b9461daef775e71/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits_test.cc
[modify] https://crrev.com/ca2cd26239cf17353469479c6b9461daef775e71/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/ca2cd26239cf17353469479c6b9461daef775e71/third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.cc
[modify] https://crrev.com/ca2cd26239cf17353469479c6b9461daef775e71/third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.h
[modify] https://crrev.com/ca2cd26239cf17353469479c6b9461daef775e71/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
[modify] https://crrev.com/ca2cd26239cf17353469479c6b9461daef775e71/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc
[modify] https://crrev.com/ca2cd26239cf17353469479c6b9461daef775e71/third_party/blink/renderer/modules/indexeddb/web_idb_database.h
[modify] https://crrev.com/ca2cd26239cf17353469479c6b9461daef775e71/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[modify] https://crrev.com/ca2cd26239cf17353469479c6b9461daef775e71/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.h
[modify] https://crrev.com/ca2cd26239cf17353469479c6b9461daef775e71/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl_unittest.cc
[modify] https://crrev.com/ca2cd26239cf17353469479c6b9461daef775e71/third_party/blink/renderer/platform/shared_buffer.h

Project Member

Comment 57 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1667e0cf1e4edc7e0267d1016d25a4a1cd428a88

commit 1667e0cf1e4edc7e0267d1016d25a4a1cd428a88
Author: Chase Phillips <cmp@chromium.org>
Date: Wed Dec 12 23:26:26 2018

IndexedDB: Add Mojom typemap for IDBValue

Bug: 717812
Change-Id: I33dd0fda6b109fbc822e784b3aa490cedef401ca
Reviewed-on: https://chromium-review.googlesource.com/c/1364302
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616102}
[modify] https://crrev.com/1667e0cf1e4edc7e0267d1016d25a4a1cd428a88/third_party/blink/renderer/modules/indexeddb/DEPS
[modify] https://crrev.com/1667e0cf1e4edc7e0267d1016d25a4a1cd428a88/third_party/blink/renderer/modules/indexeddb/indexed_db_blink.typemap
[modify] https://crrev.com/1667e0cf1e4edc7e0267d1016d25a4a1cd428a88/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.cc
[modify] https://crrev.com/1667e0cf1e4edc7e0267d1016d25a4a1cd428a88/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.h
[modify] https://crrev.com/1667e0cf1e4edc7e0267d1016d25a4a1cd428a88/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits_test.cc
[modify] https://crrev.com/1667e0cf1e4edc7e0267d1016d25a4a1cd428a88/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/1667e0cf1e4edc7e0267d1016d25a4a1cd428a88/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.h
[modify] https://crrev.com/1667e0cf1e4edc7e0267d1016d25a4a1cd428a88/third_party/blink/renderer/modules/indexeddb/indexed_db_database_callbacks_impl.cc
[modify] https://crrev.com/1667e0cf1e4edc7e0267d1016d25a4a1cd428a88/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.h
[modify] https://crrev.com/1667e0cf1e4edc7e0267d1016d25a4a1cd428a88/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[modify] https://crrev.com/1667e0cf1e4edc7e0267d1016d25a4a1cd428a88/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl_unittest.cc

Project Member

Comment 58 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f678a2cd195b74eddf1db57e544ff51d65c7b61e

commit f678a2cd195b74eddf1db57e544ff51d65c7b61e
Author: Chase Phillips <cmp@chromium.org>
Date: Thu Dec 13 01:15:17 2018

IndexedDB: Update Put() to take a std::unique_ptr<IDBValue>

Bug: 717812
Change-Id: I52e4267fa84c3dedc6a4041662427d9c968dc19f
Reviewed-on: https://chromium-review.googlesource.com/c/1364226
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616139}
[modify] https://crrev.com/f678a2cd195b74eddf1db57e544ff51d65c7b61e/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/f678a2cd195b74eddf1db57e544ff51d65c7b61e/third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.h
[modify] https://crrev.com/f678a2cd195b74eddf1db57e544ff51d65c7b61e/third_party/blink/renderer/modules/indexeddb/web_idb_database.h
[modify] https://crrev.com/f678a2cd195b74eddf1db57e544ff51d65c7b61e/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[modify] https://crrev.com/f678a2cd195b74eddf1db57e544ff51d65c7b61e/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.h
[modify] https://crrev.com/f678a2cd195b74eddf1db57e544ff51d65c7b61e/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl_unittest.cc

Project Member

Comment 59 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1e3f767c54b6614dd9fdb0138438893a999d69d

commit b1e3f767c54b6614dd9fdb0138438893a999d69d
Author: Chase Phillips <cmp@chromium.org>
Date: Thu Dec 13 23:45:27 2018

IndexedDB: Stop using WebString and WebVector

A couple uses remain since other components in Blink use these
classes.

Bug: 717812
Change-Id: Ia32b6f2addb614d68a379809888edfbef46bca3a
Reviewed-on: https://chromium-review.googlesource.com/c/1361831
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616499}
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/bindings/modules/v8/v8_binding_for_modules_test.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/idb_database.h
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/idb_database_callbacks.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/idb_database_callbacks.h
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/idb_factory_test.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/idb_key.h
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/idb_key_path.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/idb_observer_changes.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/idb_observer_changes.h
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/idb_value.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/idb_value.h
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/idb_value_wrapping_test.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/indexed_db_blink.typemap
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.h
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits_test.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/indexed_db_database_callbacks_impl.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/mock_web_idb_factory.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/mock_web_idb_factory.h
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks.h
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/web_idb_cursor.h
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/web_idb_database_callbacks.h
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/web_idb_database_callbacks_impl.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/web_idb_database_callbacks_impl.h
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/web_idb_database_error.h
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/web_idb_factory.h
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.cc
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.h
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/web_idb_key_path.h
[modify] https://crrev.com/b1e3f767c54b6614dd9fdb0138438893a999d69d/third_party/blink/renderer/modules/indexeddb/web_idb_name_and_version.h

Project Member

Comment 60 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b94ed2814e203e0960d0e70708f02e7b9962c699

commit b94ed2814e203e0960d0e70708f02e7b9962c699
Author: Chase Phillips <cmp@chromium.org>
Date: Fri Dec 14 17:45:28 2018

IndexedDB: Remove WebIDBKeyPath

Bug: 717812
Change-Id: I45942eef81822ba0de88d60bbda9297e00587d4e
Reviewed-on: https://chromium-review.googlesource.com/c/1364342
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616732}
[modify] https://crrev.com/b94ed2814e203e0960d0e70708f02e7b9962c699/third_party/blink/renderer/bindings/modules/v8/v8_binding_for_modules_test.cc
[modify] https://crrev.com/b94ed2814e203e0960d0e70708f02e7b9962c699/third_party/blink/renderer/modules/indexeddb/BUILD.gn
[modify] https://crrev.com/b94ed2814e203e0960d0e70708f02e7b9962c699/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/b94ed2814e203e0960d0e70708f02e7b9962c699/third_party/blink/renderer/modules/indexeddb/idb_key_path.cc
[modify] https://crrev.com/b94ed2814e203e0960d0e70708f02e7b9962c699/third_party/blink/renderer/modules/indexeddb/idb_key_path.h
[modify] https://crrev.com/b94ed2814e203e0960d0e70708f02e7b9962c699/third_party/blink/renderer/modules/indexeddb/indexed_db_blink.typemap
[modify] https://crrev.com/b94ed2814e203e0960d0e70708f02e7b9962c699/third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.h
[modify] https://crrev.com/b94ed2814e203e0960d0e70708f02e7b9962c699/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[modify] https://crrev.com/b94ed2814e203e0960d0e70708f02e7b9962c699/third_party/blink/renderer/modules/indexeddb/web_idb_database.h
[modify] https://crrev.com/b94ed2814e203e0960d0e70708f02e7b9962c699/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[modify] https://crrev.com/b94ed2814e203e0960d0e70708f02e7b9962c699/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.h
[delete] https://crrev.com/0622dfff1f4b5b3aa7e6b818bc9e7119c5e8d697/third_party/blink/renderer/modules/indexeddb/web_idb_key_path.h

Project Member

Comment 61 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f12481667e5cd327ae64c06556ac1d7d0ed8e268

commit f12481667e5cd327ae64c06556ac1d7d0ed8e268
Author: Chase Phillips <cmp@chromium.org>
Date: Fri Dec 14 19:04:48 2018

IndexedDB: Rename WebIDBNameAndVersion to IDBNameAndVersion

Bug: 717812
Change-Id: Iad2535883687a6302ebd96a092329c4f1fe91efd
Reviewed-on: https://chromium-review.googlesource.com/c/1364343
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616774}
[modify] https://crrev.com/f12481667e5cd327ae64c06556ac1d7d0ed8e268/third_party/blink/renderer/modules/indexeddb/BUILD.gn
[modify] https://crrev.com/f12481667e5cd327ae64c06556ac1d7d0ed8e268/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/f12481667e5cd327ae64c06556ac1d7d0ed8e268/third_party/blink/renderer/modules/indexeddb/idb_factory_test.cc
[add] https://crrev.com/f12481667e5cd327ae64c06556ac1d7d0ed8e268/third_party/blink/renderer/modules/indexeddb/idb_name_and_version.h
[modify] https://crrev.com/f12481667e5cd327ae64c06556ac1d7d0ed8e268/third_party/blink/renderer/modules/indexeddb/indexed_db_blink.typemap
[modify] https://crrev.com/f12481667e5cd327ae64c06556ac1d7d0ed8e268/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/f12481667e5cd327ae64c06556ac1d7d0ed8e268/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
[modify] https://crrev.com/f12481667e5cd327ae64c06556ac1d7d0ed8e268/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks.h
[modify] https://crrev.com/f12481667e5cd327ae64c06556ac1d7d0ed8e268/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[modify] https://crrev.com/f12481667e5cd327ae64c06556ac1d7d0ed8e268/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
[delete] https://crrev.com/0db12a5791138dff507e3868349c7b33df03d117/third_party/blink/renderer/modules/indexeddb/web_idb_name_and_version.h

Project Member

Comment 62 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/757f8d9d1c2317cd3bd0338934bb6b32f3d5b5cd

commit 757f8d9d1c2317cd3bd0338934bb6b32f3d5b5cd
Author: Chase Phillips <cmp@chromium.org>
Date: Fri Dec 14 20:30:36 2018

IndexedDB: Update IDBObserverChanges to stop using WebIDBObservation

Bug: 717812
Change-Id: I2bd4419ce86555ed0041d07a23adc31cdc0d4253
Reviewed-on: https://chromium-review.googlesource.com/c/1366478
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616809}
[modify] https://crrev.com/757f8d9d1c2317cd3bd0338934bb6b32f3d5b5cd/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/757f8d9d1c2317cd3bd0338934bb6b32f3d5b5cd/third_party/blink/renderer/modules/indexeddb/idb_observation.cc
[modify] https://crrev.com/757f8d9d1c2317cd3bd0338934bb6b32f3d5b5cd/third_party/blink/renderer/modules/indexeddb/idb_observation.h
[modify] https://crrev.com/757f8d9d1c2317cd3bd0338934bb6b32f3d5b5cd/third_party/blink/renderer/modules/indexeddb/idb_observer_changes.cc
[modify] https://crrev.com/757f8d9d1c2317cd3bd0338934bb6b32f3d5b5cd/third_party/blink/renderer/modules/indexeddb/idb_observer_changes.h

Project Member

Comment 63 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82d4392c0d563881b2aacfb9710408703a02595a

commit 82d4392c0d563881b2aacfb9710408703a02595a
Author: Chase Phillips <cmp@chromium.org>
Date: Fri Dec 14 21:19:27 2018

IndexedDB: Stop using WebIDBObservation

Bug: 717812
Change-Id: Ib9f9b6e4cd2fcd9ad1fdd8c7d83a314655f3ded8
Reviewed-on: https://chromium-review.googlesource.com/c/1366440
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616825}
[modify] https://crrev.com/82d4392c0d563881b2aacfb9710408703a02595a/third_party/blink/renderer/modules/indexeddb/BUILD.gn
[modify] https://crrev.com/82d4392c0d563881b2aacfb9710408703a02595a/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/82d4392c0d563881b2aacfb9710408703a02595a/third_party/blink/renderer/modules/indexeddb/idb_database.h
[modify] https://crrev.com/82d4392c0d563881b2aacfb9710408703a02595a/third_party/blink/renderer/modules/indexeddb/idb_database_callbacks.cc
[modify] https://crrev.com/82d4392c0d563881b2aacfb9710408703a02595a/third_party/blink/renderer/modules/indexeddb/idb_database_callbacks.h
[modify] https://crrev.com/82d4392c0d563881b2aacfb9710408703a02595a/third_party/blink/renderer/modules/indexeddb/idb_observation.cc
[modify] https://crrev.com/82d4392c0d563881b2aacfb9710408703a02595a/third_party/blink/renderer/modules/indexeddb/idb_observation.h
[modify] https://crrev.com/82d4392c0d563881b2aacfb9710408703a02595a/third_party/blink/renderer/modules/indexeddb/idb_observer_changes.cc
[modify] https://crrev.com/82d4392c0d563881b2aacfb9710408703a02595a/third_party/blink/renderer/modules/indexeddb/idb_observer_changes.h
[modify] https://crrev.com/82d4392c0d563881b2aacfb9710408703a02595a/third_party/blink/renderer/modules/indexeddb/indexed_db_database_callbacks_impl.cc
[modify] https://crrev.com/82d4392c0d563881b2aacfb9710408703a02595a/third_party/blink/renderer/modules/indexeddb/indexed_db_dispatcher.cc
[modify] https://crrev.com/82d4392c0d563881b2aacfb9710408703a02595a/third_party/blink/renderer/modules/indexeddb/web_idb_database_callbacks.h
[modify] https://crrev.com/82d4392c0d563881b2aacfb9710408703a02595a/third_party/blink/renderer/modules/indexeddb/web_idb_database_callbacks_impl.cc
[modify] https://crrev.com/82d4392c0d563881b2aacfb9710408703a02595a/third_party/blink/renderer/modules/indexeddb/web_idb_database_callbacks_impl.h
[delete] https://crrev.com/9a3224eb7276a84b553f62120c84d94c988af10d/third_party/blink/renderer/modules/indexeddb/web_idb_observation.h

Project Member

Comment 64 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/890e27d18a96fa18b37edff10f737d6599d2a720

commit 890e27d18a96fa18b37edff10f737d6599d2a720
Author: Chase Phillips <cmp@chromium.org>
Date: Fri Dec 14 21:25:16 2018

IndexedDB: Remove unnecessary uses of "using"

Bug: 717812
Change-Id: Ia4e44651b08bb293b175db0c3d92106ebb3f8043
Reviewed-on: https://chromium-review.googlesource.com/c/1366271
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616828}
[modify] https://crrev.com/890e27d18a96fa18b37edff10f737d6599d2a720/third_party/blink/renderer/modules/indexeddb/idb_cursor.cc
[modify] https://crrev.com/890e27d18a96fa18b37edff10f737d6599d2a720/third_party/blink/renderer/modules/indexeddb/idb_cursor_with_value.cc
[modify] https://crrev.com/890e27d18a96fa18b37edff10f737d6599d2a720/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/890e27d18a96fa18b37edff10f737d6599d2a720/third_party/blink/renderer/modules/indexeddb/idb_index.cc
[modify] https://crrev.com/890e27d18a96fa18b37edff10f737d6599d2a720/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/890e27d18a96fa18b37edff10f737d6599d2a720/third_party/blink/renderer/modules/indexeddb/idb_open_db_request.cc
[modify] https://crrev.com/890e27d18a96fa18b37edff10f737d6599d2a720/third_party/blink/renderer/modules/indexeddb/idb_request.cc
[modify] https://crrev.com/890e27d18a96fa18b37edff10f737d6599d2a720/third_party/blink/renderer/modules/indexeddb/idb_transaction.cc
[modify] https://crrev.com/890e27d18a96fa18b37edff10f737d6599d2a720/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/890e27d18a96fa18b37edff10f737d6599d2a720/third_party/blink/renderer/modules/indexeddb/indexed_db_database_callbacks_impl.cc
[modify] https://crrev.com/890e27d18a96fa18b37edff10f737d6599d2a720/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[modify] https://crrev.com/890e27d18a96fa18b37edff10f737d6599d2a720/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc

Project Member

Comment 65 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1db862af32c0ad834a04a54835489e2be87e6ad

commit e1db862af32c0ad834a04a54835489e2be87e6ad
Author: Chase Phillips <cmp@chromium.org>
Date: Fri Dec 14 21:32:01 2018

IndexedDB: Rename WebIDBDatabaseError to IDBDatabaseError

Bug: 717812
Change-Id: I2dedd7a832f053c180e0735a60cd57bccec9f058
Reviewed-on: https://chromium-review.googlesource.com/c/1366380
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616832}
[modify] https://crrev.com/e1db862af32c0ad834a04a54835489e2be87e6ad/third_party/blink/renderer/modules/indexeddb/BUILD.gn
[rename] https://crrev.com/e1db862af32c0ad834a04a54835489e2be87e6ad/third_party/blink/renderer/modules/indexeddb/idb_database_error.h
[modify] https://crrev.com/e1db862af32c0ad834a04a54835489e2be87e6ad/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/e1db862af32c0ad834a04a54835489e2be87e6ad/third_party/blink/renderer/modules/indexeddb/idb_factory_test.cc
[modify] https://crrev.com/e1db862af32c0ad834a04a54835489e2be87e6ad/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/e1db862af32c0ad834a04a54835489e2be87e6ad/third_party/blink/renderer/modules/indexeddb/indexed_db_database_callbacks_impl.cc
[modify] https://crrev.com/e1db862af32c0ad834a04a54835489e2be87e6ad/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
[modify] https://crrev.com/e1db862af32c0ad834a04a54835489e2be87e6ad/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks.h
[modify] https://crrev.com/e1db862af32c0ad834a04a54835489e2be87e6ad/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[modify] https://crrev.com/e1db862af32c0ad834a04a54835489e2be87e6ad/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
[modify] https://crrev.com/e1db862af32c0ad834a04a54835489e2be87e6ad/third_party/blink/renderer/modules/indexeddb/web_idb_database_callbacks.h
[modify] https://crrev.com/e1db862af32c0ad834a04a54835489e2be87e6ad/third_party/blink/renderer/modules/indexeddb/web_idb_database_callbacks_impl.cc
[modify] https://crrev.com/e1db862af32c0ad834a04a54835489e2be87e6ad/third_party/blink/renderer/modules/indexeddb/web_idb_database_callbacks_impl.h
[modify] https://crrev.com/e1db862af32c0ad834a04a54835489e2be87e6ad/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc

Project Member

Comment 66 by bugdroid1@chromium.org, Dec 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2203497e4ea18d1f90d33ceae54da1f65183e024

commit 2203497e4ea18d1f90d33ceae54da1f65183e024
Author: Chase Phillips <cmp@chromium.org>
Date: Thu Dec 27 00:55:28 2018

IndexedDB: Update factory to use origin supplied by browser process

After this change, the origins passed by the renderer are no longer used
in the browser.

A later commit at https://crrev.com/c/1387552 will remove the origin
parameters from the Mojo calls.

Bug: 467150, 717812
Change-Id: Idee3dad0a4f761576abaa9403834dca522f4d929
Reviewed-on: https://chromium-review.googlesource.com/c/1384849
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618987}
[modify] https://crrev.com/2203497e4ea18d1f90d33ceae54da1f65183e024/content/browser/indexed_db/indexed_db_dispatcher_host.cc
[modify] https://crrev.com/2203497e4ea18d1f90d33ceae54da1f65183e024/content/browser/indexed_db/indexed_db_dispatcher_host.h
[modify] https://crrev.com/2203497e4ea18d1f90d33ceae54da1f65183e024/content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc
[modify] https://crrev.com/2203497e4ea18d1f90d33ceae54da1f65183e024/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/2203497e4ea18d1f90d33ceae54da1f65183e024/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/2203497e4ea18d1f90d33ceae54da1f65183e024/content/browser/renderer_interface_binders.cc
[modify] https://crrev.com/2203497e4ea18d1f90d33ceae54da1f65183e024/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/2203497e4ea18d1f90d33ceae54da1f65183e024/content/public/browser/render_process_host.h
[modify] https://crrev.com/2203497e4ea18d1f90d33ceae54da1f65183e024/content/public/test/mock_render_process_host.cc
[modify] https://crrev.com/2203497e4ea18d1f90d33ceae54da1f65183e024/content/public/test/mock_render_process_host.h
[modify] https://crrev.com/2203497e4ea18d1f90d33ceae54da1f65183e024/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/2203497e4ea18d1f90d33ceae54da1f65183e024/third_party/blink/renderer/modules/indexeddb/idb_factory.h

Project Member

Comment 67 by bugdroid1@chromium.org, Dec 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1c5975caad441a10c069183bbcb4fc515468782

commit d1c5975caad441a10c069183bbcb4fc515468782
Author: Chase Phillips <cmp@chromium.org>
Date: Thu Dec 27 03:27:11 2018

IndexedDB: Remove origin from IDBFactory Mojo calls

https://crrev.com/c/1384849 stopped using the origin passed in
Mojo IDB factory calls.  This CL removes the origin parameter
from those calls completely.

Bug: 467150, 717812
Change-Id: Ic8d4864df496591ccca6e2d1b6fb5e5c3b6bd450
Reviewed-on: https://chromium-review.googlesource.com/c/1387552
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618997}
[modify] https://crrev.com/d1c5975caad441a10c069183bbcb4fc515468782/content/browser/indexed_db/indexed_db_dispatcher_host.cc
[modify] https://crrev.com/d1c5975caad441a10c069183bbcb4fc515468782/content/browser/indexed_db/indexed_db_dispatcher_host.h
[modify] https://crrev.com/d1c5975caad441a10c069183bbcb4fc515468782/content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc
[modify] https://crrev.com/d1c5975caad441a10c069183bbcb4fc515468782/third_party/blink/public/mojom/indexeddb/indexeddb.mojom
[modify] https://crrev.com/d1c5975caad441a10c069183bbcb4fc515468782/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/d1c5975caad441a10c069183bbcb4fc515468782/third_party/blink/renderer/modules/indexeddb/idb_factory_test.cc
[modify] https://crrev.com/d1c5975caad441a10c069183bbcb4fc515468782/third_party/blink/renderer/modules/indexeddb/mock_web_idb_factory.h
[modify] https://crrev.com/d1c5975caad441a10c069183bbcb4fc515468782/third_party/blink/renderer/modules/indexeddb/web_idb_factory.h
[modify] https://crrev.com/d1c5975caad441a10c069183bbcb4fc515468782/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.cc
[modify] https://crrev.com/d1c5975caad441a10c069183bbcb4fc515468782/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.h

Comment 68 by dmu...@chromium.org, Jan 3

Blocking: 821175

Project Member

Comment 69 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48e49c78a460dc600e76ef739a2d6d9d914443cd

commit 48e49c78a460dc600e76ef739a2d6d9d914443cd
Author: Chase Phillips <cmp@chromium.org>
Date: Tue Jan 08 20:20:41 2019

IndexedDB: Check for valid origin before binding

Now that origin is provided at bind-time, we can test that the
origin is valid in the browser at that time and only bind when
it's valid.

Bug: 717812, 918493
Change-Id: I1a8e481684aa87c162580b80d4f50ce3f1f799b0
Reviewed-on: https://chromium-review.googlesource.com/c/1399822
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620856}
[modify] https://crrev.com/48e49c78a460dc600e76ef739a2d6d9d914443cd/content/browser/indexed_db/indexed_db_dispatcher_host.cc

Project Member

Comment 70 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc2104d49e6ec23e6806efbe5f2e2c050a7da981

commit cc2104d49e6ec23e6806efbe5f2e2c050a7da981
Author: Chase Phillips <cmp@chromium.org>
Date: Wed Jan 09 01:55:15 2019

IndexedDB: Move IDBKeyRangeBuilder::Build to IDBKeyRange::Create

Bug: 717812
Change-Id: I851085136c1a40389719a29cc453ca6811b493a3
Reviewed-on: https://chromium-review.googlesource.com/c/1368310
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620995}
[modify] https://crrev.com/cc2104d49e6ec23e6806efbe5f2e2c050a7da981/third_party/blink/renderer/modules/indexeddb/BUILD.gn
[modify] https://crrev.com/cc2104d49e6ec23e6806efbe5f2e2c050a7da981/third_party/blink/renderer/modules/indexeddb/idb_key_range.h
[delete] https://crrev.com/55ed1ac4fc073bcfc9dc0538bd48455350d71c29/third_party/blink/renderer/modules/indexeddb/indexed_db_key_builder.cc
[delete] https://crrev.com/55ed1ac4fc073bcfc9dc0538bd48455350d71c29/third_party/blink/renderer/modules/indexeddb/indexed_db_key_builder.h
[modify] https://crrev.com/cc2104d49e6ec23e6806efbe5f2e2c050a7da981/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc

Project Member

Comment 71 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/142c53535abd878822fcabc14c2c5ee3a823f701

commit 142c53535abd878822fcabc14c2c5ee3a823f701
Author: Chase Phillips <cmp@chromium.org>
Date: Thu Jan 10 01:23:26 2019

IndexedDB: Skip ReportBadMessage() at bind-time

ReportBadMessage() requires a valid context which isn't supplied at
bind-time.  Instead, skip reporting an issue and early return which will
cause the request to be freed and the renderer-side of the pipe to be
closed.

Bug: 717812, 918493, 920185, 920406
Change-Id: I4426765e42709e710f3f6d25957c6bb518ca4bcd
Reviewed-on: https://chromium-review.googlesource.com/c/1403351
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621407}
[modify] https://crrev.com/142c53535abd878822fcabc14c2c5ee3a823f701/content/browser/indexed_db/indexed_db_dispatcher_host.cc
[modify] https://crrev.com/142c53535abd878822fcabc14c2c5ee3a823f701/content/browser/renderer_host/render_process_host_impl.cc

Project Member

Comment 72 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd816c6286fc3557fc2b95e045d9e3f7430d5002

commit bd816c6286fc3557fc2b95e045d9e3f7430d5002
Author: Chase Phillips <cmp@chromium.org>
Date: Fri Jan 11 00:38:15 2019

IndexedDB: Make WebIDBCallbacks API match IndexedDBCallbacksImpl

This is the first step to merging WebIDBCallbacksImpl and
IndexedDBCallbacksImpl.  In this step, WebIDBCallbacks APIs are
updated to match IndexedDBCallbacksImpl, which implements the mojom
IDBCallbacks interface.

As part of this step, all of the functionality of
IndexedDBCallbacksImpl for each call is moved to the associated
WebIDBCallbacks implementation.  In some cases, that is
WebIDBCallbacksImpl.  In others, it's an implementation in a
different class.

Once the APIs match, a later CL will delete IndexedDBCallbacksImpl,
update the class hierarchy for WebIDBCallbacks to be based on the
mojom type, and update references to the old IndexedDBCallbacksImpl
callbacks class to WebIDBCallbacksImpl instances.

Bug: 717812
Change-Id: I405b603aaac72ceafa7c4189afb55040e1b3b502
Reviewed-on: https://chromium-review.googlesource.com/c/1371207
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621829}
[modify] https://crrev.com/bd816c6286fc3557fc2b95e045d9e3f7430d5002/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/bd816c6286fc3557fc2b95e045d9e3f7430d5002/third_party/blink/renderer/modules/indexeddb/idb_factory_test.cc
[modify] https://crrev.com/bd816c6286fc3557fc2b95e045d9e3f7430d5002/third_party/blink/renderer/modules/indexeddb/idb_request_test.cc
[modify] https://crrev.com/bd816c6286fc3557fc2b95e045d9e3f7430d5002/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/bd816c6286fc3557fc2b95e045d9e3f7430d5002/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.h
[modify] https://crrev.com/bd816c6286fc3557fc2b95e045d9e3f7430d5002/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.cc
[modify] https://crrev.com/bd816c6286fc3557fc2b95e045d9e3f7430d5002/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
[modify] https://crrev.com/bd816c6286fc3557fc2b95e045d9e3f7430d5002/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks.h
[modify] https://crrev.com/bd816c6286fc3557fc2b95e045d9e3f7430d5002/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[modify] https://crrev.com/bd816c6286fc3557fc2b95e045d9e3f7430d5002/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
[modify] https://crrev.com/bd816c6286fc3557fc2b95e045d9e3f7430d5002/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
[modify] https://crrev.com/bd816c6286fc3557fc2b95e045d9e3f7430d5002/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc
[modify] https://crrev.com/bd816c6286fc3557fc2b95e045d9e3f7430d5002/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[modify] https://crrev.com/bd816c6286fc3557fc2b95e045d9e3f7430d5002/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl_unittest.cc
[modify] https://crrev.com/bd816c6286fc3557fc2b95e045d9e3f7430d5002/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.cc

Project Member

Comment 73 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4051a740480a366150db7d3ba4a98e5893a59b54

commit 4051a740480a366150db7d3ba4a98e5893a59b54
Author: Chase Phillips <cmp@chromium.org>
Date: Fri Jan 11 03:15:03 2019

IndexedDB: Move kNoTransaction enum to WebIDBCallbacksImpl

Bug: 717812
Change-Id: I4e89bd680673adfe883b49ef218883c4c8a65d87
Reviewed-on: https://chromium-review.googlesource.com/c/1395617
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621883}
[modify] https://crrev.com/4051a740480a366150db7d3ba4a98e5893a59b54/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.h
[modify] https://crrev.com/4051a740480a366150db7d3ba4a98e5893a59b54/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
[modify] https://crrev.com/4051a740480a366150db7d3ba4a98e5893a59b54/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.cc

Project Member

Comment 74 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb5b610f19699afba9ded9d2f565ac5d7fbc1a6c

commit cb5b610f19699afba9ded9d2f565ac5d7fbc1a6c
Author: Chase Phillips <cmp@chromium.org>
Date: Fri Jan 11 20:00:22 2019

IndexedDB: Use WebIDBCallbacks to implement the IDBCallbacks interface

IndexedDBCallbacksImpl was originally an implementation of the Mojo
IDBCallbacks interface hosted by the renderer process defined in
content/renderer/.  In onion souping IndexedDB, all of the Mojo
interfaces moved to be hosted in blink/renderer/modules/indexeddb/,
which made the extra layer of IndexedDBCallbacksImpl redundant with
WebIDBCallbacks.

This commit removes the redundant layer, moving the Mojo IDBCallbacks
interface from IndexedDBCallbacksImpl to WebIDBCallbacks.

Bug: 717812
Change-Id: I076002f019f2cf9e5ddb965c504615c8ed60fcf9
Reviewed-on: https://chromium-review.googlesource.com/c/1395558
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622116}
[modify] https://crrev.com/cb5b610f19699afba9ded9d2f565ac5d7fbc1a6c/third_party/blink/renderer/modules/indexeddb/BUILD.gn
[modify] https://crrev.com/cb5b610f19699afba9ded9d2f565ac5d7fbc1a6c/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/cb5b610f19699afba9ded9d2f565ac5d7fbc1a6c/third_party/blink/renderer/modules/indexeddb/idb_request.cc
[delete] https://crrev.com/398b188eab96c3b198b6a4eb8788bba77202aef8/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
[delete] https://crrev.com/398b188eab96c3b198b6a4eb8788bba77202aef8/third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.h
[modify] https://crrev.com/cb5b610f19699afba9ded9d2f565ac5d7fbc1a6c/third_party/blink/renderer/modules/indexeddb/indexed_db_database_callbacks_impl.cc
[modify] https://crrev.com/cb5b610f19699afba9ded9d2f565ac5d7fbc1a6c/third_party/blink/renderer/modules/indexeddb/indexed_db_dispatcher.h
[modify] https://crrev.com/cb5b610f19699afba9ded9d2f565ac5d7fbc1a6c/third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
[modify] https://crrev.com/cb5b610f19699afba9ded9d2f565ac5d7fbc1a6c/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks.h
[modify] https://crrev.com/cb5b610f19699afba9ded9d2f565ac5d7fbc1a6c/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[modify] https://crrev.com/cb5b610f19699afba9ded9d2f565ac5d7fbc1a6c/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
[modify] https://crrev.com/cb5b610f19699afba9ded9d2f565ac5d7fbc1a6c/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
[modify] https://crrev.com/cb5b610f19699afba9ded9d2f565ac5d7fbc1a6c/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.h
[modify] https://crrev.com/cb5b610f19699afba9ded9d2f565ac5d7fbc1a6c/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[modify] https://crrev.com/cb5b610f19699afba9ded9d2f565ac5d7fbc1a6c/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.h
[modify] https://crrev.com/cb5b610f19699afba9ded9d2f565ac5d7fbc1a6c/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.cc
[modify] https://crrev.com/cb5b610f19699afba9ded9d2f565ac5d7fbc1a6c/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.h

Project Member

Comment 75 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bfafb0ee4eeacf365ac7e0b9fb23cec89739e03

commit 4bfafb0ee4eeacf365ac7e0b9fb23cec89739e03
Author: Chase Phillips <cmp@chromium.org>
Date: Fri Jan 11 20:49:16 2019

IndexedDB: Make callbacks CreateAllBlobs static

An upcoming change will use CreateAllBlobs() from outside the callbacks
interface.

Bug: 717812
Change-Id: I8292e0e7471c00d89fc7df5392e9a0a4dcd33173
Reviewed-on: https://chromium-review.googlesource.com/c/1399501
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622138}
[modify] https://crrev.com/4bfafb0ee4eeacf365ac7e0b9fb23cec89739e03/content/browser/indexed_db/indexed_db_callbacks.cc
[modify] https://crrev.com/4bfafb0ee4eeacf365ac7e0b9fb23cec89739e03/content/browser/indexed_db/indexed_db_callbacks.h

Project Member

Comment 76 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a58b89a219e1ddec8ae726250b14fe01d471e56

commit 9a58b89a219e1ddec8ae726250b14fe01d471e56
Author: Chase Phillips <cmp@chromium.org>
Date: Fri Jan 11 22:04:27 2019

IndexedDB: Make IDBCursor.Advance() use native Mojo callback

IDBCursor.Advance() previously took a separate IDBCallbacks interface
that had its own lifecycle and could have a number of methods called
on it.

This change updates Advance() to use Mojo's native callback mechanism
so we can start moving away from the complicated IDBCallbacks
interface and instead use a simpler and easier to reason about async
response return approach.

Bug: 717812
Change-Id: Ia08bebfcafe5f63d60366e81b7f973b1e9ad2378
Reviewed-on: https://chromium-review.googlesource.com/c/1336662
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622176}
[modify] https://crrev.com/9a58b89a219e1ddec8ae726250b14fe01d471e56/content/browser/indexed_db/cursor_impl.cc
[modify] https://crrev.com/9a58b89a219e1ddec8ae726250b14fe01d471e56/content/browser/indexed_db/cursor_impl.h
[modify] https://crrev.com/9a58b89a219e1ddec8ae726250b14fe01d471e56/content/browser/indexed_db/indexed_db_cursor.cc
[modify] https://crrev.com/9a58b89a219e1ddec8ae726250b14fe01d471e56/content/browser/indexed_db/indexed_db_cursor.h
[modify] https://crrev.com/9a58b89a219e1ddec8ae726250b14fe01d471e56/third_party/blink/public/mojom/indexeddb/indexeddb.mojom
[modify] https://crrev.com/9a58b89a219e1ddec8ae726250b14fe01d471e56/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
[modify] https://crrev.com/9a58b89a219e1ddec8ae726250b14fe01d471e56/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
[modify] https://crrev.com/9a58b89a219e1ddec8ae726250b14fe01d471e56/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.h
[modify] https://crrev.com/9a58b89a219e1ddec8ae726250b14fe01d471e56/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc

Project Member

Comment 77 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05a45b6dcd37809569df9aab025ac57b19b37006

commit 05a45b6dcd37809569df9aab025ac57b19b37006
Author: Chase Phillips <cmp@chromium.org>
Date: Wed Jan 16 02:18:32 2019

IndexedDB: Bind all renderer Mojo objects with the IndexedDB task runner

For browser->renderer interfaces, this change ensures that calls issued
by the browser will run in the renderer in the IndexedDB task queue task
runner.

For renderer->browser interfaces with no return calls, this change is
aesthetic.  The calls would have been issued by script running in a
context and would already have a high priority.

Eventually any Mojo interface method that takes a callback will be
updated to use Mojo's async callbacks.  This change means that, when
that happens, the Mojo task will run in the IDB task queue.

Bug: 717812, 913912
Change-Id: I976c36c33214652c2b6e0b4beecab2a1717c1d40
Reviewed-on: https://chromium-review.googlesource.com/c/1410171
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623045}
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/idb_factory_test.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/mock_web_idb_factory.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/mock_web_idb_factory.h
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.h
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.h
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl_unittest.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_factory.h
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.h

►

Issue 717812 link

Issue metadata

Onion-soup for IndexedDB

Issue description

Comment 1 by jsb...@chromium.org, Jun 9 2017

Comment 1 Deleted

Comment 2 by dmu...@chromium.org, May 15 2018

Comment 2 Deleted

Comment 3 by dmu...@chromium.org, May 15 2018

Comment 3 Deleted

Comment 4 by dmu...@chromium.org, May 15 2018

Comment 4 Deleted

Comment 5 by dmu...@chromium.org, May 15 2018

Comment 5 Deleted

Comment 6 by dmu...@chromium.org, May 15 2018

Comment 6 Deleted

Comment 7 by dmu...@chromium.org, May 16 2018

Comment 7 Deleted

Comment 8 by dmu...@chromium.org, May 16 2018

Comment 8 Deleted

Comment 9 by dmu...@chromium.org, May 16 2018

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Jul 25

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Jul 28

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Jul 28

Comment 12 Deleted

Comment 13 by c...@chromium.org, Jul 28

Comment 13 Deleted

Comment 14 by c...@chromium.org, Aug 1

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Aug 2

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Aug 2

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Aug 8

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Aug 8

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Aug 16

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Aug 16

Comment 20 Deleted

Comment 21 by c...@chromium.org, Aug 23

Comment 21 Deleted

Comment 22 by bugdroid1@chromium.org, Aug 24

Comment 22 Deleted

Comment 23 by bugdroid1@chromium.org, Aug 28

Comment 23 Deleted

Comment 24 by bugdroid1@chromium.org, Aug 30

Comment 24 Deleted

Comment 25 by jsb...@chromium.org, Sep 20

Comment 25 Deleted

Comment 26 by bugdroid1@chromium.org, Oct 11

Comment 26 Deleted

Comment 27 by bugdroid1@chromium.org, Oct 16

Comment 27 Deleted

Comment 28 by bugdroid1@chromium.org, Oct 16

Comment 28 Deleted

Comment 29 by bugdroid1@chromium.org, Oct 23

Comment 29 Deleted

Comment 30 by bugdroid1@chromium.org, Oct 25

Comment 30 Deleted

Comment 31 by bugdroid1@chromium.org, Oct 26

Comment 31 Deleted

Comment 32 by bugdroid1@chromium.org, Oct 29

Comment 32 Deleted

Comment 33 by bugdroid1@chromium.org, Oct 30

Comment 33 Deleted

Comment 34 by c...@chromium.org, Nov 2

Comment 34 Deleted

Comment 35 by bugdroid1@chromium.org, Nov 6

Comment 35 Deleted

Comment 36 by bugdroid1@chromium.org, Nov 7

Comment 36 Deleted

Comment 37 by bugdroid1@chromium.org, Nov 7

Comment 37 Deleted

Comment 38 by bugdroid1@chromium.org, Nov 7

Comment 38 Deleted