New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 717810 link

Starred by 2 users
Status: Archived
Owner:
semenzato@chromium.org
Closed: Jul 2017
Cc:
█ bccheng@chromium.org
semenzato@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
Hotlist-2


Sign in to add a comment

Chrome OS: 'swap enable' fails

Project Member Reported by yusukes@chromium.org, May 3 2017 
Chrome OS Platform: R60-9515.0.0 test image 

Steps To Reproduce:
(1) Sign in
(2) Open crosh
(3) Run 'swap enable 500'

Expected Result:

No error.

Actual Result:

It fails with:
/usr/share/cros/init/swap.sh: 349: cannot create /var/lib/swap/swap_enabled: Directory nonexistent

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)

Always.

What is the impact to the user, and is there a workaround? If so, what is
it?

ssh into the device and run 'mkdir /var/lib/swap' seems to fix the issue.

Comment 1 by semenzato@chromium.org, May 3 2017

Labels: -Pri-3 Pri-2
Owner: semenzato@chromium.org

Comment 2 by semenzato@chromium.org, May 3 2017

Labels: -Pri-2 Pri-1
CL at https://chromium-review.googlesource.com/c/493616/

Raising priority because it needs to get into branches soon.

Comment 3 by semenzato@chromium.org, May 3 2017

Labels: -Pri-1 Pri-2
Actually, sorry, no branches.  These new "tunables" are for experimenting, so they don't need to get quickly into release branches.

Comment 4 by yusukes@chromium.org, May 3 2017

Status: Started (was: Unconfirmed)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 21 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c275a3c28f7e5edd6f29499589cbe1eff8bb3e52

commit c275a3c28f7e5edd6f29499589cbe1eff8bb3e52
Author: Luigi Semenzato <semenzato@chromium.org>
Date: Wed Jun 21 06:00:08 2017

swap.sh: fix missing directory creation

The swap_enable command has a separate code path from the
other set_parameter commands, and neglected to create
the new directory for the file that controls the presence
and amount of swap.

BUG= chromium:717810 
TEST=removed the directory and tried "swap_enable 500"

Change-Id: Ic1083ecd04e8dfacdd39bee921f444f164dd9d65
Reviewed-on: https://chromium-review.googlesource.com/493616
Commit-Ready: Luigi Semenzato <semenzato@chromium.org>
Tested-by: Luigi Semenzato <semenzato@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Ben Cheng <bccheng@chromium.org>
(cherry picked from commit fcccde57d019b96c717c833701b3b89c8567b78f)
Reviewed-on: https://chromium-review.googlesource.com/542456
Commit-Queue: Ben Cheng <bccheng@chromium.org>
Tested-by: Ben Cheng <bccheng@chromium.org>
Trybot-Ready: Ben Cheng <bccheng@chromium.org>

[modify] https://crrev.com/c275a3c28f7e5edd6f29499589cbe1eff8bb3e52/chromeos-base/swap-init/files/init/swap.sh
[rename] https://crrev.com/c275a3c28f7e5edd6f29499589cbe1eff8bb3e52/chromeos-base/swap-init/swap-init-0.0.1-r16.ebuild
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/be394ee40940673c896eebd0c866560bb4060e98

commit be394ee40940673c896eebd0c866560bb4060e98
Author: Ben Cheng <bccheng@chromium.org>
Date: Wed Jun 21 17:06:34 2017

Revert "swap.sh: fix missing directory creation"

This reverts commit c275a3c28f7e5edd6f29499589cbe1eff8bb3e52.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> swap.sh: fix missing directory creation
> 
> The swap_enable command has a separate code path from the
> other set_parameter commands, and neglected to create
> the new directory for the file that controls the presence
> and amount of swap.
> 
> BUG= chromium:717810 
> TEST=removed the directory and tried "swap_enable 500"
> 
> Change-Id: Ic1083ecd04e8dfacdd39bee921f444f164dd9d65
> Reviewed-on: https://chromium-review.googlesource.com/493616
> Commit-Ready: Luigi Semenzato <semenzato@chromium.org>
> Tested-by: Luigi Semenzato <semenzato@chromium.org>
> Reviewed-by: Yusuke Sato <yusukes@chromium.org>
> Reviewed-by: Ben Cheng <bccheng@chromium.org>
> (cherry picked from commit fcccde57d019b96c717c833701b3b89c8567b78f)
> Reviewed-on: https://chromium-review.googlesource.com/542456
> Commit-Queue: Ben Cheng <bccheng@chromium.org>
> Tested-by: Ben Cheng <bccheng@chromium.org>
> Trybot-Ready: Ben Cheng <bccheng@chromium.org>

Bug:  chromium:717810 
Change-Id: I2e74de5d8e3d0bf3ece3feb4e601ed41b29ba5c4
Reviewed-on: https://chromium-review.googlesource.com/543678
Reviewed-by: Ben Cheng <bccheng@chromium.org>
Commit-Queue: Ben Cheng <bccheng@chromium.org>
Tested-by: Ben Cheng <bccheng@chromium.org>
Trybot-Ready: Ben Cheng <bccheng@chromium.org>

[modify] https://crrev.com/be394ee40940673c896eebd0c866560bb4060e98/chromeos-base/swap-init/files/init/swap.sh
[rename] https://crrev.com/be394ee40940673c896eebd0c866560bb4060e98/chromeos-base/swap-init/swap-init-0.0.1-r15.ebuild
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/be394ee40940673c896eebd0c866560bb4060e98

commit be394ee40940673c896eebd0c866560bb4060e98
Author: Ben Cheng <bccheng@chromium.org>
Date: Wed Jun 21 17:06:34 2017

Revert "swap.sh: fix missing directory creation"

This reverts commit c275a3c28f7e5edd6f29499589cbe1eff8bb3e52.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> swap.sh: fix missing directory creation
> 
> The swap_enable command has a separate code path from the
> other set_parameter commands, and neglected to create
> the new directory for the file that controls the presence
> and amount of swap.
> 
> BUG= chromium:717810 
> TEST=removed the directory and tried "swap_enable 500"
> 
> Change-Id: Ic1083ecd04e8dfacdd39bee921f444f164dd9d65
> Reviewed-on: https://chromium-review.googlesource.com/493616
> Commit-Ready: Luigi Semenzato <semenzato@chromium.org>
> Tested-by: Luigi Semenzato <semenzato@chromium.org>
> Reviewed-by: Yusuke Sato <yusukes@chromium.org>
> Reviewed-by: Ben Cheng <bccheng@chromium.org>
> (cherry picked from commit fcccde57d019b96c717c833701b3b89c8567b78f)
> Reviewed-on: https://chromium-review.googlesource.com/542456
> Commit-Queue: Ben Cheng <bccheng@chromium.org>
> Tested-by: Ben Cheng <bccheng@chromium.org>
> Trybot-Ready: Ben Cheng <bccheng@chromium.org>

Bug:  chromium:717810 
Change-Id: I2e74de5d8e3d0bf3ece3feb4e601ed41b29ba5c4
Reviewed-on: https://chromium-review.googlesource.com/543678
Reviewed-by: Ben Cheng <bccheng@chromium.org>
Commit-Queue: Ben Cheng <bccheng@chromium.org>
Tested-by: Ben Cheng <bccheng@chromium.org>
Trybot-Ready: Ben Cheng <bccheng@chromium.org>

[modify] https://crrev.com/be394ee40940673c896eebd0c866560bb4060e98/chromeos-base/swap-init/files/init/swap.sh
[rename] https://crrev.com/be394ee40940673c896eebd0c866560bb4060e98/chromeos-base/swap-init/swap-init-0.0.1-r15.ebuild
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/be394ee40940673c896eebd0c866560bb4060e98

commit be394ee40940673c896eebd0c866560bb4060e98
Author: Ben Cheng <bccheng@chromium.org>
Date: Wed Jun 21 17:06:34 2017

Revert "swap.sh: fix missing directory creation"

This reverts commit c275a3c28f7e5edd6f29499589cbe1eff8bb3e52.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> swap.sh: fix missing directory creation
> 
> The swap_enable command has a separate code path from the
> other set_parameter commands, and neglected to create
> the new directory for the file that controls the presence
> and amount of swap.
> 
> BUG= chromium:717810 
> TEST=removed the directory and tried "swap_enable 500"
> 
> Change-Id: Ic1083ecd04e8dfacdd39bee921f444f164dd9d65
> Reviewed-on: https://chromium-review.googlesource.com/493616
> Commit-Ready: Luigi Semenzato <semenzato@chromium.org>
> Tested-by: Luigi Semenzato <semenzato@chromium.org>
> Reviewed-by: Yusuke Sato <yusukes@chromium.org>
> Reviewed-by: Ben Cheng <bccheng@chromium.org>
> (cherry picked from commit fcccde57d019b96c717c833701b3b89c8567b78f)
> Reviewed-on: https://chromium-review.googlesource.com/542456
> Commit-Queue: Ben Cheng <bccheng@chromium.org>
> Tested-by: Ben Cheng <bccheng@chromium.org>
> Trybot-Ready: Ben Cheng <bccheng@chromium.org>

Bug:  chromium:717810 
Change-Id: I2e74de5d8e3d0bf3ece3feb4e601ed41b29ba5c4
Reviewed-on: https://chromium-review.googlesource.com/543678
Reviewed-by: Ben Cheng <bccheng@chromium.org>
Commit-Queue: Ben Cheng <bccheng@chromium.org>
Tested-by: Ben Cheng <bccheng@chromium.org>
Trybot-Ready: Ben Cheng <bccheng@chromium.org>

[modify] https://crrev.com/be394ee40940673c896eebd0c866560bb4060e98/chromeos-base/swap-init/files/init/swap.sh
[rename] https://crrev.com/be394ee40940673c896eebd0c866560bb4060e98/chromeos-base/swap-init/swap-init-0.0.1-r15.ebuild
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 22 2017

Labels: merge-merged-stabilize-9460.66.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ace907eed7a3d50cb12bf9827b65550cfeef6cc3

commit ace907eed7a3d50cb12bf9827b65550cfeef6cc3
Author: Luigi Semenzato <semenzato@chromium.org>
Date: Thu Jun 22 03:56:04 2017

swap.sh: fix missing directory creation

The swap_enable command has a separate code path from the
other set_parameter commands, and neglected to create
the new directory for the file that controls the presence
and amount of swap.

BUG= chromium:717810 
TEST=removed the directory and tried "swap_enable 500"

Change-Id: Ic1083ecd04e8dfacdd39bee921f444f164dd9d65
Reviewed-on: https://chromium-review.googlesource.com/493616
Commit-Ready: Luigi Semenzato <semenzato@chromium.org>
Tested-by: Luigi Semenzato <semenzato@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Ben Cheng <bccheng@chromium.org>
(cherry picked from commit fcccde57d019b96c717c833701b3b89c8567b78f)
Reviewed-on: https://chromium-review.googlesource.com/542456
Commit-Queue: Ben Cheng <bccheng@chromium.org>
Tested-by: Ben Cheng <bccheng@chromium.org>
Trybot-Ready: Ben Cheng <bccheng@chromium.org>
(cherry picked from commit c275a3c28f7e5edd6f29499589cbe1eff8bb3e52)
Reviewed-on: https://chromium-review.googlesource.com/544658

[modify] https://crrev.com/ace907eed7a3d50cb12bf9827b65550cfeef6cc3/chromeos-base/swap-init/files/init/swap.sh
[rename] https://crrev.com/ace907eed7a3d50cb12bf9827b65550cfeef6cc3/chromeos-base/swap-init/swap-init-0.0.1-r16.ebuild
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ace907eed7a3d50cb12bf9827b65550cfeef6cc3

commit ace907eed7a3d50cb12bf9827b65550cfeef6cc3
Author: Luigi Semenzato <semenzato@chromium.org>
Date: Thu Jun 22 03:56:04 2017

swap.sh: fix missing directory creation

The swap_enable command has a separate code path from the
other set_parameter commands, and neglected to create
the new directory for the file that controls the presence
and amount of swap.

BUG= chromium:717810 
TEST=removed the directory and tried "swap_enable 500"

Change-Id: Ic1083ecd04e8dfacdd39bee921f444f164dd9d65
Reviewed-on: https://chromium-review.googlesource.com/493616
Commit-Ready: Luigi Semenzato <semenzato@chromium.org>
Tested-by: Luigi Semenzato <semenzato@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Ben Cheng <bccheng@chromium.org>
(cherry picked from commit fcccde57d019b96c717c833701b3b89c8567b78f)
Reviewed-on: https://chromium-review.googlesource.com/542456
Commit-Queue: Ben Cheng <bccheng@chromium.org>
Tested-by: Ben Cheng <bccheng@chromium.org>
Trybot-Ready: Ben Cheng <bccheng@chromium.org>
(cherry picked from commit c275a3c28f7e5edd6f29499589cbe1eff8bb3e52)
Reviewed-on: https://chromium-review.googlesource.com/544658

[modify] https://crrev.com/ace907eed7a3d50cb12bf9827b65550cfeef6cc3/chromeos-base/swap-init/files/init/swap.sh
[rename] https://crrev.com/ace907eed7a3d50cb12bf9827b65550cfeef6cc3/chromeos-base/swap-init/swap-init-0.0.1-r16.ebuild
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9838d45060eba83dc1ae2dbd4bce8524264ea70e

commit 9838d45060eba83dc1ae2dbd4bce8524264ea70e
Author: Luigi Semenzato <semenzato@chromium.org>
Date: Thu Jun 29 23:59:37 2017

Reland "swap.sh: fix missing directory creation"

This is a reland of c275a3c28f7e5edd6f29499589cbe1eff8bb3e52
Original change's description:
> swap.sh: fix missing directory creation
> 
> The swap_enable command has a separate code path from the
> other set_parameter commands, and neglected to create
> the new directory for the file that controls the presence
> and amount of swap.
> 
> BUG= chromium:717810 
> TEST=removed the directory and tried "swap_enable 500"
> 
> Change-Id: Ic1083ecd04e8dfacdd39bee921f444f164dd9d65
> Reviewed-on: https://chromium-review.googlesource.com/493616
> Commit-Ready: Luigi Semenzato <semenzato@chromium.org>
> Tested-by: Luigi Semenzato <semenzato@chromium.org>
> Reviewed-by: Yusuke Sato <yusukes@chromium.org>
> Reviewed-by: Ben Cheng <bccheng@chromium.org>
> (cherry picked from commit fcccde57d019b96c717c833701b3b89c8567b78f)
> Reviewed-on: https://chromium-review.googlesource.com/542456
> Commit-Queue: Ben Cheng <bccheng@chromium.org>
> Tested-by: Ben Cheng <bccheng@chromium.org>
> Trybot-Ready: Ben Cheng <bccheng@chromium.org>

Bug:  chromium:717810 
Change-Id: I20ef1e3aa4733b404f7de0b79fb0448578c0f0bd
Reviewed-on: https://chromium-review.googlesource.com/557347
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
Commit-Queue: Luigi Semenzato <semenzato@chromium.org>
Tested-by: Luigi Semenzato <semenzato@chromium.org>

[modify] https://crrev.com/9838d45060eba83dc1ae2dbd4bce8524264ea70e/chromeos-base/swap-init/files/init/swap.sh
[rename] https://crrev.com/9838d45060eba83dc1ae2dbd4bce8524264ea70e/chromeos-base/swap-init/swap-init-0.0.1-r16.ebuild

Comment 12 by semenzato@chromium.org, Jul 26 2017

Status: Fixed (was: Started)
This should be fixed.

Comment 13 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment