Allow UKM entries to be recorded without any metrics |
||||||
Issue descriptionCurrently Flash usage UKMs are never recorded due to having no metrics, but there is no technical problem with metric-less entries. Remove the checks blocking this.
,
May 3 2017
Early adding Merge-Request-59, so that approvals will trigger tomorrow afternoon (post-Canary). Also, changing the priority and milestone, since it's critical for outreach.
,
May 3 2017
Please tag with applicable OSs. Thanks.
,
May 3 2017
,
May 4 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1fc814ad6f4c091de81292f9ce4c4bb8a5bf148 commit c1fc814ad6f4c091de81292f9ce4c4bb8a5bf148 Author: Steven Holte <holte@google.com> Date: Thu May 04 20:27:29 2017 Allow empty UKM entries to be recorded. BUG= 717793 Review-Url: https://codereview.chromium.org/2855053002 Cr-Commit-Position: refs/heads/master@{#469101} (cherry picked from commit 60d054d1f297debcae848680eead71f2517003fc) Review-Url: https://codereview.chromium.org/2857983006 . Cr-Commit-Position: refs/branch-heads/3071@{#406} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/c1fc814ad6f4c091de81292f9ce4c4bb8a5bf148/components/ukm/ukm_entry.cc [modify] https://crrev.com/c1fc814ad6f4c091de81292f9ce4c4bb8a5bf148/components/ukm/ukm_entry_builder.cc [modify] https://crrev.com/c1fc814ad6f4c091de81292f9ce4c4bb8a5bf148/components/ukm/ukm_service.h [modify] https://crrev.com/c1fc814ad6f4c091de81292f9ce4c4bb8a5bf148/components/ukm/ukm_service_unittest.cc
,
Jun 13 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, May 3 2017