New issue
Advanced search Search tips

Issue 717779 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Fork login screen assets for md-implementation

Project Member Reported by jdufault@chromium.org, May 2 2017

Issue description

Fork login screen assets for md-implementation so that we can begin implementing new UI without affecting existing visuals. Supporting two separate UIs in the same code-base will introduce unnecessary delays and risk.
 
Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca

commit ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca
Author: jdufault <jdufault@chromium.org>
Date: Wed May 03 17:40:20 2017

cros: Selectively fork login assets.

This CL forks login code which is most likely to change with the new UI. This
allows us to make breaking changes to the login screen without worrying about
the previous UI.

This adds an `isMd` boolean variable in the global scope that can be dynamically
queried if we need to make changes in a file and it is not trivial to fork it.
Otherwise, there are no code changes besides loading different assets.

BUG= 717779 
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2855883005
Cr-Commit-Position: refs/heads/master@{#469026}

[modify] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/chrome/browser/browser_resources.grd
[modify] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/chrome/browser/resources/chromeos/login/login.js
[add] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/chrome/browser/resources/chromeos/login/md_login.html
[add] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/chrome/browser/resources/chromeos/login/md_login.js
[add] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/chrome/browser/resources/chromeos/login/md_login_screens.html
[add] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/chrome/browser/resources/chromeos/login/md_login_shared.html
[add] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/chrome/browser/resources/chromeos/login/md_login_shared.js
[add] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/chrome/browser/resources/chromeos/login/md_screen_container.html
[modify] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/chromeos/chromeos_switches.cc
[modify] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/chromeos/chromeos_switches.h
[add] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/ui/login/account_picker/md_screen_account_picker.css
[add] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/ui/login/account_picker/md_screen_account_picker.html
[add] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/ui/login/account_picker/md_screen_account_picker.js
[add] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/ui/login/account_picker/md_user_pod_row.css
[add] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/ui/login/account_picker/md_user_pod_row.js
[add] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/ui/login/account_picker/md_user_pod_template.css
[add] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/ui/login/account_picker/md_user_pod_template.html
[add] https://crrev.com/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca/ui/login/md_screen_container.css

Status: Fixed (was: Started)

Sign in to add a comment