New issue
Advanced search Search tips

Issue 717777 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Omnibox UI Experiments: Add ability to vary vertical margin via about:flags

Project Member Reported by tommycli@chromium.org, May 2 2017

Issue description

Omnibox UI Experiments: Add ability to vary vertical margin via about:flags
 
Screenshot of PS1 here: https://codereview.chromium.org/2854263002
Screenshot from 2017-05-02 16:07:36.png
159 KB View Download
FYI, this is the first step in a series of experimental suggest UI changes we'll be making. We'll be sharing a plan soon that describes the changes and our plans for evaluating them.
Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c821888667803cb403d104523637008200b5161

commit 6c821888667803cb403d104523637008200b5161
Author: tommycli <tommycli@chromium.org>
Date: Wed May 10 22:20:48 2017

Omnibox UI Experiments: Clean up naming for Vertical Margin

Previous naming was a bit convoluted because we thought we would
coalesce all UI experiments into a single base::Feature.

New thinking is that it's cleanest to make a separate base::Feature for
each UI experiment.

BUG= 717777 

Review-Url: https://codereview.chromium.org/2874593002
Cr-Commit-Position: refs/heads/master@{#470729}

[modify] https://crrev.com/6c821888667803cb403d104523637008200b5161/chrome/browser/about_flags.cc
[modify] https://crrev.com/6c821888667803cb403d104523637008200b5161/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/6c821888667803cb403d104523637008200b5161/components/omnibox/browser/omnibox_field_trial.cc
[modify] https://crrev.com/6c821888667803cb403d104523637008200b5161/components/omnibox/browser/omnibox_field_trial.h
[modify] https://crrev.com/6c821888667803cb403d104523637008200b5161/tools/metrics/histograms/enums.xml

Adding screenshot of Cocoa implementation: 
Screen Shot 2017-05-10 at 4.22.15 PM.png
270 KB View Download
Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0705a49d8d56f04b6178d0d8dceed9c83d2105fb

commit 0705a49d8d56f04b6178d0d8dceed9c83d2105fb
Author: tommycli <tommycli@chromium.org>
Date: Thu Jun 08 18:00:42 2017

Omnibox UI Experiments: Make vertical margin options increments of 2px

Increments of 4px were too much -- and 16px and 20px were comically
large.

BUG= 717777 

Review-Url: https://codereview.chromium.org/2931653002
Cr-Commit-Position: refs/heads/master@{#478021}

[modify] https://crrev.com/0705a49d8d56f04b6178d0d8dceed9c83d2105fb/chrome/browser/about_flags.cc

Cc: kkaluri@chromium.org
Labels: TE-Verified-61.0.3128.0 TE-Verified-M61
Verified this issue on Windows 10, Ubuntu 14.04 and Mac 10.12.5 with chrome #61.0.3128.0

As per comment comment #9, observed under "omnibox UI Vertical Margin" flag  have seen increments in 2px, hence adding TE-Verified labels.

Attaching the screen-cast for reference.
717777.mp4
524 KB View Download

Sign in to add a comment