New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717775 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: decoder_delay_ < original_frame_count in audio_discard_helper.cc

Project Member Reported by ClusterFuzz, May 2 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6684477320593408

Fuzzer: libfuzzer_media_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  decoder_delay_ < original_frame_count in audio_discard_helper.cc
  media::AudioDiscardHelper::ProcessBuffers
  media::FFmpegAudioDecoder::FFmpegDecode
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=437773:438087

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6684477320593408


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: msrchandra@chromium.org
Labels: Test-Predator-Wrong-CLs M-60
Owner: dalecur...@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL did not provide any possible suspects.
Using Code Search for the file, "audio_discard_helper.cc" assigning to the concern owner who might be related to the file.

@dalecurtis -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Cc: chcunningham@chromium.org
Will take a look, seems like it maybe should just be <= but will have to recall the discard helper code.
Project Member

Comment 3 by ClusterFuzz, May 5 2017

ClusterFuzz has detected this issue as fixed in range 469306:469316.

Detailed report: https://clusterfuzz.com/testcase?key=6684477320593408

Fuzzer: libfuzzer_media_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  decoder_delay_ < original_frame_count in audio_discard_helper.cc
  media::AudioDiscardHelper::ProcessBuffers
  media::FFmpegAudioDecoder::FFmpegDecode
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=437773:438087
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=469306:469316

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6684477320593408


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 4 by ClusterFuzz, May 5 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6684477320593408 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
chcunningham@ did anything change on this while I was out? Seems like this is an incorrect result otherwise.
Sorry, not that I'm aware of.
Labels: ClusterFuzz-Wrong
Status: Started (was: Verified)
Not sure why this is verified, it trivially repro'd for me, fix here:

https://codereview.chromium.org/2884383003
Project Member

Comment 8 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6548bcbdb7254440df8aab0fa8d9bc1dc179364e

commit 6548bcbdb7254440df8aab0fa8d9bc1dc179364e
Author: dalecurtis <dalecurtis@chromium.org>
Date: Thu May 18 18:42:05 2017

Replace DCHECK with conditional and error.

libfuzzer always finds a way to trigger these; thanks! This replaces
a discard helper DCHECK with a conditional failure.

BUG= 717775 
TEST=fuzzer doesn't check fail anymore.

Review-Url: https://codereview.chromium.org/2884383003
Cr-Commit-Position: refs/heads/master@{#472885}

[modify] https://crrev.com/6548bcbdb7254440df8aab0fa8d9bc1dc179364e/media/base/audio_discard_helper.cc

Status: Fixed (was: Started)
Labels: -ClusterFuzz-Wrong
We have made a bunch of changes on ClusterFuzz side, so resetting ClusterFuzz-Wrong label.

Sign in to add a comment