New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717761 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Minimize animation is disabled on fullscreen/maximized exo window

Project Member Reported by osh...@chromium.org, May 2 2017

Issue description

because we disable all animations for maximize/fullscreen state.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0

commit 30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0
Author: oshima <oshima@chromium.org>
Date: Wed May 03 22:31:35 2017

Do not disable minimize animation for maximized/fullscreened exo windows

BUG= 717761 
TEST=Fullscreen/Maximize Play Store app, then minimize/unminmize.

Review-Url: https://codereview.chromium.org/2861523002
Cr-Commit-Position: refs/heads/master@{#469171}

[modify] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/components/exo/shell_surface.cc

Labels: Merge-Request-58 Merge-Request-59
Labels: Merge-Approved-59
Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff3a93f666037548cc7120e82fdea9197d1caf8f

commit ff3a93f666037548cc7120e82fdea9197d1caf8f
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Thu May 04 14:44:57 2017

Do not disable minimize animation for maximized/fullscreened exo windows

BUG= 717761 
TEST=Fullscreen/Maximize Play Store app, then minimize/unminmize.

Review-Url: https://codereview.chromium.org/2861523002
Cr-Commit-Position: refs/heads/master@{#469171}
(cherry picked from commit 30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0)

Review-Url: https://codereview.chromium.org/2864433004 .
Cr-Commit-Position: refs/branch-heads/3071@{#398}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/ff3a93f666037548cc7120e82fdea9197d1caf8f/components/exo/shell_surface.cc

Cc: bhthompson@chromium.org
Labels: -merge-merged-3071 Merge-Approved-59
bhthompson@ for m58. This is fairly safe and worth considering 58 merge.
Labels: -Merge-Request-58 Merge-Approved-58
LGTM for 58, assuming it has been verified on a higher channel. 
Project Member

Comment 7 by sheriffbot@chromium.org, May 5 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, May 6 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b849071b201e27f26a5cb7a87298793ad2edd48b

commit b849071b201e27f26a5cb7a87298793ad2edd48b
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Sat May 06 01:53:55 2017

Do not disable minimize animation for maximized/fullscreened exo windows

BUG= 717761 
TEST=Fullscreen/Maximize Play Store app, then minimize/unminmize.

Review-Url: https://codereview.chromium.org/2861523002
Cr-Commit-Position: refs/heads/master@{#469171}
(cherry picked from commit 30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0)

Review-Url: https://codereview.chromium.org/2863683006 .
Cr-Commit-Position: refs/branch-heads/3029@{#811}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/b849071b201e27f26a5cb7a87298793ad2edd48b/components/exo/shell_surface.cc

Project Member

Comment 10 by sheriffbot@chromium.org, May 8 2017

Cc: bhthompson@google.com gkihumba@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by sheriffbot@chromium.org, May 12 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-59 merge-merged-3071
Components: Internals>MUS

Comment 14 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment