New issue
Advanced search Search tips

Issue 717756 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

dromaeo.jslibmodifyjquery failing on android

Project Member Reported by rnep...@chromium.org, May 2 2017

Issue description

Looks like a crash. Starting a bisect.

=== BISECT JOB RESULTS ===
NO Test failure found

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : dromaeo.jslibstyleprototype
  Metric       : application_energy_consumption_mwh/application_energy_consumption_mwh

Revision             Exit Code      N
chromium@468456      0 +- N/A       2      good
chromium@468552      0 +- N/A       2      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests dromaeo.jslibstyleprototype

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980669844000362368

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4954887114194944


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Bah, selected the wrong benchmark. Starting another.
Owner: nedngu...@google.com
Hey Ned, I think your CL may have caused this:
https://chromium-review.googlesource.com/c/492489/


If you look at the step where the json file that tells the android test runner what tests to run, you will see that it lists dromaeo.jslib* tests.

https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_One_Perf__3_%2F5173%2F%2B%2Frecipes%2Fsteps%2FList_Perf_Tests%2F0%2Flogs%2Fjson.output%2F0


I think this is becuase we generate the list of tests to run differently on android as opposed to the rest of telemetry. This is an artifact of device affinity and should go away when we move to swarming. 
I didn't give enough data, this test wasn't running on this bot before your CL.
Oh bummer. This is because the old Android bots still rely on the list perf benchmarks step.
Status: Started (was: Untriaged)
Project Member

Comment 9 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5656628563d79c5e56899b0103eb35e2576e83db

commit 5656628563d79c5e56899b0103eb35e2576e83db
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Wed May 03 01:49:25 2017

Roll src/third_party/catapult/ d5f518884..08f16b69a (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d5f518884cf7..08f16b69a788

$ git log d5f518884..08f16b69a --date=short --no-merges --format='%ad %ae %s'
2017-05-02 nednguyen Ignore contrib benchmarks in json list benchmarks command

Created with:
  roll-dep src/third_party/catapult
BUG= 717756 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ia9f2cd6795e389018965e3faa15c5f864477d4cb
Reviewed-on: https://chromium-review.googlesource.com/494326
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468859}
[modify] https://crrev.com/5656628563d79c5e56899b0103eb35e2576e83db/DEPS

Sign in to add a comment