New issue
Advanced search Search tips

Issue 717743 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

hterm: preferences: support translation readable text

Project Member Reported by vapier@chromium.org, May 2 2017

Issue description

most hterm strings are not user visible (they're in the JS console), so we don't need to translate them.  however, all the descriptions for the preferences are user visible via the options page.  we should support translating these.

things get tricky because the strings live in hterm/js/hterm_preference_manager.js, and all the translated strings live in nassh/_locales/.

once  issue 717742  is implemented, we'll also want to translate the preference name.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/fbf5efc1d28cbc8f20ae21aebdd383f1aa25fc01

commit fbf5efc1d28cbc8f20ae21aebdd383f1aa25fc01
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Dec 07 08:17:50 2017

libdot: run replacements on default messages too

The current message manager helper will use the default text without
running any replacements on it.  This makes it difficult to process
arguments with the default text and actual localized messages.

We also tweak the get behavior so we automatically register the text
using the fallback value so we avoid warnings in the future.  Code
shouldn't be using different default values for the same id.

BUG= chromium:717743 

Change-Id: I2d37879da4032756214aa6e0131b2e638d1fbc62
Reviewed-on: https://chromium-review.googlesource.com/810464
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Brandon Gilmore <varz@google.com>

[modify] https://crrev.com/fbf5efc1d28cbc8f20ae21aebdd383f1aa25fc01/libdot/js/lib_message_manager.js
[modify] https://crrev.com/fbf5efc1d28cbc8f20ae21aebdd383f1aa25fc01/libdot/js/lib_message_manager_tests.js

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/dea993dc64b29611f368f54b3c0e3f955ccb5663

commit dea993dc64b29611f368f54b3c0e3f955ccb5663
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Dec 08 05:46:31 2017

hterm: add localization logic

We want to be able to display messages directly, so make sure they
can be localized properly.

BUG= chromium:717743 

Change-Id: Icf0dfeebebb8adc1b3b32ccf43b8d49519fbaa5c
Reviewed-on: https://chromium-review.googlesource.com/810040
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Brandon Gilmore <varz@google.com>

[modify] https://crrev.com/dea993dc64b29611f368f54b3c0e3f955ccb5663/hterm/js/hterm.js

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/4f51cc26596bbdcee845f1a28a28400ebc49e344

commit 4f51cc26596bbdcee845f1a28a28400ebc49e344
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Dec 08 05:46:35 2017

libdot: fix loadMessages callback

When using onloadend, the status field ends up as 0 instead of 200 even
when the request succeeded.  Switch to using onload and onerror directly
for the two callbacks to avoid that.

BUG= chromium:717743 

Change-Id: I5b2d75830e81525190e386622ab25947211515b9
Reviewed-on: https://chromium-review.googlesource.com/814757
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Brandon Gilmore <varz@google.com>

[modify] https://crrev.com/4f51cc26596bbdcee845f1a28a28400ebc49e344/libdot/js/lib_message_manager.js

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/34acca57cbb81eccbab48eb62926d632a0238c67

commit 34acca57cbb81eccbab48eb62926d632a0238c67
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Dec 12 04:05:10 2017

nassh: support translating all the hterm preferences

For English readers, nothing changes.  For everyone else, this will be
a win once we can get the translations out :).

BUG= chromium:717743 

Change-Id: I08ef916d7d84095e7449ae9f06c53de799f63767
Reviewed-on: https://chromium-review.googlesource.com/817396
Reviewed-by: Brandon Gilmore <varz@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/34acca57cbb81eccbab48eb62926d632a0238c67/nassh/js/nassh_preferences_editor.js
[modify] https://crrev.com/34acca57cbb81eccbab48eb62926d632a0238c67/nassh/_locales/en/messages.json

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/dd4ebf1d6b16455122f7358f977f0e60df562ab6

commit dd4ebf1d6b16455122f7358f977f0e60df562ab6
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Dec 13 19:01:55 2017

hterm: add a test to keep nassh translations in sync

Make sure that preferences we add or change stay in sync with nassh.

BUG= chromium:717743 

Change-Id: I11bca7f09e5bc817adfa059b3ec1c008b9b2e812
Reviewed-on: https://chromium-review.googlesource.com/817397
Reviewed-by: Brandon Gilmore <varz@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/dd4ebf1d6b16455122f7358f977f0e60df562ab6/hterm/js/hterm_preference_manager.js
[modify] https://crrev.com/dd4ebf1d6b16455122f7358f977f0e60df562ab6/hterm/html/hterm_test.html
[add] https://crrev.com/dd4ebf1d6b16455122f7358f977f0e60df562ab6/hterm/js/hterm_preference_manager_tests.js

Comment 6 by vapier@chromium.org, Dec 13 2017

Owner: vapier@chromium.org
Status: Fixed (was: Available)
this will be in hterm-1.76+ and nassh-0.8.41+, but will take a few releases before non-english translations catch up
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/8d40a0557af5e304d33c39fa19ac9d8340cec85c

commit 8d40a0557af5e304d33c39fa19ac9d8340cec85c
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Jun 21 17:00:17 2018

nassh: support translating hterm categories

We've been translating all the help text but not the headers.

Bug:  chromium:717743 
Change-Id: Id6d1d2865670bcca66843defb91c70dd4dbac5f4
Reviewed-on: https://chromium-review.googlesource.com/1110141
Reviewed-by: Vitaliy Shipitsyn <vsh@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/8d40a0557af5e304d33c39fa19ac9d8340cec85c/nassh/js/nassh_preferences_editor.js
[modify] https://crrev.com/8d40a0557af5e304d33c39fa19ac9d8340cec85c/nassh/_locales/en/messages.json

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/94982472760469adabc07133dfa595d5ef5b9168

commit 94982472760469adabc07133dfa595d5ef5b9168
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Jun 21 23:03:39 2018

hterm: update nassh translation test to cover categories

Bug:  chromium:717743 
Change-Id: Id888f8806af03e2c2e6896a2f0aa2bc65e5fa129
Reviewed-on: https://chromium-review.googlesource.com/1110142
Reviewed-by: Vitaliy Shipitsyn <vsh@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/94982472760469adabc07133dfa595d5ef5b9168/hterm/js/hterm_preference_manager.js
[modify] https://crrev.com/94982472760469adabc07133dfa595d5ef5b9168/hterm/js/hterm_preference_manager_tests.js

Sign in to add a comment