New issue
Advanced search Search tips

Issue 717719 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Parallel download has higher interruption rate compared to regular download

Project Member Reported by qin...@chromium.org, May 2 2017

Issue description

UMA stats show that the interruption rate is higher for parallel download, compared to parallelizable download.

When querying Download.InterruptedReason, ParallelDownload has a high SERVER_FAILED interruption percentage
 
Labels: ReleaseBlock-Beta
Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a542d8debc1075277dfa8de50dea36fb96d5aff

commit 2a542d8debc1075277dfa8de50dea36fb96d5aff
Author: qinmin <qinmin@chromium.org>
Date: Wed May 03 23:20:33 2017

Clear callback when a parallel request can no longer write any data

If a StreamReader is found that it can no longer write any data, we should
clear its callback.
Otherwise, the StreamReader can  still report an error and interrupt the download.

BUG= 717719 

If the data has already been written

Review-Url: https://codereview.chromium.org/2861443005
Cr-Commit-Position: refs/heads/master@{#469193}

[modify] https://crrev.com/2a542d8debc1075277dfa8de50dea36fb96d5aff/content/browser/download/download_file_impl.cc
[modify] https://crrev.com/2a542d8debc1075277dfa8de50dea36fb96d5aff/content/browser/download/download_file_unittest.cc

Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Chatted with qinmin.  This won't be blocking this week's beta release.
Labels: Merge-Request-59
Project Member

Comment 5 by sheriffbot@chromium.org, May 4 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, May 4 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9f4cf07ee20ae79f205f85610969ecb64c9dd3a

commit c9f4cf07ee20ae79f205f85610969ecb64c9dd3a
Author: Min Qin <qinmin@chromium.org>
Date: Thu May 04 16:56:50 2017

Clear callback when a parallel request can no longer write any data

If a StreamReader is found that it can no longer write any data, we should
clear its callback.
Otherwise, the StreamReader can  still report an error and interrupt the download.

TBR=xingliu@chromium.org
BUG= 717719 

If the data has already been written

Review-Url: https://codereview.chromium.org/2861443005
Cr-Commit-Position: refs/heads/master@{#469193}
(cherry picked from commit 2a542d8debc1075277dfa8de50dea36fb96d5aff)

Catch more exception when accessing content URI

Accessing content URI can throw more exceptions than expected.
This CL catch all possible exceptions so we don't crash.

BUG=706299

Review-Url: https://codereview.chromium.org/2861583008
Cr-Commit-Position: refs/heads/master@{#469208}
(cherry picked from commit 62b10acb8db135704af395a51ecf72d499944d76)

Review-Url: https://codereview.chromium.org/2861013002 .
Cr-Commit-Position: refs/branch-heads/3071@{#403}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/c9f4cf07ee20ae79f205f85610969ecb64c9dd3a/content/browser/download/download_file_impl.cc
[modify] https://crrev.com/c9f4cf07ee20ae79f205f85610969ecb64c9dd3a/content/browser/download/download_file_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment