New issue
Advanced search Search tips

Issue 717717 link

Starred by 1 user
Status: Fixed
Owner:
zhangtiff@chromium.org
Closed: Jun 2017
Cc:
seanmccullough@chromium.org
zhangtiff@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Restructure Sheriff-o-Matic

Project Member Reported by zhangtiff@chromium.org, May 2 2017 
Oops, I submitted this bug by accident before writing a description. But I wanted to say that I want to try to study some more existing Polymer apps and figure out a better way to structure our frontend code. At the moment, making small changes feels like it takes a frustrating amount of plumbing.

Comment 1 by seanmccullough@chromium.org, May 2 2017

Cc: -martiniss@chromium.org
Labels: -Infra-DX Milestone-Reliability
Status: Available (was: Untriaged)

Comment 2 by zhangtiff@chromium.org, May 2 2017

Description: Show this description

Comment 3 by zhangtiff@chromium.org, May 2 2017

Owner: zhangtiff@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, May 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/76d3bbc000867410e46516ec93a6920c707eff4f

commit 76d3bbc000867410e46516ec93a6920c707eff4f
Author: Tiff Zhang <zhangtiff@google.com>
Date: Thu May 25 19:23:14 2017

SoM: Refactor som-app by separating out alert logic.

Bug:717717

Change-Id: I915b971197e72e7f1a068539957329dd471ff446
Reviewed-on: https://chromium-review.googlesource.com/513382
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>

[add] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-alert-view/som-alert-view.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-drawer/som-drawer.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure/som-extension-build-failure.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-drawer/som-drawer.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-master-restarts/som-master-restarts.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/test/som-extension-build-failure-test.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-annotations/som-annotations.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-annotations/som-annotations.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-app/som-app.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-settings/som-settings.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-cros-failure/som-extension-cros-failure.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-bug-queue/som-bug-queue.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/test/index.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/test/som-drawer-test.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/som/index.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-examine/som-examine.js
[add] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-alert-view/som-alert-view.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-examine/som-examine.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/test/som-app-test.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item/som-alert-item.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-marked-element/som-marked-element.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-rev-range/som-rev-range.js
[add] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/test/som-alert-view-test.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-swarming-bots/som-swarming-bots.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-tree-status/som-tree-status.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-app/som-app.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-test-expectations/som-test-expectations.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure/som-extension-build-failure.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/.clang-format
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-webkit-tests/som-webkit-tests.js
Project Member

Comment 5 by bugdroid1@chromium.org, May 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/76d3bbc000867410e46516ec93a6920c707eff4f

commit 76d3bbc000867410e46516ec93a6920c707eff4f
Author: Tiff Zhang <zhangtiff@google.com>
Date: Thu May 25 19:23:14 2017

SoM: Refactor som-app by separating out alert logic.

Bug:717717

Change-Id: I915b971197e72e7f1a068539957329dd471ff446
Reviewed-on: https://chromium-review.googlesource.com/513382
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>

[add] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-alert-view/som-alert-view.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-drawer/som-drawer.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure/som-extension-build-failure.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-drawer/som-drawer.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-master-restarts/som-master-restarts.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/test/som-extension-build-failure-test.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-annotations/som-annotations.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-annotations/som-annotations.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-app/som-app.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-settings/som-settings.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-cros-failure/som-extension-cros-failure.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-bug-queue/som-bug-queue.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/test/index.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/test/som-drawer-test.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/som/index.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-examine/som-examine.js
[add] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-alert-view/som-alert-view.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-examine/som-examine.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/test/som-app-test.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item/som-alert-item.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-marked-element/som-marked-element.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-rev-range/som-rev-range.js
[add] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/test/som-alert-view-test.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-swarming-bots/som-swarming-bots.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-tree-status/som-tree-status.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-app/som-app.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-test-expectations/som-test-expectations.js
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure/som-extension-build-failure.html
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/.clang-format
[modify] https://crrev.com/76d3bbc000867410e46516ec93a6920c707eff4f/go/src/infra/appengine/sheriff-o-matic/elements/som-webkit-tests/som-webkit-tests.js
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/715156b23026711ba4b50e392fca8cde274fb672

commit 715156b23026711ba4b50e392fca8cde274fb672
Author: Tiff Zhang <zhangtiff@google.com>
Date: Thu Jun 08 22:40:38 2017

SoM: Move alert opened/closed state from annotations to som-alert-item.


Bug:717717
Change-Id: I12d22bf5ba8936aff4c8b33e6e5d173feb7000d6
Reviewed-on: https://chromium-review.googlesource.com/527934
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/715156b23026711ba4b50e392fca8cde274fb672/go/src/infra/appengine/sheriff-o-matic/frontend/test/index.html
[modify] https://crrev.com/715156b23026711ba4b50e392fca8cde274fb672/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.js
[modify] https://crrev.com/715156b23026711ba4b50e392fca8cde274fb672/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.js
[delete] https://crrev.com/4549d086b7982b47ae4d1ca6d3eed3b687b24521/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-annotation-manager-behavior-test.html
[modify] https://crrev.com/715156b23026711ba4b50e392fca8cde274fb672/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotation-manager-behavior.html
[modify] https://crrev.com/715156b23026711ba4b50e392fca8cde274fb672/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.html
[modify] https://crrev.com/715156b23026711ba4b50e392fca8cde274fb672/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-annotations-test.html
[modify] https://crrev.com/715156b23026711ba4b50e392fca8cde274fb672/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-alert-item-test.html
[modify] https://crrev.com/715156b23026711ba4b50e392fca8cde274fb672/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.js
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b52adb9090fafd482cc1570f321fdddcf2dc9ad2

commit b52adb9090fafd482cc1570f321fdddcf2dc9ad2
Author: Tiff Zhang <zhangtiff@google.com>
Date: Fri Jun 09 22:43:37 2017

SoM: Make infra failures/other alert sections collapsible and refactored alert categories into a separate element.

Bug:730315
Bug:718127
Bug:717717
Change-Id: I51bb83fa49bdf0c47a8db017cd8cc112b035ee64
Reviewed-on: https://chromium-review.googlesource.com/529966
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-app/som-app.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.html
[add] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-category/som-alert-category.js
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotation-manager-behavior.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-app/som-app.js
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-build-failure/som-extension-build-failure.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.js
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-settings/som-settings.html
[add] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-category/som-alert-category.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.js
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.js
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-alert-item-test.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.html
[add] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-utility-styles.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-alert-view-test.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-bug-queue/som-bug-queue.html
[add] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-alert-category-test.html
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-settings/som-settings.js
[modify] https://crrev.com/b52adb9090fafd482cc1570f321fdddcf2dc9ad2/go/src/infra/appengine/sheriff-o-matic/frontend/test/index.html

Comment 8 by zhangtiff@chromium.org, Jun 14 2017

Status: Fixed (was: Assigned)
A lot of big things have been split up and a lot of other things have been cleaned up as well. I think I would be fine with calling this done for now.
►

Sign in to add a comment